From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA106C433DB for ; Mon, 21 Dec 2020 09:34:41 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 411F722CA2 for ; Mon, 21 Dec 2020 09:34:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 411F722CA2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6FE396B005C; Mon, 21 Dec 2020 04:34:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6AE3F6B005D; Mon, 21 Dec 2020 04:34:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5757E6B0068; Mon, 21 Dec 2020 04:34:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0021.hostedemail.com [216.40.44.21]) by kanga.kvack.org (Postfix) with ESMTP id 3E9406B005C for ; Mon, 21 Dec 2020 04:34:40 -0500 (EST) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id F180882499A8 for ; Mon, 21 Dec 2020 09:34:39 +0000 (UTC) X-FDA: 77616779478.10.angle93_510495627456 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin10.hostedemail.com (Postfix) with ESMTP id 0F93F16A4B1 for ; Mon, 21 Dec 2020 09:34:28 +0000 (UTC) X-HE-Tag: angle93_510495627456 X-Filterd-Recvd-Size: 4468 Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) by imf11.hostedemail.com (Postfix) with ESMTP for ; Mon, 21 Dec 2020 09:34:27 +0000 (UTC) Received: by mail-pf1-f177.google.com with SMTP id d2so6141366pfq.5 for ; Mon, 21 Dec 2020 01:34:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9oI6PpbsNinrAY/UY/16dtjoAnO4VqhB1tmPSdI/mzw=; b=rhSiOJwy3U4u0Kw1EqHDbBvUoYsSF7bEya7dN9TqYVff8KYrfn4UChVh7IQq/1A9Hl dAjMNaS84HENeb8/nKBjvZN7gmKZ5lgqJI4lpX58TXd2r4oCuqj4CB7BHPmKKSaLaHoc lHMzUSmt9hw8K+yONpy8aFqQ/L4Do1Cwy4ZZR3ZFOnacCdVA1DOo5MzeguNrLwsgsRHo gHIvGZr71szBt0uZE3efY7l8C2RF2iWCb351IPFzUuia9o9b5npWOw8JAXptrZz+dY+h eHA8JHujNp0vf2XAROIjtg0hYg6zm6xieVMPX69Oh7q1hOHDsB+1qvQt/w4VACFcfLJg SL/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9oI6PpbsNinrAY/UY/16dtjoAnO4VqhB1tmPSdI/mzw=; b=F03xI4D8K937FDb1NTCrQGpD+gins+DfmPQVryf0pzO9mGSlNBeceT76Kd5xaiIW0n fWf54ZDWNols4aUI4hajRTPFAKOr/Am6xFqSSBAF+WspUS/n/wa/HE2nvJkD3QnjoayP QdqBcJ3dzfZGnkHnPNq2tenOF+T0cmIkP/qbKBkefjkstwGSMQH9jOvlUwltye/Q5iOi ylS1Ki/ruduAkNvrwIwKlvgZne+7hqmBxPJezZQ3mwOZg/bGq847GDR0HNEFB1uxCsLW +a1kr5zwy/r4nqLfzUEZ1EzqdSuocYgj5+ZCz9XxN5Uo2a3Zl//6rEv8SXAhYEP35D0a xXKw== X-Gm-Message-State: AOAM533Ny86F4PGwD50CPV7Ra1jqplfd+4PDnIheWTSZn3478MVy1A+d 4koYmNjwlNCPNHHgGuDGuwYOmJIzf4yonywUrmJrzg== X-Google-Smtp-Source: ABdhPJy5FiyRxWb1/yg6+OenrVe7Jltn8hbV9VjG+MoGHrsui5ke3eBLjJR+w4cjHgORyzwDp0wmtCT4SrAgqQp2DHs= X-Received: by 2002:a63:1f21:: with SMTP id f33mr14505632pgf.31.1608543266172; Mon, 21 Dec 2020 01:34:26 -0800 (PST) MIME-Version: 1.0 References: <20201217121303.13386-1-songmuchun@bytedance.com> <20201217121303.13386-10-songmuchun@bytedance.com> <20201221080414.GA14343@linux> In-Reply-To: <20201221080414.GA14343@linux> From: Muchun Song Date: Mon, 21 Dec 2020 17:33:47 +0800 Message-ID: Subject: Re: [External] Re: [PATCH v10 09/11] mm/hugetlb: Introduce nr_free_vmemmap_pages in the struct hstate To: Oscar Salvador Cc: Jonathan Corbet , Mike Kravetz , Thomas Gleixner , mingo@redhat.com, bp@alien8.de, x86@kernel.org, hpa@zytor.com, dave.hansen@linux.intel.com, luto@kernel.org, Peter Zijlstra , viro@zeniv.linux.org.uk, Andrew Morton , paulmck@kernel.org, mchehab+huawei@kernel.org, pawan.kumar.gupta@linux.intel.com, Randy Dunlap , oneukum@suse.com, anshuman.khandual@arm.com, jroedel@suse.de, Mina Almasry , David Rientjes , Matthew Wilcox , Michal Hocko , "Song Bao Hua (Barry Song)" , David Hildenbrand , naoya.horiguchi@nec.com, Xiongchun duan , linux-doc@vger.kernel.org, LKML , Linux Memory Management List , linux-fsdevel Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Dec 21, 2020 at 4:17 PM Oscar Salvador wrote: > > On Thu, Dec 17, 2020 at 08:13:01PM +0800, Muchun Song wrote: > > @@ -182,6 +184,12 @@ bool hugetlb_free_vmemmap_enabled; > > > > static int __init early_hugetlb_free_vmemmap_param(char *buf) > > { > > + /* We cannot optimize if a "struct page" crosses page boundaries. */ > > + if ((!is_power_of_2(sizeof(struct page)))) { > > + pr_warn("cannot free vmemmap pages because \"struct page\" crosses page boundaries\n"); > > + return 0; > > + } > > Unless there is a strong reason behind, I would move this to the previous patch, > where early_hugetlb_free_vmemmap_param is introduced. OK. Will do. Thanks. > > -- > Oscar Salvador > SUSE L3 -- Yours, Muchun