From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36D9DC4320A for ; Thu, 29 Jul 2021 06:04:22 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C9E9E61052 for ; Thu, 29 Jul 2021 06:04:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C9E9E61052 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 5BCC26B006C; Thu, 29 Jul 2021 02:04:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 56D416B0070; Thu, 29 Jul 2021 02:04:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 45B408D0001; Thu, 29 Jul 2021 02:04:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0250.hostedemail.com [216.40.44.250]) by kanga.kvack.org (Postfix) with ESMTP id 3066B6B006C for ; Thu, 29 Jul 2021 02:04:21 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id D03DE18030140 for ; Thu, 29 Jul 2021 06:04:20 +0000 (UTC) X-FDA: 78414585480.01.536D474 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) by imf26.hostedemail.com (Postfix) with ESMTP id 3EF9F2016579 for ; Thu, 29 Jul 2021 06:04:19 +0000 (UTC) Received: by mail-pj1-f42.google.com with SMTP id g23-20020a17090a5797b02901765d605e14so7652522pji.5 for ; Wed, 28 Jul 2021 23:04:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=gqlOu5w7sIF9m7Ex8akMtGucE3AKmn8iiHCycTTM/xE=; b=ph5LVGOXWqyvIdu2y1OP4WXRoj1hjrxn2tMBtanm0fgVIqf/Ci5vZR+j5hFfnpT6l6 7pXTYJQm5/AgQ7wbdxQK9FLkQKfoo5kDHqsNp8v9VYzzNUfrjgsuV3SHqMsInWz1/Ehm 3brKiO0WsbndMAUkGXTuc3TBBBXR3zDBKfnF8qD8Pr0l/u7bKsUsUeDWNQJymO3GjFEj 9TKvtt9JJkeLrP3dePxuRwCmQj1rN9dTo1gEMzlQZBRilTrlg9MHO4Sz+wHXIHu6+3H8 TyKdyH7bxBfhvYUNHU9D0ZwTkBPNOUhzqqq8FDcdYdIwVXLQuIBCqNZOEH2F/8xTvfz4 JWTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gqlOu5w7sIF9m7Ex8akMtGucE3AKmn8iiHCycTTM/xE=; b=nuA+tTMookbepq2b0BL5HnXTCMncDFkaUIzasTkbDXxusgSpkO5AJghQG9lk7vx6a/ nMUv2ZUzZ2QpmHMu/vDdzbiePArQeHBFgdvwErwfl/KCR2LE4gJydMY0EIBtcBYt+xZ4 yg4Vhu9w/Gop42tDyAydm+bj7/uXtJPbm0mBWZksQhOvP+sHa3OBF9UTWY/A+0wkXDtH zlCtEdwZ1boTQ1+y+2WIadoPTYlEpO5q9+cSTpW7Va+S7Y/UELqgl2KFK4zKeBknXDGk KM6UOJAZcbAqaekocjbFTePyIpIi8QmwvZRy1chnN1WXp7ry+SJBh0dyRpJPFxzfvo2t aWFA== X-Gm-Message-State: AOAM531Pj/8a8xKI/gvE8mRbN2Ligp/Se8Vdbq1nNd+h3rSN2337VAOD aRTFIr7sbpgXUDGVT+lSB+94QunmN+P3tl+oflAR6w== X-Google-Smtp-Source: ABdhPJzDYXlUsa81+9TOdegbgF8dMAhSsTVDVOveJdyatsUa0SeIZyLEktiOkLl3eKARlGFPUGBpGpqw1eAxyKQ27MY= X-Received: by 2002:a17:90a:9b13:: with SMTP id f19mr3547754pjp.229.1627538658277; Wed, 28 Jul 2021 23:04:18 -0700 (PDT) MIME-Version: 1.0 References: <20210728145655.274476-1-wanghai38@huawei.com> In-Reply-To: <20210728145655.274476-1-wanghai38@huawei.com> From: Muchun Song Date: Thu, 29 Jul 2021 14:03:39 +0800 Message-ID: Subject: Re: [PATCH v2] mm/memcg: fix NULL pointer dereference in memcg_slab_free_hook() To: Wang Hai Cc: Christoph Lameter , Pekka Enberg , Roman Gushchin , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Johannes Weiner , Shakeel Butt , Alexei Starovoitov , Kefeng Wang , Linux Memory Management List , LKML Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=bytedance-com.20150623.gappssmtp.com header.s=20150623 header.b=ph5LVGOX; spf=pass (imf26.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.216.42 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com; dmarc=pass (policy=none) header.from=bytedance.com X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 3EF9F2016579 X-Stat-Signature: uwc9ydrsukqnsc6bacormzmucjw8pa7i X-HE-Tag: 1627538659-217487 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jul 28, 2021 at 10:57 PM Wang Hai wrote: > > When I use kfree_rcu() to free a large memory allocated by > kmalloc_node(), the following dump occurs. > > BUG: kernel NULL pointer dereference, address: 0000000000000020 > [...] > Oops: 0000 [#1] SMP > [...] > Workqueue: events kfree_rcu_work > RIP: 0010:__obj_to_index include/linux/slub_def.h:182 [inline] > RIP: 0010:obj_to_index include/linux/slub_def.h:191 [inline] > RIP: 0010:memcg_slab_free_hook+0x120/0x260 mm/slab.h:363 > [...] > Call Trace: > kmem_cache_free_bulk+0x58/0x630 mm/slub.c:3293 > kfree_bulk include/linux/slab.h:413 [inline] > kfree_rcu_work+0x1ab/0x200 kernel/rcu/tree.c:3300 > process_one_work+0x207/0x530 kernel/workqueue.c:2276 > worker_thread+0x320/0x610 kernel/workqueue.c:2422 > kthread+0x13d/0x160 kernel/kthread.c:313 > ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:294 > > When kmalloc_node() a large memory, page is allocated, not slab, > so when freeing memory via kfree_rcu(), this large memory should not > be used by memcg_slab_free_hook(), because memcg_slab_free_hook() is > is used for slab. > > Using page_objcgs_check() instead of page_objcgs() in > memcg_slab_free_hook() to fix this bug. > > Fixes: 270c6a71460e ("mm: memcontrol/slab: Use helpers to access slab page's memcg_data") > Signed-off-by: Wang Hai More simpler than v1. Thanks. Reviewed-by: Muchun Song