From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7807BC433F5 for ; Thu, 11 Nov 2021 13:10:05 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1DD4061208 for ; Thu, 11 Nov 2021 13:10:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1DD4061208 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 96A476B0072; Thu, 11 Nov 2021 08:10:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 918BD6B0075; Thu, 11 Nov 2021 08:10:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8084A6B0078; Thu, 11 Nov 2021 08:10:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0106.hostedemail.com [216.40.44.106]) by kanga.kvack.org (Postfix) with ESMTP id 6DBEE6B0072 for ; Thu, 11 Nov 2021 08:10:04 -0500 (EST) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 32199184E9AE6 for ; Thu, 11 Nov 2021 13:10:04 +0000 (UTC) X-FDA: 78796682328.04.72C8D4F Received: from mail-yb1-f181.google.com (mail-yb1-f181.google.com [209.85.219.181]) by imf13.hostedemail.com (Postfix) with ESMTP id 5BC7A104D43E for ; Thu, 11 Nov 2021 13:09:52 +0000 (UTC) Received: by mail-yb1-f181.google.com with SMTP id g17so14816777ybe.13 for ; Thu, 11 Nov 2021 05:10:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=nCiU1h64rx5pX1K0fkW1z/FMYz6g6Gjieb21yotPglY=; b=CvXVpr5HtggFlBdbWFqbVvGu/TcUumF+KeTkR8hV7DjVrNM0775Vxi+Xum808xoAxz sfGB8+5hOMf/CKv2/vfJloeHqG0sEU5WwPXelcbfbAVrWmX1YEq74DObf6zuqtvTRH6K rf+EWxk22SvYTa4oXaD34c13hX6QhzCJgIqekgMrX3ICMII2/t9NtrHihSBhHCieWEwN ib0/QUiIi3uf/mAFwbctjufNQavhX03KiSqMbSxVZpcjN2mLcs2eVB/kRiNKgGubOEPN W58ZdQ3s0TyXEocN5JkZ2Ta6QNzZ5mrobfCxavFvIKJcVgo0hY0BFF9RbF6W9AbKCxT5 kJzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nCiU1h64rx5pX1K0fkW1z/FMYz6g6Gjieb21yotPglY=; b=xM0/pJFnG7LkZOAHK2FbVG1ETCBa1b8migOO+Dh3Q1K3dm3SITb3hnhaF8iXxUdFuK FPk1I5ePi8T10y1MJ5gLr4kvgOYIW9wa4jrQICnz0jt4GTlMkv40Q8Mx40FPbRGrTWeL 5wpbZmpptJo8fcvtIeFG6GpoQhvHoAN3tTtQ7ufQBZu7rLEmW8ivfkmFWO5jn6WwTdKF mfFBw5px2UEEDHWxLs/RC2GYivHHeX5MB2fEv9cBZs+hU9IBttGNfKpiut+RD6JyNFNe mMKcFxshZ/zQAjC6p2PS7dP+7MA/xYInovq0qbTC4TPYbyLRlWXu333XKtvs5dIwWPdA 2VOA== X-Gm-Message-State: AOAM530b/3501PkUBHrYvLcmV0F5WIyLuvGNOjtSGvDUvs7AikklVMMa Oxx+Znte/wdiqGBGDsgMhYmz3s0nJwO2kDtyIumhvg== X-Google-Smtp-Source: ABdhPJxPCFMFVk/7fCxSyRoEBPf/Z5fAj/TAhaeD/NynAh9WVjJ18XDshk8Rqjz+IEP6VXUyVgq72pfA18fxAcythhc= X-Received: by 2002:a5b:648:: with SMTP id o8mr8630359ybq.208.1636636202993; Thu, 11 Nov 2021 05:10:02 -0800 (PST) MIME-Version: 1.0 References: <20211111084617.6746-1-ajaygargnsit@gmail.com> <6864f744-ca3e-f328-8793-2adb0146db03@bytedance.com> In-Reply-To: From: Muchun Song Date: Thu, 11 Nov 2021 21:09:22 +0800 Message-ID: Subject: Re: [PATCH] mm: shmem: do not call PageHWPoison on a ERR-page To: Ajay Garg Cc: Hugh Dickins , Andrew Morton , Linux Memory Management List , LKML Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=CvXVpr5H; spf=pass (imf13.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.219.181 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com; dmarc=pass (policy=none) header.from=bytedance.com X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 5BC7A104D43E X-Stat-Signature: pwcu8bmyh1dixhmkohde7noapap9iua1 X-HE-Tag: 1636636192-338539 X-Bogosity: Ham, tests=bogofilter, spamicity=0.225900, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Nov 11, 2021 at 8:21 PM Ajay Garg wrote: > > > > > What? I put "if (PageHWPoison(page))" into the else branch, > > it should be added braces since it's not 1-line blocks. > > Oh, ok. > > > Why do > > you think it does not address the issue? What am I missing > > here? > > That might work, however I haven't tested it. > > Upto the reviewers to see what they see as the best way going forward. I just suggest, it's up to you. > > > > Thanks and Regards, > Ajay