From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3471C433F5 for ; Mon, 24 Jan 2022 09:08:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 74CA86B0081; Mon, 24 Jan 2022 04:08:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6DE4A6B0083; Mon, 24 Jan 2022 04:08:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 59CB56B0085; Mon, 24 Jan 2022 04:08:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 47D356B0081 for ; Mon, 24 Jan 2022 04:08:16 -0500 (EST) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 06082181C49A1 for ; Mon, 24 Jan 2022 09:08:16 +0000 (UTC) X-FDA: 79064604192.30.ED6272E Received: from mail-yb1-f171.google.com (mail-yb1-f171.google.com [209.85.219.171]) by imf13.hostedemail.com (Postfix) with ESMTP id 1313220044 for ; Mon, 24 Jan 2022 09:08:14 +0000 (UTC) Received: by mail-yb1-f171.google.com with SMTP id g81so49011335ybg.10 for ; Mon, 24 Jan 2022 01:08:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Mo+uj8+53Ax7tIU91723WHax5XvtDO7oGefV09g/Eiw=; b=Lag6Tc/VjcamDe0m5xYuMi0i4GEJpQqzDv2xv15qjoOeqbVWxK+nR+z87z3/Uds7yJ xVMZsrEWXOp0quH66zVcVy5D9zyeeMNJ8MBFrQnj3VltAmEoKjttsv3dlG98dSbynjqk PFnaOxWJQVmTUr0iugE5+mXiRzDIDnlGpq+Atf0UWF/05kXEtP98JOBc8mLU8YHEPRFF F4B6lwfKhGX8rPNJo3AwlCueRsN7Pt4RrmA0biTfkV0Baij7u6nDkDnXHHN+LcrqhAqH CShC3LlIw2tHICgexcSbDwofHLOvSY3OXjtQdxIIJaw/jzgvcxhEH1G/dQIPzOMr2C70 ai4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Mo+uj8+53Ax7tIU91723WHax5XvtDO7oGefV09g/Eiw=; b=zkRVsECwNs+S10k8woYEIef+ZgUfzd4UGv6Ma1vc8+00U/jH5t5yPiY+QFCNGPAI2B 1EGieEanY8G3LQ3+NfOzANKQw/cOLKlHNu/TXyZEM+jzRJ6JyKXii8XKO+c3QT4JwuQr 38n1VTR4fxgIGbSrTtpR2te25tYcvmHDWhXN+lQzaHU9U5kSwrkoxznOxiWCwVgA0reU IAXJ7uwK+k1lz4QVnr5SfULVXiHAwz6b4F83ek9oGnO68hReDdIgN+u7OF6FnHZXdrHY sqxaskTnpD7tjsJVFs4pxTua498yh65aqGWOPmckWDWp+qFDgAwRnN94nZKlcqW4pFRT PAwA== X-Gm-Message-State: AOAM532XPeatGEsxvtAmZqmO7ZknrcZUGcXf0yZlbJSHSuNbI5lIVI+k sGl+pvYM7R28sJnMW/Oq5geNiVLqvWOYoF++22J9PQ== X-Google-Smtp-Source: ABdhPJxR2sNnK1U8ZMv0TLocVVFDh5rCZxvNsQJUvLgq5oQIsKgHQM/iDQMQSKuzKm7osYadMtzCvSPfXA2+9Ul2f20= X-Received: by 2002:a05:6902:100c:: with SMTP id w12mr6231737ybt.317.1643015294113; Mon, 24 Jan 2022 01:08:14 -0800 (PST) MIME-Version: 1.0 References: <20220121075515.79311-1-songmuchun@bytedance.com> <20220121075515.79311-4-songmuchun@bytedance.com> In-Reply-To: From: Muchun Song Date: Mon, 24 Jan 2022 17:07:38 +0800 Message-ID: Subject: Re: [PATCH 4/5] dax: fix missing writeprotect the pte entry To: Christoph Hellwig Cc: Dan Williams , Matthew Wilcox , Jan Kara , Alexander Viro , Andrew Morton , apopple@nvidia.com, Yang Shi , rcampbell@nvidia.com, Hugh Dickins , Xiyu Yang , "Kirill A. Shutemov" , zwisler@kernel.org, linux-fsdevel , nvdimm@lists.linux.dev, LKML , Linux Memory Management List Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 1313220044 X-Stat-Signature: 4n8uy1uzkidrffp69jhsabptt7kgcsrx Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b="Lag6Tc/V"; spf=pass (imf13.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.219.171 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com; dmarc=pass (policy=none) header.from=bytedance.com X-Rspamd-Server: rspam01 X-HE-Tag: 1643015294-868724 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jan 24, 2022 at 3:41 PM Christoph Hellwig wrote: > > On Fri, Jan 21, 2022 at 03:55:14PM +0800, Muchun Song wrote: > > Reuse some infrastructure of page_mkclean_one() to let DAX can handle > > similar case to fix this issue. > > Can you split out some of the infrastructure changes into proper > well-documented preparation patches? Will do. I'll introduce page_vma_mkclean_one in a prepared patch and then fix the DAX issue in a separate patch. Thanks for your suggestions. > > > + pgoff_t pgoff_end = pgoff_start + npfn - 1; > > > > i_mmap_lock_read(mapping); > > - vma_interval_tree_foreach(vma, &mapping->i_mmap, index, index) { > > - struct mmu_notifier_range range; > > - unsigned long address; > > - > > + vma_interval_tree_foreach(vma, &mapping->i_mmap, pgoff_start, pgoff_end) { > > Please avoid the overly long lines here. Just using start and end > might be an easy option. > Will do. Thanks.