From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D846C433EF for ; Mon, 24 Jan 2022 08:51:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EDA2B6B0081; Mon, 24 Jan 2022 03:51:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E61AF6B0085; Mon, 24 Jan 2022 03:51:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D027D6B0087; Mon, 24 Jan 2022 03:51:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0117.hostedemail.com [216.40.44.117]) by kanga.kvack.org (Postfix) with ESMTP id C2E0D6B0081 for ; Mon, 24 Jan 2022 03:51:44 -0500 (EST) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 836558E2CA for ; Mon, 24 Jan 2022 08:51:44 +0000 (UTC) X-FDA: 79064562528.25.5B4295C Received: from mail-yb1-f181.google.com (mail-yb1-f181.google.com [209.85.219.181]) by imf22.hostedemail.com (Postfix) with ESMTP id 4DEAEC003F for ; Mon, 24 Jan 2022 08:51:43 +0000 (UTC) Received: by mail-yb1-f181.google.com with SMTP id g14so48817234ybs.8 for ; Mon, 24 Jan 2022 00:51:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=bELfTHEk6E+Ur1KnM4vcunvX6YMOTiYgaY+wBXhSmNY=; b=xuzHORiZtxL4ALsbPI12Enqz7+Y7z0qaEw1VTD5rZOAhs136D3XcklFmacDAPP1Wix b1LezGAI1F3NQTCI3w2mzRPC+MN6bdvFBSfGz1dtd48u5S8myG1WDGav+YscfQrYNIyT bW4EIysGkBOF3+/+evUyYiHTyjBobHidSnKY3XRHsRzfufOk2nJE7LOgO/bNLOnPqckC K2NOq5CLsd2a53530xwZVi/LbOfFyuiMm7xB/ASE2pT2LN7016uNyqlOtbNmhXhU6GUt ztNByXTKi0m1souZOOtIvo7KOv/wq5MzYC8eEGDxp0xOL5QolSsngo80rWPP/ZmLnKM1 fFLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=bELfTHEk6E+Ur1KnM4vcunvX6YMOTiYgaY+wBXhSmNY=; b=kWQmPstKSoMQIOxDNfZ3qAv3wQx3nDWErpZ5gbRwUcuBcJ1uSfgnlIt5+e+pfHa7CE iJyYuak8gOFsyxcHLpY1ZzuC8NS4LVzEclqufRF8I9Ngp3BMCpO+89YCnmJCTDnf7NIp Jw59boaAG4wAPihLuiQURbVnfT+6cPAGTtl8LIo/a1U354IwrTF1sSizjxajNPtY/jnE 096+2ZngFNmL5KDywWylHHwlLrqNMC7On1HwbOfuPzNTPlte+j5hUUxDMCBuUHOohcsF dRpjCp942j+IEIVayY0dxM8luTgRYR4ewL+Od7BNixiHqfsA/G5lCL2yvVFSTtpQZs8O PwAg== X-Gm-Message-State: AOAM530FlHkuKIfKvVCQ9z0YicSd90mkal8icdwSvsH7OQi5xmS78/u9 V5Xem7tF8Cfza4j5SjKb6/iyyPmNgEDRpRTrUfn1Gw== X-Google-Smtp-Source: ABdhPJw1vSctPW8saHhj1FGspU/fxdcO6t1LvGwNO4aTt6W6d1v0JCyqb15ZQrKh1+6SniqvhSjPXoVXuqbGSbR4L3Y= X-Received: by 2002:a25:d107:: with SMTP id i7mr20792477ybg.495.1643014302301; Mon, 24 Jan 2022 00:51:42 -0800 (PST) MIME-Version: 1.0 References: <20220121075515.79311-1-songmuchun@bytedance.com> In-Reply-To: From: Muchun Song Date: Mon, 24 Jan 2022 16:51:06 +0800 Message-ID: Subject: Re: [PATCH 1/5] mm: rmap: fix cache flush on THP pages To: Christoph Hellwig Cc: Dan Williams , Matthew Wilcox , Jan Kara , Alexander Viro , Andrew Morton , apopple@nvidia.com, Yang Shi , rcampbell@nvidia.com, Hugh Dickins , Xiyu Yang , "Kirill A. Shutemov" , zwisler@kernel.org, linux-fsdevel , nvdimm@lists.linux.dev, LKML , Linux Memory Management List Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 4DEAEC003F X-Stat-Signature: q5ne36hpmj7spptib1snqhozconwtox9 Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=xuzHORiZ; dmarc=pass (policy=none) header.from=bytedance.com; spf=pass (imf22.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.219.181 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com X-HE-Tag: 1643014303-935465 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jan 24, 2022 at 3:34 PM Christoph Hellwig wrote: > > On Fri, Jan 21, 2022 at 03:55:11PM +0800, Muchun Song wrote: > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/mm/rmap.c b/mm/rmap.c > > index b0fd9dc19eba..65670cb805d6 100644 > > --- a/mm/rmap.c > > +++ b/mm/rmap.c > > @@ -974,7 +974,7 @@ static bool page_mkclean_one(struct page *page, struct vm_area_struct *vma, > > if (!pmd_dirty(*pmd) && !pmd_write(*pmd)) > > continue; > > > > - flush_cache_page(vma, address, page_to_pfn(page)); > > + flush_cache_range(vma, address, address + HPAGE_PMD_SIZE); > > Do we need a flush_cache_folio here given that we must be dealing with > what effectively is a folio here? I think it is a future improvement. I suspect it will be easy if someone wants to backport this patch. If we do not want someone to do this, I think it is better to introduce flush_cache_folio in this patch. What do you think? > > Also please avoid the overly long line. > OK. Thanks.