From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80246C433EF for ; Sat, 4 Jun 2022 02:49:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 666D28D0002; Fri, 3 Jun 2022 22:49:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5EF608D0001; Fri, 3 Jun 2022 22:49:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 48DA58D0002; Fri, 3 Jun 2022 22:49:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 34F198D0001 for ; Fri, 3 Jun 2022 22:49:35 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 0BBFD208A3 for ; Sat, 4 Jun 2022 02:49:35 +0000 (UTC) X-FDA: 79539022710.01.8787A99 Received: from mail-yb1-f180.google.com (mail-yb1-f180.google.com [209.85.219.180]) by imf17.hostedemail.com (Postfix) with ESMTP id 9A9AD40002 for ; Sat, 4 Jun 2022 02:48:55 +0000 (UTC) Received: by mail-yb1-f180.google.com with SMTP id p13so16787321ybm.1 for ; Fri, 03 Jun 2022 19:49:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dFgPJ0EvCireqTk1NG3fa4MqyQXhNKCWoxAx0OX5uXM=; b=8Up1FSkJCiVMlo1FEPFESU3WDGO72wv6qWRe11rdwvRC9vTdo1Gk3pDAk4rFZ9okjl 22j5WkGOCNktK7zB9SPGsugkZ3cvgu4b4Il+LNMSSe1zDG/qBA/9v8tmudSHtL//OgiN 8FgjtJAqux1NWUVE1V1HG7iSqts6cqhwFS5fggSqa+cgv8VKziRbTufEJW7PXUUfmplZ 92GS54lBjo10Q6a+WPKWjuMMiHepsO0mjFalEFxWg9f/8IeKptyRqv30MynWJkd8unqe zGF/QbRrNQx+GvB/gQDIiA7zPS2m9B9lrn/FrF5hDBGANdfdmBGsn2wz5ZiQN49xnAPj gREA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dFgPJ0EvCireqTk1NG3fa4MqyQXhNKCWoxAx0OX5uXM=; b=RZm6YoRS1S2VyU0T6xuadrAMlUm5/xVugzexRZeIo/uRDOx+klbNbZzjys5ruxx5v5 dwhdE6RXuuCx7BLRCxUVtJ/eou/sZSk98arKhE4u522v8IDjlstOru1aNUA4X5dAqL86 B8qUDLZYbgLV1bahF4tWPW0cjpMBa5E9R1N6Fe6uR4vcF/kqkdSQy6cUqv68pCQyCT+A 269nrfJZDAIIRoxYAU2CI0RUKtDyJMqxEnDrIMWruXIR1v71M329jwKQ7HRCO1vhmHDs Vy0V43Gxh7a7rvH7V3cb6uKWET47C5D0izcalHpFooIZ7kJjqRVx5XFDsaRA2rhhx3Ya 6Xng== X-Gm-Message-State: AOAM532tybx7Tr8KKcYi0rP4GKogiKgakY0cG1/NrRc9FpaWP2yAbgb+ FvqQNybIObLH612gZNTy5S02lkEw/yB1I64ouoNtZA== X-Google-Smtp-Source: ABdhPJzlLpBQmq1Y4Obciqm0T5t6gUS5s0GUXNsC0U2JhwJt5+dKNnXEmlY34Se+DMgyRJe/dsDi8WR22+ZOVYCER8s= X-Received: by 2002:a25:cc53:0:b0:65c:b19c:fac1 with SMTP id l80-20020a25cc53000000b0065cb19cfac1mr13512196ybf.89.1654310972408; Fri, 03 Jun 2022 19:49:32 -0700 (PDT) MIME-Version: 1.0 References: <20220603070423.10025-1-zhengqi.arch@bytedance.com> In-Reply-To: <20220603070423.10025-1-zhengqi.arch@bytedance.com> From: Muchun Song Date: Sat, 4 Jun 2022 10:48:56 +0800 Message-ID: Subject: Re: [PATCH] mm: memcontrol: separate {pgscan,pgsteal}_{kswapd,direct} items in memory.stat of cgroup v2 To: Qi Zheng Cc: Michal Hocko , Johannes Weiner , Roman Gushchin , Shakeel Butt , Andrew Morton , Jonathan Corbet , Linux Memory Management List , LKML , Linux Doc Mailing List Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 9A9AD40002 X-Stat-Signature: 3cj1wbhr3i5rn4tfcqioywswufjfhxgx X-Rspam-User: Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=8Up1FSkJ; spf=pass (imf17.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.219.180 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com; dmarc=pass (policy=none) header.from=bytedance.com X-Rspamd-Server: rspam08 X-HE-Tag: 1654310935-218670 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jun 3, 2022 at 3:06 PM Qi Zheng wrote: > > There are already statistics of {pgscan,pgsteal}_kswapd and > {pgscan,pgsteal}_direct of memcg event here, but now the sum > of the two is displayed in memory.stat of cgroup v2. > > In order to obtain more accurate information during monitoring > and debugging, and to align with the display in /proc/vmstat, > it better to display {pgscan,pgsteal}_kswapd and > {pgscan,pgsteal}_direct separately. > > Moreover, after this modification, all memcg events can be > printed with a combination of vm_event_name() and memcg_events(). > This allows us to create an array to traverse and print, which > reduces redundant seq_buf_printf() codes. > > Signed-off-by: Qi Zheng With Shakeel's changes. Acked-by: Muchun Song