From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDEEFC433ED for ; Sat, 10 Apr 2021 04:34:06 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 35ACB61182 for ; Sat, 10 Apr 2021 04:34:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 35ACB61182 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9CA396B006C; Sat, 10 Apr 2021 00:34:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 97A936B006E; Sat, 10 Apr 2021 00:34:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 81A926B0070; Sat, 10 Apr 2021 00:34:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0168.hostedemail.com [216.40.44.168]) by kanga.kvack.org (Postfix) with ESMTP id 62DB96B006C for ; Sat, 10 Apr 2021 00:34:05 -0400 (EDT) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 07CD418034A62 for ; Sat, 10 Apr 2021 04:34:05 +0000 (UTC) X-FDA: 78015190050.13.78BA6C6 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) by imf24.hostedemail.com (Postfix) with ESMTP id E6F40A0000FD for ; Sat, 10 Apr 2021 04:33:58 +0000 (UTC) Received: by mail-pj1-f48.google.com with SMTP id b8-20020a17090a5508b029014d0fbe9b64so5937088pji.5 for ; Fri, 09 Apr 2021 21:34:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=FW1Qa2Pww1tEjlyfwRyqPFS3bdetO5szAzOdgn/LNKs=; b=cPT5KTO9NK/LC19lH63RuMviNJtAyfY2N86QrNDR6sKsVMNLfz4RWwozZ6wBTf1uc0 PRrrhpXOE0i2ImCkMGKX9VoGtfJZs5F32WcMM3Y4TDwY67/S6Mqxs+TmYV2UnND8Hmj2 cHU9x5fbtVUfMpMfZWUN29VV9o0EQi3Yy+iSd7g3e7rm0c3/3agO37V2z5PiOOyt5Ddo IRnmSsbCMtvsOdmdVs7gQf9XHa1wtA2j6rOQ8X7h1NsocjgF0R6MphRgx9oE9XMBW9J+ AUYGMF6wjdrD0dJGWf6Rc2faxdRoYmXDr0Tvv/g2C4uCBbskRZE8IuEcB2x4SlUl74iI oblg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FW1Qa2Pww1tEjlyfwRyqPFS3bdetO5szAzOdgn/LNKs=; b=r5hnMNHBnvKDZSkYtHpx1WPFanjhAIP7Te4jScQIYUGcRnAwCY2mw0YpxDVxcaYLXS cIzTCDLc7DmyyIKYFp1j63ATMVQPaBNHIB3AJp6JTLwCleUT9Jy/hVcEL5/Qw/eyY/wk uFPWiyU4vmDp8gLKdCwKxO8dJrLGQvB7bdJC3d090Ulsho8urD7yzS3CK/nGCasAU4ps LKXtWc/lxZ6kSXqTim0glS54gL6HFKSYwg0VyBdPpfUOjyPKLDxHVI+75Y7Ghm7HT47W vE6frssCs9PCUALje+eymfM4YlupKFf7UWoO6JCQB2qRLx0ZqYwVPb3HIn2tBNgiOJ0f qVpg== X-Gm-Message-State: AOAM531Q7vJ/m57pmvZk9HbftJELqMocRP9u/nFvDvbM4BqxXwFsCUbI vEv7JfW2wcinu14M8GuSH6K8Uz4LP6b4JzpYIcDUdA== X-Google-Smtp-Source: ABdhPJxZhzgitiiSg64+M/hoJTMFSjRogSq/t3z8Bht8t1xPnJcWBgx28PAULBfXXSYhJbGHyiLHH4BDecMclMAyCjY= X-Received: by 2002:a17:902:8308:b029:e9:d69:a2f with SMTP id bd8-20020a1709028308b02900e90d690a2fmr15961107plb.20.1618029242417; Fri, 09 Apr 2021 21:34:02 -0700 (PDT) MIME-Version: 1.0 References: <20210409122959.82264-1-songmuchun@bytedance.com> <20210409122959.82264-10-songmuchun@bytedance.com> In-Reply-To: From: Muchun Song Date: Sat, 10 Apr 2021 12:33:26 +0800 Message-ID: Subject: Re: [External] Re: [RFC PATCH v2 09/18] mm: vmscan: remove noinline_for_stack To: Johannes Weiner Cc: guro@fb.com, mhocko@kernel.org, akpm@linux-foundation.org, shakeelb@google.com, vdavydov.dev@gmail.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, duanxiongchun@bytedance.com, fam.zheng@bytedance.com, bsingharora@gmail.com, shy828301@gmail.com, alex.shi@linux.alibaba.com Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: E6F40A0000FD X-Stat-Signature: mxjoyyrhknodfeh77metb5bfmjikwg3e X-Rspamd-Server: rspam02 Received-SPF: none (bytedance.com>: No applicable sender policy available) receiver=imf24; identity=mailfrom; envelope-from=""; helo=mail-pj1-f48.google.com; client-ip=209.85.216.48 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1618029238-63702 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Apr 10, 2021 at 2:31 AM Johannes Weiner wrote: > > On Fri, Apr 09, 2021 at 08:29:50PM +0800, Muchun Song wrote: > > The noinline_for_stack is introduced by commit 666356297ec4 ("vmscan: > > set up pagevec as late as possible in shrink_inactive_list()"), its > > purpose is to delay the allocation of pagevec as late as possible to > > save stack memory. But the commit 2bcf88796381 ("mm: take pagevecs off > > reclaim stack") replace pagevecs by lists of pages_to_free. So we do > > not need noinline_for_stack, just remove it (let the compiler decide > > whether to inline). > > > > Signed-off-by: Muchun Song > > Good catch. > > Acked-by: Johannes Weiner > > Since this patch is somewhat independent of the rest of the series, > you may want to put it in the very beginning, or even submit it > separately, to keep the main series as compact as possible. Reviewers > can be more hesitant to get involved with larger series ;) OK. I will gather all the cleanup patches into a separate series. Thanks for your suggestion.