From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F07EEC433EF for ; Tue, 25 Jan 2022 14:26:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7A3C46B007D; Tue, 25 Jan 2022 09:26:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7555F6B0080; Tue, 25 Jan 2022 09:26:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 61C386B0081; Tue, 25 Jan 2022 09:26:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0076.hostedemail.com [216.40.44.76]) by kanga.kvack.org (Postfix) with ESMTP id 550CB6B007D for ; Tue, 25 Jan 2022 09:26:45 -0500 (EST) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 1E9949093B for ; Tue, 25 Jan 2022 14:26:45 +0000 (UTC) X-FDA: 79069035570.24.AB6BE0B Received: from mail-yb1-f172.google.com (mail-yb1-f172.google.com [209.85.219.172]) by imf12.hostedemail.com (Postfix) with ESMTP id 0E5B84000E for ; Tue, 25 Jan 2022 14:26:43 +0000 (UTC) Received: by mail-yb1-f172.google.com with SMTP id p5so62098911ybd.13 for ; Tue, 25 Jan 2022 06:26:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wl6G1I8d7amrdxFUYe5VdZlTB2njtWsoXMFyPet+gSM=; b=AGW72ryFUV7dVhvx7fItSQe6ZZHiMtTV5Da/c6LbG0unTjI5NleXJ6OdX+dcMAo3XP Egpc2Ui/iAx/cdbFGKKIggUeC7r+FbsAeu6d9h+vTDvb25dE8nqSP7ccD+/WTQdWj0+s 9aMo3rC131UNWFHlxKUd5aZ62wkqORyZpgNvACVVaLR4Mumpf7Qm438DHuTrBqP9jpCm /Ft8pdlHTjs9Qq/e2gNrC2s7q43TXwOr/RCgSdSyWjsqC6Ezc2J/L1jjSNPDh7F1RRgB kCh2H1qKG+GhLqK22qGSxvtGlAjTFmh+zZb8yyte+M1KeTy4OO71L38j3uGr51G9usH7 sqPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wl6G1I8d7amrdxFUYe5VdZlTB2njtWsoXMFyPet+gSM=; b=fNnyeuiV32J4wIG3OflQV0Q6yOgafNxOHKaC5UYyNl3Z1bA92eIdwHOIJEC4aDkUgu tf26HsD68zhlQyOwsltOZRaHkbbDVft7S9SAeEKv8KRxIpd7HQbvoXcI70jD3F+6soOj 0UyfvSy9h75U4d+sh8NfmnqNhCkvbnsadBy6dAn9yRpTGcLryp7qJdUADzWw2hwn55zG llFa5zsM7krdkTFHP3krL/klsH6VNV3vuTIM18zksEbJ2oVp0SJLFRlgMkSPsQe/pNzf 2x1GTaX6DJSnZvbJPjM9z5crJkvI1k61vPmzXhW/JqXOqwNg+Yl9taIfOQq2tSao/FsP f2ow== X-Gm-Message-State: AOAM530P1BXp90vF/vYDEH601JRWrrP3CTtW3n16h76+PPgT1hcavOmy jh75aR3z2mYkCo38JfneuB/ZAJsTWHxUrKZExL1HBg== X-Google-Smtp-Source: ABdhPJyFvo0J2ACdgGip0xhojHQiB4Fhvy8CYFKQFGItnOFG8EzOF30f7xwY1X3oEdihcoOJrEv5uvnaovhwTDuhnyE= X-Received: by 2002:a25:af4b:: with SMTP id c11mr29461798ybj.49.1643120803495; Tue, 25 Jan 2022 06:26:43 -0800 (PST) MIME-Version: 1.0 References: <20220125132221.2220-1-linmiaohe@huawei.com> In-Reply-To: <20220125132221.2220-1-linmiaohe@huawei.com> From: Muchun Song Date: Tue, 25 Jan 2022 22:26:07 +0800 Message-ID: Subject: Re: [PATCH] mm/balloon_compaction: make balloon page compaction callbacks static To: Miaohe Lin Cc: Andrew Morton , "Michael S. Tsirkin" , David Hildenbrand , virtualization@lists.linux-foundation.org, Linux Memory Management List , LKML Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 0E5B84000E X-Stat-Signature: eyjoc8qwuw3u9esdydtazremf1rm34xi X-Rspam-User: nil Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=AGW72ryF; spf=pass (imf12.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.219.172 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com; dmarc=pass (policy=none) header.from=bytedance.com X-HE-Tag: 1643120803-745889 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jan 25, 2022 at 9:29 PM Miaohe Lin wrote: > > Since commit b1123ea6d3b3 ("mm: balloon: use general non-lru movable page > feature"), these functions are called via balloon_aops callbacks. They're > not called directly outside this file. So make them static and clean up > the relevant code. > > Signed-off-by: Miaohe Lin Reviewed-by: Muchun Song