From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6EC0C433DB for ; Thu, 4 Mar 2021 05:51:05 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 84DBC64EFE for ; Thu, 4 Mar 2021 05:51:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 84DBC64EFE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B02A96B0005; Thu, 4 Mar 2021 00:51:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AB3B96B0006; Thu, 4 Mar 2021 00:51:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9531A6B0007; Thu, 4 Mar 2021 00:51:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0143.hostedemail.com [216.40.44.143]) by kanga.kvack.org (Postfix) with ESMTP id 792826B0005 for ; Thu, 4 Mar 2021 00:51:04 -0500 (EST) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 27905180F68D4 for ; Thu, 4 Mar 2021 05:51:04 +0000 (UTC) X-FDA: 77881118448.11.0DF8BB6 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) by imf07.hostedemail.com (Postfix) with ESMTP id 3D319A0009E2 for ; Thu, 4 Mar 2021 05:51:02 +0000 (UTC) Received: by mail-pj1-f48.google.com with SMTP id o6so6086327pjf.5 for ; Wed, 03 Mar 2021 21:51:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=PHh6MdEXNUKZrwB9uZw23/DqWC2TOmpTX2HUQ2q/364=; b=HxQdXk52IXdtRkHu1/R6yxMuIjlbC3nn+FxxvSbrxxeQkNtjI5EB0s2Fhv3TvjIpKT qGGTY/1RU0C+gG/bxx0ujod2ciyhPCkICtGZyWHQPhKopE/dlptNwaZ1b2/Q7UAuHnX2 iCAdy9e7isLGXsJkHM7IL/+azvhPqg2dfhBTjDaduRklCTQ7/unUXVmDiLRP3yk6r4Ju uuy0+YvACY5utD8X1Up2mqX16SoGsBssE2YlD5+QEma2aVgClTi/XC5/Rh3roeTObTTW n6QlOv0fHJDhqUvh2ihs9fgHCllPXss2OIdHe2a6gTtXCOA/19tjxqG0GnYd9VvlNzT4 LQXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PHh6MdEXNUKZrwB9uZw23/DqWC2TOmpTX2HUQ2q/364=; b=lH/aSk97mNGOxoxhq3Tmqv1XaWQ05dwXoVBC6aCLbijYmkha/YULnNogYfGE6pYQ0C Zql2+/jda1EmpevgmCovX2pJPZqnmgEFaaQ4tqfjcqhr7dXkDe1DCXphhAEAjSOkJEMR DlibacU9bvY7u2caJGNQ3cWeDc5cAh2R++gGiUo0jTd2id3oqXjoIruKp1V/pR/Z41ov +eHN5KfCLwvwThkqgHtbpoIU5KlAUx5cDR3BL6gzleu7jky2EsbbYrWNlDkLbpcPMVPQ JGJSH8ZFhoXo4qYxo+5r7D428JjnLUfwwjPe/ZZrEuQ4RUGMEAdDWJxogEuUVUru7rqu raNg== X-Gm-Message-State: AOAM5300G6FJetkv5rYHMa2zM5/3le9MvmbDg6iObn1n/2slqtkd16PQ GDM/KLRp2uom7aRDPSU1TG1UOWChhIco47i4Y6wR1w== X-Google-Smtp-Source: ABdhPJyRe1Ska4Dpb+winDsksPNhnJKDFerdQjWU0fCZIDmkpQO4lSqg3V4NY2A8paKorMfdEXogGQht1yFEAQ+TICg= X-Received: by 2002:a17:90a:778a:: with SMTP id v10mr2679820pjk.229.1614837061472; Wed, 03 Mar 2021 21:51:01 -0800 (PST) MIME-Version: 1.0 References: <20210225132130.26451-1-songmuchun@bytedance.com> <20210225132130.26451-2-songmuchun@bytedance.com> <20210304042617.GB1223287@balbir-desktop> In-Reply-To: <20210304042617.GB1223287@balbir-desktop> From: Muchun Song Date: Thu, 4 Mar 2021 13:50:23 +0800 Message-ID: Subject: Re: [External] Re: [PATCH v17 1/9] mm: memory_hotplug: factor out bootmem core functions to bootmem_info.c To: Balbir Singh Cc: Jonathan Corbet , Mike Kravetz , Thomas Gleixner , Ingo Molnar , bp@alien8.de, x86@kernel.org, hpa@zytor.com, dave.hansen@linux.intel.com, luto@kernel.org, Peter Zijlstra , Alexander Viro , Andrew Morton , paulmck@kernel.org, mchehab+huawei@kernel.org, pawan.kumar.gupta@linux.intel.com, Randy Dunlap , oneukum@suse.com, anshuman.khandual@arm.com, jroedel@suse.de, Mina Almasry , David Rientjes , Matthew Wilcox , Oscar Salvador , Michal Hocko , "Song Bao Hua (Barry Song)" , David Hildenbrand , =?UTF-8?B?SE9SSUdVQ0hJIE5BT1lBKOWggOWPoyDnm7TkuZ8p?= , Joao Martins , Xiongchun duan , linux-doc@vger.kernel.org, LKML , Linux Memory Management List , linux-fsdevel , Miaohe Lin Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: 8zoxd8ekxwyqwdtb4ru5jd3bxxh8xn94 X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 3D319A0009E2 Received-SPF: none (bytedance.com>: No applicable sender policy available) receiver=imf07; identity=mailfrom; envelope-from=""; helo=mail-pj1-f48.google.com; client-ip=209.85.216.48 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1614837062-803013 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Mar 4, 2021 at 12:26 PM Balbir Singh wrote: > > On Wed, Mar 03, 2021 at 01:45:00PM +1100, Singh, Balbir wrote: > > On 26/2/21 12:21 am, Muchun Song wrote: > > > Move bootmem info registration common API to individual bootmem_info.c. > > > And we will use {get,put}_page_bootmem() to initialize the page for the > > > vmemmap pages or free the vmemmap pages to buddy in the later patch. > > > So move them out of CONFIG_MEMORY_HOTPLUG_SPARSE. This is just code > > > movement without any functional change. > > > > > > Signed-off-by: Muchun Song > > > Acked-by: Mike Kravetz > > > Reviewed-by: Oscar Salvador > > > Reviewed-by: David Hildenbrand > > > Reviewed-by: Miaohe Lin > > ... > > > > > diff --git a/mm/bootmem_info.c b/mm/bootmem_info.c > > > new file mode 100644 > > > index 000000000000..fcab5a3f8cc0 > > > --- /dev/null > > > +++ b/mm/bootmem_info.c > > > @@ -0,0 +1,124 @@ > > > +// SPDX-License-Identifier: GPL-2.0 > > > +/* > > > + * linux/mm/bootmem_info.c > > > + * > > > + * Copyright (C) > > > > Looks like incomplete > > > Not that my comment was, I should have said > > The copyright looks very incomplete Yes. Just copied from mm/memory_hotplug.c. I can improve it in the next version. Thanks. > > Balbir Singh.