From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3392DC433EF for ; Thu, 16 Dec 2021 09:45:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C13A36B0071; Thu, 16 Dec 2021 04:45:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BC3936B0073; Thu, 16 Dec 2021 04:45:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AB2006B0074; Thu, 16 Dec 2021 04:45:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0192.hostedemail.com [216.40.44.192]) by kanga.kvack.org (Postfix) with ESMTP id 9FA746B0071 for ; Thu, 16 Dec 2021 04:45:26 -0500 (EST) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 4D4538249980 for ; Thu, 16 Dec 2021 09:45:16 +0000 (UTC) X-FDA: 78923174232.07.281DC15 Received: from mail-yb1-f178.google.com (mail-yb1-f178.google.com [209.85.219.178]) by imf23.hostedemail.com (Postfix) with ESMTP id 06A8E140011 for ; Thu, 16 Dec 2021 09:45:10 +0000 (UTC) Received: by mail-yb1-f178.google.com with SMTP id f186so63035860ybg.2 for ; Thu, 16 Dec 2021 01:45:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=A1MFole7nFko6XzmDNfgE5E+/1W8AedAM5ImSr4t3Mo=; b=nsmQ/apsKdQztyc0yc5tiUuptN+9XlsBEAr0qz+gI5SZ+IV3uSUUFj52fE9YbQVI8n SMbjtHrTJA6hukMVpoe9h0y6Rmfyrl+OHG/iOHic+VH5G02tOBfDdwGMpC7FfUrBGTu3 8XpRGgzs7x86Dl8C0S2EHzI480i8bV0jQS8+RviV1BOSx6kp/P/aMy3Hx325lxQFnmHw X0cG1oWo6GktwZFd78AaZBgbbhnACTQenYXojWdQRhiJtzNFPn30D0eC0JI1ooH1p6wQ p1NWPJE7pjmTIGoCX0RY9/cuWQjZRO11Ex/D2pnSThLbuR6dO5PA2wjt+xORpiYjw6W8 bveg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=A1MFole7nFko6XzmDNfgE5E+/1W8AedAM5ImSr4t3Mo=; b=fMbjIPWLm6mMlrlOza02K0VGsot+ImeJ5pZExMrjE3VX0PZEVymqvYl3YLL3F2q4BH S9l6/uai51+pBVsvzh2ICY19EZQQODNzmlWZABCSGScNrdMWiewf8CNxOv98CCuUBHzo hqnFl3LtWy5meBKbZoXnGeRiZA9DfqhG/fDCSQKqqjAxTvXbaAYuKzER88pARFQy6aUA XHYM7HpSn04cvapMO13yxzMh8CmYzKacb74Rafuy6LRAm3GbT8kj0SG5qAKYbqx2ZLgN 3bj0Yqme6tIuKIf5eOtMt4nHjLEbWKuzTIGTRbIyMhteXa1/jK1n1xQphgfxHdVMBkeZ jckA== X-Gm-Message-State: AOAM531Pww7kJTaOI6/HE7TjXom4VEeYli+mM0cpuDiNhiydFs2rdbci a4JS8gRQXmp1J2cWvLOp7R0RMfLXoYmScB2nqUhRmg== X-Google-Smtp-Source: ABdhPJytpY6IKx476YQCSWtivg98+adXT5ZH0jbr+l9j/D8Pt8zWvBRmB8J/jyRv6XgbIY/CqxeyMFRbwZaiwwEiQw8= X-Received: by 2002:a25:9c81:: with SMTP id y1mr12149005ybo.49.1639647914325; Thu, 16 Dec 2021 01:45:14 -0800 (PST) MIME-Version: 1.0 References: <20211216022024.127375-1-wangweiyang2@huawei.com> In-Reply-To: <20211216022024.127375-1-wangweiyang2@huawei.com> From: Muchun Song Date: Thu, 16 Dec 2021 17:44:38 +0800 Message-ID: Subject: Re: [PATCH -next] mm/memcg: Use struct_size() helper in kzalloc() To: Wang Weiyang Cc: Johannes Weiner , Michal Hocko , Vladimir Davydov , Andrew Morton , Cgroups , Linux Memory Management List , LKML Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 06A8E140011 X-Stat-Signature: 85sxhxnhjh3cqdequcwzpmcgwwdgw8dy Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b="nsmQ/aps"; dmarc=pass (policy=none) header.from=bytedance.com; spf=pass (imf23.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.219.178 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com X-Rspamd-Server: rspam11 X-HE-Tag: 1639647910-597275 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Dec 16, 2021 at 10:21 AM Wang Weiyang wrote: > > Make use of the struct_size() helper instead of an open-coded version, in > order to avoid any potential type mistakes or integer overflows that, in > the worst scenario, could lead to heap overflows. > > Link: https://github.com/KSPP/linux/issues/160 > Signed-off-by: Wang Weiyang Reviewed-by: Muchun Song