From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72F8BC433E0 for ; Wed, 23 Dec 2020 02:48:40 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0FF7A2256F for ; Wed, 23 Dec 2020 02:48:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0FF7A2256F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3F2E78D0010; Tue, 22 Dec 2020 21:48:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 37BA08D0009; Tue, 22 Dec 2020 21:48:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 26AA88D0010; Tue, 22 Dec 2020 21:48:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0174.hostedemail.com [216.40.44.174]) by kanga.kvack.org (Postfix) with ESMTP id 0FA838D0009 for ; Tue, 22 Dec 2020 21:48:39 -0500 (EST) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id CE428181AEF1D for ; Wed, 23 Dec 2020 02:48:38 +0000 (UTC) X-FDA: 77623013916.01.stop80_5c1082f27465 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin01.hostedemail.com (Postfix) with ESMTP id AD97C10046460 for ; Wed, 23 Dec 2020 02:48:38 +0000 (UTC) X-HE-Tag: stop80_5c1082f27465 X-Filterd-Recvd-Size: 5848 Received: from mail-pg1-f175.google.com (mail-pg1-f175.google.com [209.85.215.175]) by imf43.hostedemail.com (Postfix) with ESMTP for ; Wed, 23 Dec 2020 02:48:37 +0000 (UTC) Received: by mail-pg1-f175.google.com with SMTP id n25so4164313pgb.0 for ; Tue, 22 Dec 2020 18:48:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wP7Uq2lowyz2FH8P5+5koRz57WTCSgXorU4PTle7rdo=; b=bI+yNYRnrvlvKm0GFWJ0h8Zo4CX+ntNyT8egYkggS18UBmlB5Ej5FmqGO/cmC3a6io rjiGb4MIW9QvltzrZxdJDzjP+HmGGr5CTERjUc21VMF44i38G1LMaWQLTgrM96CfxFn7 OHEBz4+sDNwo1WVSAhW+l3nQjVStyrz8JeZdfW5gSfDdodXi7/SWiyuWPdb+Y4OdrSY0 qrE5QZFwaicGQDZ3c3tyX5pIzN+bjhBHG7uGbox0Hr6tS7uoZZsNklQGcEz9jqgvjR9z 5dkVJSklQB4IqZEVi5p0kBVeJaOfBJh5fgfsaUpmA25RoNGn4WfFbNliDSRu8yCgpVOt hNzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wP7Uq2lowyz2FH8P5+5koRz57WTCSgXorU4PTle7rdo=; b=DOanqdSprZszYJ6bsyRkboRQB4n0TK0H2eGP0KSnVOkN1vE1jU+NKLmgb5FjRrcaXX fRDRjQXNvzrf26raeZaeJm+2qxIEisTJU/ncm/q8w/tM1CJRtMDu/oDZ1GTZHej3+zFU YjRE0+e3mowcuPV5dP9tHIeCPWM3oN7W9niOqv8oJDE24dVs2Lc4IiLGeC0ueeXwlPt/ VHH8gzWNuxKz/pWD7jGFLA7S+mw53kpH3p1nmJrWyQ0JL32C8X0+mtQUudi7hG75nPRg zWrumldhm1s4HyLs4rBLkMzrXJfgI/zUU75V3/JNANSq1bNBeWYW+mD1EcyeGh9JTSkq 4i4A== X-Gm-Message-State: AOAM530/Q4YF6GW6grYdfRFztOVJ7GQYXxnrKE5qr9fjhzodqXuH9PE+ DAOpKoMw5LHecDm8saI+c+XyaQFyIzjM6XtAXqU/Og== X-Google-Smtp-Source: ABdhPJyZhq4UXodKoW1yonKLx7SJbDUeopHTSj9WphsfAsFA9xHEfINldXo3tXZS2SFAgF7o8OQRmc7gOerPeZ7KwJo= X-Received: by 2002:a63:480f:: with SMTP id v15mr9021169pga.341.1608691717231; Tue, 22 Dec 2020 18:48:37 -0800 (PST) MIME-Version: 1.0 References: <20201222142440.28930-1-songmuchun@bytedance.com> <20201222142440.28930-4-songmuchun@bytedance.com> <20201222163248.GB31385@linux> In-Reply-To: <20201222163248.GB31385@linux> From: Muchun Song Date: Wed, 23 Dec 2020 10:47:59 +0800 Message-ID: Subject: Re: [External] Re: [PATCH v11 03/11] mm/hugetlb: Free the vmemmap pages associated with each HugeTLB page To: Oscar Salvador Cc: Jonathan Corbet , Mike Kravetz , Thomas Gleixner , mingo@redhat.com, bp@alien8.de, x86@kernel.org, hpa@zytor.com, dave.hansen@linux.intel.com, luto@kernel.org, Peter Zijlstra , viro@zeniv.linux.org.uk, Andrew Morton , paulmck@kernel.org, mchehab+huawei@kernel.org, pawan.kumar.gupta@linux.intel.com, Randy Dunlap , oneukum@suse.com, anshuman.khandual@arm.com, jroedel@suse.de, Mina Almasry , David Rientjes , Matthew Wilcox , Michal Hocko , "Song Bao Hua (Barry Song)" , David Hildenbrand , naoya.horiguchi@nec.com, Xiongchun duan , linux-doc@vger.kernel.org, LKML , Linux Memory Management List , linux-fsdevel Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Dec 23, 2020 at 12:32 AM Oscar Salvador wrote: > > On Tue, Dec 22, 2020 at 10:24:32PM +0800, Muchun Song wrote: > > diff --git a/include/linux/mmdebug.h b/include/linux/mmdebug.h > > index 5d0767cb424a..eff5b13a6945 100644 > > --- a/include/linux/mmdebug.h > > +++ b/include/linux/mmdebug.h > > @@ -37,6 +37,13 @@ void dump_mm(const struct mm_struct *mm); > > BUG(); \ > > } \ > > } while (0) > > +#define VM_WARN_ON_PAGE(cond, page) \ > > + do { \ > > + if (unlikely(cond)) { \ > > + dump_page(page, "VM_WARN_ON_PAGE(" __stringify(cond)")");\ > > + WARN_ON(1); \ > > + } \ > > + } while (0) > > #define VM_WARN_ON_ONCE_PAGE(cond, page) ({ \ > > static bool __section(".data.once") __warned; \ > > int __ret_warn_once = !!(cond); \ > > @@ -60,6 +67,7 @@ void dump_mm(const struct mm_struct *mm); > > #define VM_BUG_ON_MM(cond, mm) VM_BUG_ON(cond) > > #define VM_WARN_ON(cond) BUILD_BUG_ON_INVALID(cond) > > #define VM_WARN_ON_ONCE(cond) BUILD_BUG_ON_INVALID(cond) > > +#define VM_WARN_ON_PAGE(cond, page) BUILD_BUG_ON_INVALID(cond) > > #define VM_WARN_ON_ONCE_PAGE(cond, page) BUILD_BUG_ON_INVALID(cond) > > #define VM_WARN_ONCE(cond, format...) BUILD_BUG_ON_INVALID(cond) > > #define VM_WARN(cond, format...) BUILD_BUG_ON_INVALID(cond) > > Take this off this patch and make it a preparation patch prior to this one. > A new VM_WARN_ON_ macro does not make much sense in this patch as it is > not related. OK. Will do in the next version. Thanks. > > I will have a look later today at the other changes, but so far looks good. > > -- > Oscar Salvador > SUSE L3 -- Yours, Muchun