* [PATCH] mm/page_alloc: fix indentation for VM_WARN_ONCE
@ 2026-03-27 3:00 Junyao Zhao
2026-03-27 3:19 ` Andrew Morton
0 siblings, 1 reply; 2+ messages in thread
From: Junyao Zhao @ 2026-03-27 3:00 UTC (permalink / raw)
To: akpm; +Cc: vbabka, linux-mm, Junyao Zhao
From d7442d455218ffff67f890bb39d273d7555bed1c Mon Sep 17 00:00:00 2001
From: Junyao Zhao <junzhao@redhat.com>
Date: Thu, 26 Mar 2026 04:58:14 -0400
Subject: [PATCH] mm/page_alloc: fix indentation for VM_WARN_ONCE
Replace leading spaces with a tab to follow kernel coding style.
Reported by checkpatch.pl
Signed-off-by: Junyao Zhao <junzhao@redhat.com>
---
mm/page_alloc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 2d4b6f1a554e..d2e04ecddb8b 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -884,7 +884,7 @@ static inline void
__del_page_from_free_list(struct page *page, struct zone *zon
{
int nr_pages = 1 << order;
- VM_WARN_ONCE(get_pageblock_migratetype(page) != migratetype,
+ VM_WARN_ONCE(get_pageblock_migratetype(page) != migratetype,
"page type is %d, passed migratetype is %d (nr=%d)\n",
get_pageblock_migratetype(page), migratetype, nr_pages);
--
2.52.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] mm/page_alloc: fix indentation for VM_WARN_ONCE
2026-03-27 3:00 [PATCH] mm/page_alloc: fix indentation for VM_WARN_ONCE Junyao Zhao
@ 2026-03-27 3:19 ` Andrew Morton
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Morton @ 2026-03-27 3:19 UTC (permalink / raw)
To: Junyao Zhao; +Cc: vbabka, linux-mm
On Fri, 27 Mar 2026 11:00:19 +0800 Junyao Zhao <junzhao@redhat.com> wrote:
> >From d7442d455218ffff67f890bb39d273d7555bed1c Mon Sep 17 00:00:00 2001
> From: Junyao Zhao <junzhao@redhat.com>
> Date: Thu, 26 Mar 2026 04:58:14 -0400
> Subject: [PATCH] mm/page_alloc: fix indentation for VM_WARN_ONCE
>
> Replace leading spaces with a tab to follow kernel coding style.
>
> Reported by checkpatch.pl
Thanks.
This is rather too minor to add, sorry. If it was modifying a whoops
which was added in the current development tree then OK.
Also, the current development tree's __del_page_from_free_list() looks
nothing like yours, so maybe you're developing against an older kernel?
And your email suffers wordwrapping and tabs-to-spaces issues. Please
fix that email client configuration next time.
> Signed-off-by: Junyao Zhao <junzhao@redhat.com>
> ---
> mm/page_alloc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index 2d4b6f1a554e..d2e04ecddb8b 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -884,7 +884,7 @@ static inline void
> __del_page_from_free_list(struct page *page, struct zone *zon
> {
> int nr_pages = 1 << order;
>
> - VM_WARN_ONCE(get_pageblock_migratetype(page) != migratetype,
> + VM_WARN_ONCE(get_pageblock_migratetype(page) != migratetype,
> "page type is %d, passed migratetype is %d (nr=%d)\n",
> get_pageblock_migratetype(page), migratetype, nr_pages);
>
> --
> 2.52.0
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-03-27 3:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-03-27 3:00 [PATCH] mm/page_alloc: fix indentation for VM_WARN_ONCE Junyao Zhao
2026-03-27 3:19 ` Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox