From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E5C3CF07C6 for ; Thu, 10 Oct 2024 08:42:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 556EF6B0085; Thu, 10 Oct 2024 04:42:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 506886B0088; Thu, 10 Oct 2024 04:42:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3CE6E6B0089; Thu, 10 Oct 2024 04:42:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 1C5676B0085 for ; Thu, 10 Oct 2024 04:42:09 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id A88581403FE for ; Thu, 10 Oct 2024 08:42:05 +0000 (UTC) X-FDA: 82657050336.01.9389FC1 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf25.hostedemail.com (Postfix) with ESMTP id 282D1A0004 for ; Thu, 10 Oct 2024 08:42:06 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Li5ZbZBB; spf=pass (imf25.hostedemail.com: domain of mcasquer@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=mcasquer@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728549589; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GM7DtQIpf+fPOvpsz2AGui1W1Ru1wkTcj4wDWnyHCaI=; b=rJR7aW+CvfmNZao34rTqr7nDHvmYxnUwPT4ahnj8gafhO5cTfJ5UjV3tMvGahb48P3XUQv gv0Yq1EKDM1ts3U3RYNzs4LfO721VymMFECG5ct35G/UFOvttnNHDviJ4G2/8v+QohH5jV iCAN9Ojo5AG1jC7NWVVRlBWy6zkdLUo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728549589; a=rsa-sha256; cv=none; b=WOh49Ap9leOZ8Sci2oSweTjqglTA6Sh7ls0OMBXVxv8IREl81K6fqxA+qqbpKO3UNM3g3m LKcnLlQbGMFKrr/NsRxUwJImpEFswEkQwHGYHdMvzRHLD6/olKjLc1+SsSSs1ZPjrXC1mH 8K/YEJnAkenzzByDmx/f/XIwGWznuFc= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Li5ZbZBB; spf=pass (imf25.hostedemail.com: domain of mcasquer@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=mcasquer@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1728549725; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GM7DtQIpf+fPOvpsz2AGui1W1Ru1wkTcj4wDWnyHCaI=; b=Li5ZbZBBHgqbt+DdtMuqMVhMj4Lj62rF7c+JBIfzxohcKIoHPZ8cTqBLxTsOU0cEVqWa5x kqxQi7utjDvXY5ZQU8ujV2iQjZmSMZQOM/SyJ9NmbmU3K51+OrpQ7RlpKiDo3XSqn4Gja3 p9UC3VKq17bQ33zz8DJ888bsnVSDkdc= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-29-wkeCXqK7PpSs8nto75YYDQ-1; Thu, 10 Oct 2024 04:42:04 -0400 X-MC-Unique: wkeCXqK7PpSs8nto75YYDQ-1 Received: by mail-lj1-f198.google.com with SMTP id 38308e7fff4ca-2fac931e7c6so4865761fa.3 for ; Thu, 10 Oct 2024 01:42:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728549723; x=1729154523; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GM7DtQIpf+fPOvpsz2AGui1W1Ru1wkTcj4wDWnyHCaI=; b=e3Iaay1uAqQ0PBomhjyKDyrrqUY40N8s4KAwf+4rEecRCI55YZ20S3r5dCphQT5nKi ty//EoOP7kJSDfnOMgAkbomNtMCoXfTM/PmVbSBqJ6gItR9sqTp0pKxK5JBHV9sdSE4h 6ABUdjWnRL8uSsgJLzT/PGQUUT28CwnBv78Q16m6bWND2tnpQ4bcdKvK7gLt1Dzze540 UPpUNEXCD5NuoqoJOIJGHv9CG/DGMLNXaKju+jFP5CemkEqhTpgI5KVr2fChhbY7uZ8Q Ps1U2xhdLYE818whgI6m8Jvn/Y97urAFCwP+kfi4GDDCHgLgdZO7pPkKLbxaSOB6N2iV TzkA== X-Forwarded-Encrypted: i=1; AJvYcCWcpLtpB8kJ86lXuFmJTf4nP9152Rv3JAd/zxvgJti/x2DQh28y9L0VOLRTVf5GjL0IIfrP3PWP1w==@kvack.org X-Gm-Message-State: AOJu0YxgQxoemk+cfkoFbtDZop86KPGBZh5p/1KfdXgszqA4byGrOPTc zOpEimzmFPf3zI9fZedQFm4rxKmJW2lrNtdkRiWCZheWxJ+od5WJQf97E7pAz43BX6OF0fAMVrO ShJkDwtNWZSnp9/shjz+3ZJF2Zg0p8BQj+OJwzhu8CuxC6f7rh07SWJMEAx6OqBKrXaFGnw1+Qz tQRvwRlsMQibOzSIvCrq7EEJA= X-Received: by 2002:a2e:be2c:0:b0:2f7:a759:72a7 with SMTP id 38308e7fff4ca-2fb1873820emr39055931fa.22.1728549722683; Thu, 10 Oct 2024 01:42:02 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEtDPN01aoKhTb0Kx+hTbPzL0rIoqv3Q28dszjZ82sAqbT3YhpguNTUPjIwiNx0SHdAeK1nHIy6O5dnWKuZ35A= X-Received: by 2002:a2e:be2c:0:b0:2f7:a759:72a7 with SMTP id 38308e7fff4ca-2fb1873820emr39055571fa.22.1728549722212; Thu, 10 Oct 2024 01:42:02 -0700 (PDT) MIME-Version: 1.0 References: <20240910191541.2179655-1-david@redhat.com> In-Reply-To: <20240910191541.2179655-1-david@redhat.com> From: Mario Casquero Date: Thu, 10 Oct 2024 10:41:51 +0200 Message-ID: Subject: Re: [PATCH v1 0/5] virtio-mem: s390x support To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-s390@vger.kernel.org, virtualization@lists.linux.dev, Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Thomas Huth , Cornelia Huck , Janosch Frank , Claudio Imbrenda , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , =?UTF-8?Q?Eugenio_P=C3=A9rez?= , Andrew Morton X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 282D1A0004 X-Stat-Signature: yps514b7erg5ggdyyxcu1osw18kud8p6 X-HE-Tag: 1728549726-386910 X-HE-Meta: U2FsdGVkX18+clhmmce0D4v32GMBgHGPXuIyu+/0wH20EI/NP58fN46gjpkFyX8q0cgWg3GrYAqM7hKWaXWLKKX2S4TtidTeyVBRU5dJJb0XQKyaiKHMsDUPmWV08Ud6lQA89zuFZuzuIQynqntScsG24d3eLD78Havxl1CtIhng8Uf1bfIuaI+IanCSXCnYAvTppGcXt0eggIYM2gevS+KST0gEhqBGGj33Xn0huXP5zpPseqejxiTv1/js0FS+QxKkclMKxD6Tb166raFW3C2XoVBu9eSv+SYWwfbTwAkYxzay6R4ISMxsVw3jfryF6daBFpvhIZkJ3nMV2Lxtp7kIz7L3tgKbri2A3iKNQqXdjLfKyIicTQrO7wa7hBqbFAFH6p3kLwrJYS+2ry7tgA11L49WLNJJ3NgIBscdUFboamblTNKvttAGoBc8uCdpN+CJsYg2Y1+VsIeCq6TPx8JQ238g4GVuofl6RNYJDugGIrmgx92W6ZZScK89tEt81vt6RBCwBv3o1EkVKTNhFX95CclndkTwjEAcAE28wW1vMzDJh0NKF4jKpAvt84XRiNgdq1ZQonyXb7A7bvuouxzqg1973OVFyVHzaIHcs32lgvStpFkz3j/c10jxd1q712kLMRzCiL0qnBUkZWWi3gMaafA07QMCTfcteT+iDQoLoC3o8Ioj8XBc14gFY+9ZeKl+E6zt+MsnqmSAs7oVh/TUeK4jNMuKxGhQerSnDdyWl8csdaOuYKGaa37ASRmX+6lm6ydR24vcycg+IO8Xyrb1JmjXQrwiX099PnXVXtYU2KANgbc2k8SSFXY5lAP44ucOGzz2A1C7QIsIH/2ZbOahRtN15mpvpq7yB2tGVAADD8D4DcwyVOmwpEKm1Sel00s4gpWwkvtioPjHG/y4GaNbohWaB5YROtWDco+4gOwe+xbkFP/MTiKrXWUB5qdvwkx0VQEnR+Mwa5bLw5i nXXACHQ4 cTwmxbbCXaL0mI4vhHFmjSX2FByzjcHD1H8KrthAApNRH2O/ccB5eC4Z6OvJCnKxTTQ9Lqe+2N1LbfhYrk/O4KhQGrOPJUbTaYWu8pKkCinKheH76skuoseo+XE0mflDFspSTXMcrgyxf10OHWjoMoXTpzsN13ivLB8LDv8jtuA0be1eJX6+EH0cYtoaoLkMHbqrpupvcpvBvXfKt88uiR7D49GorhoEpWI+n+i533JO275Vo7WbrEA42W5bvjj77+V3NCXes0vtUV0fe2IsZnaorDNRpC0EO6kwLrV3KsEGjvos5aBkT3iS7OJwH+v2Pmk0hSWrnADCVy4wxG5qtFWkawfGDdY15Rqx1BAuWWN9qJItANO3rdMwxYPe9oR47IXi0W7udwNTfyupgkUJGedUErCT5pzb9/xygh/vn/DchkiW9jwLJOCce0ib7k7WA8ZtTmvqNUK17F+M0flzKQ0esBB70Rpxqz9H8ChtM1so9RM0WUCyaHByq1vg8YPzWCO8j X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: This series has been successfully tested along with the QEMU's series. Virtio-mem devices could be resized, plugged and unplugged seamlessly. The memory information displayed is correct and reboot doesn't cause any issue. Tested-by: Mario Casquero On Tue, Sep 10, 2024 at 9:16=E2=80=AFPM David Hildenbrand wrote: > > Let's finally add s390x support for virtio-mem; my last RFC was sent > 4 years ago, and a lot changed in the meantime. > > This is based on mm/stable. > > I sent out the QEMU part earlier today [1], that contains some more detai= ls > and a usage example on s390x (last patch). > > There is not too much in here: The biggest part is querying a new diag(50= 0) > STORAGE_LIMIT hypercall to obtain the proper "max_physmem_end". Once this > and the QEMU part will go upstream, it will get documented in [2] > > The last two patches are not strictly required but certainly nice-to-have= . > > Note that -- in contrast to standby memory -- virtio-mem memory must be > configured to be automatically onlined as soon as hotplugged. The easiest > approach is using the "memhp_default_state=3D" kernel parameter or by usi= ng > proper udev rules. More details can be found at [3]. > > I have reviving+upstreaming a systemd service to handle configuring > that on my todo list, but for some reason I keep getting distracted ... > > I tested various things, including: > * Various memory hotplug/hotunplug combinations > * Device hotplug/hotunplug > * /proc/iomem output > * reboot > * kexec > * kdump: make sure we don't hotplug memory > > One remaining work item is kdump support for virtio-mem memory. I > am working on a prototype that will be fairly straight forward, > because the virtio-mem driver already supports a special kdump mode and > dracut will already include it in the initrd as default. With > holiday and conferences coming up I rather sent this out now. > > [1] https://lkml.kernel.org/r/20240910175809.2135596-1-david@redhat.com > [2] https://gitlab.com/davidhildenbrand/s390x-os-virt-spec > [3] https://virtio-mem.gitlab.io/user-guide/user-guide-linux.html > > Cc: Heiko Carstens > Cc: Vasily Gorbik > Cc: Alexander Gordeev > Cc: Christian Borntraeger > Cc: Sven Schnelle > Cc: Thomas Huth > Cc: Cornelia Huck > Cc: Janosch Frank > Cc: Claudio Imbrenda > Cc: "Michael S. Tsirkin" > Cc: Jason Wang > Cc: Xuan Zhuo > Cc: "Eugenio P=C3=A9rez" > Cc: Andrew Morton > > David Hildenbrand (5): > s390/kdump: implement is_kdump_kernel() > s390/physmem_info: query diag500(STORAGE_LIMIT) to support QEMU/KVM > memory devices > virtio-mem: s390x support > lib/Kconfig.debug: default STRICT_DEVMEM to "y" on s390x > s390/sparsemem: reduce section size to 128 MiB > > arch/s390/boot/physmem_info.c | 46 ++++++++++++++++++++++++++-- > arch/s390/include/asm/kexec.h | 4 +++ > arch/s390/include/asm/physmem_info.h | 3 ++ > arch/s390/include/asm/sparsemem.h | 2 +- > arch/s390/kernel/crash_dump.c | 6 ++++ > drivers/virtio/Kconfig | 12 ++++---- > lib/Kconfig.debug | 2 +- > 7 files changed, 64 insertions(+), 11 deletions(-) > > -- > 2.46.0 > >