From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95B4DC001DB for ; Sat, 5 Aug 2023 16:06:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7D9EC8D0002; Sat, 5 Aug 2023 12:06:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 78B2D8D0001; Sat, 5 Aug 2023 12:06:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6517B8D0002; Sat, 5 Aug 2023 12:06:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 5652E8D0001 for ; Sat, 5 Aug 2023 12:06:43 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 21F4AA099A for ; Sat, 5 Aug 2023 16:06:43 +0000 (UTC) X-FDA: 81090529086.26.3E6CB17 Received: from mail-yb1-f170.google.com (mail-yb1-f170.google.com [209.85.219.170]) by imf11.hostedemail.com (Postfix) with ESMTP id 57C2B4002F for ; Sat, 5 Aug 2023 16:06:41 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=w8Aj8qAs; dmarc=pass (policy=none) header.from=linaro.org; spf=pass (imf11.hostedemail.com: domain of yongqin.liu@linaro.org designates 209.85.219.170 as permitted sender) smtp.mailfrom=yongqin.liu@linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691251601; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LUC7hGh6qWIThNH4Y7Zx7/EPitpQqojAFQsIWWs+CoI=; b=qW1M1mkk5knWgsGZByBmAe5+BZrXDYjKMaBBfQWuKQn9ZJyn//oBED+BvV6SVxwujjG0bN iemCEXPSxGT9u1AHiw66eI8beP6e30mgQHFCW/F9PpvQXTORqhbmJiW11xFCgOsey93IZK lDeSGnD+cHL1yMJxMJ++X5Bs6JFpLB8= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=w8Aj8qAs; dmarc=pass (policy=none) header.from=linaro.org; spf=pass (imf11.hostedemail.com: domain of yongqin.liu@linaro.org designates 209.85.219.170 as permitted sender) smtp.mailfrom=yongqin.liu@linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691251601; a=rsa-sha256; cv=none; b=aFcJbPLKngBCXyYMdmTBCps2HjTeKSIA7pp8nCNeJOmot8ElcFX29DwogsNqBAANECapu8 DHNeId7PwdcK3j1ne+COiprKH2ZG0eFfJgTuYqRRv6mV8fOT3GjEoOkNR2TMM7+DJFuYhD Qvv1jLyk9QU/fjBL4lFxqsxM242oYn4= Received: by mail-yb1-f170.google.com with SMTP id 3f1490d57ef6-cfcebc33d04so3169570276.2 for ; Sat, 05 Aug 2023 09:06:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1691251600; x=1691856400; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=LUC7hGh6qWIThNH4Y7Zx7/EPitpQqojAFQsIWWs+CoI=; b=w8Aj8qAsosbRzUMt2ECW46TyqC0Gdyvyl+8r7lBeqF0ua8QQKCBE5E1zQGJ2FqqVrY IWxJiR+PHr3TYG9C2wIzVQX0vTC/dTQIMFLSzMhCC4fc2iu4z+KOYx4q/EAt+r2VYcsQ ljmEuYDM/aEp8ZaC3Ipn5VD4XvHWZnnmo7V4EVd3zKBxQmzVwNwbOLRTfsWf9eWLvgYJ acklIdGosROzxvEoOgMaFLt02K60UXl2jNnD4Y1nKC4Pm8qYNJP57MpPfVMS4RAcceH5 CI1f/w7lAC5yfC49EUEm34IrwYx9pkrJ/W1wn29U0E+XXkryfH22U94PYoY0ASg7qzDx Tu2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691251600; x=1691856400; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=LUC7hGh6qWIThNH4Y7Zx7/EPitpQqojAFQsIWWs+CoI=; b=KmxU4Jc7275TSAtXm1N9ld1iFczsdUjjMWNERw1HOw8hOKJWqdcOiSxrOTB2KzIjPQ 9w3P11pGJGWqXYACkS1fmAOmtEN1ETi3dlkoM8Cttx0GgI5D07f0217hnGbgjdbwT3D4 BgipqWhCwWnooSZ7C21PynIBtY/WEKQ5kZ3KK03PspesW0fcCWACHtUuI3riVMyQq/kb TU8QNSv7bprapvzU2IgYMPEInP6Ky9NzCUUDQq9iEIyuvwf53PvbwN3kj39j3xps0P+D /U5uPQYGqQ7I7EUl1NbEFh6Vg1l4pUNdRlusBpFUk3xYLLyEjozFv9KfRN/gdtgdvFUf Trmg== X-Gm-Message-State: AOJu0YwEcbzdxr54dpsiMBq3pOnSejhFrw4iVKC8KQofn+e+VL29yaEV 96FkYDZkWsPIx4t0tDRgXalvaznEjC3Rv9nr1El8bg== X-Google-Smtp-Source: AGHT+IEXUM4q2tosVwitR5AuzqfGOAsWLX3RMlI0jzEdL0gZFzU0pYbDkEpMbjYQX87lDwP1ZwDc2PpSdxAmkmBsMCQ= X-Received: by 2002:a05:6902:392:b0:d07:87b0:f2a8 with SMTP id f18-20020a056902039200b00d0787b0f2a8mr4271442ybs.21.1691251600297; Sat, 05 Aug 2023 09:06:40 -0700 (PDT) MIME-Version: 1.0 References: <2929bfd-9893-a374-e463-4c3127ff9b9d@google.com> In-Reply-To: From: Yongqin Liu Date: Sun, 6 Aug 2023 00:06:28 +0800 Message-ID: Subject: Re: [PATCH v2 04/32] mm/pgtable: allow pte_offset_map[_lock]() to fail To: Hugh Dickins Cc: Matthew Wilcox , Andrew Morton , Mike Kravetz , Mike Rapoport , "Kirill A. Shutemov" , David Hildenbrand , Suren Baghdasaryan , Qi Zheng , Yang Shi , Mel Gorman , Peter Xu , Peter Zijlstra , Will Deacon , Yu Zhao , Alistair Popple , Ralph Campbell , Ira Weiny , Steven Price , SeongJae Park , Lorenzo Stoakes , Huang Ying , Naoya Horiguchi , Christophe Leroy , Zack Rusin , Jason Gunthorpe , Axel Rasmussen , Anshuman Khandual , Pasha Tatashin , Miaohe Lin , Minchan Kim , Christoph Hellwig , Song Liu , Thomas Hellstrom , Ryan Roberts , linux-kernel@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Stat-Signature: s88d7zz188wtttzydrqekmr1ie8myy7p X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 57C2B4002F X-HE-Tag: 1691251601-367560 X-HE-Meta: U2FsdGVkX1+qcAcvU8eoIibRiuJPv/F8WKZkCouNu6k646tIPSShCZWDZBTj1LlvZC/4ZsmBIkOr2uNpJa60oeiWFW7kE6dwHqi1fpZRCNoY8fJtRG98PlK/7PvL6bhJXcj6G4IdcjYJVS+3+w7E7a8rFpgNiqEs2NX38LgDA4rALVlJL8ecLMnEeNXWj3CkKyf1yKQ4cDDC8Ks9WC6uaprV5mHNUQ7IUZ3R0tvp9BkOHMElJCLbi+ER7UBuT8qdt24/7HWG6t3UNbM8Ngz0JO554W15vBLF8GLhidio11NWI8vn3Vh2d/g/821GT65vm6mLNULTVZzuWy25HGtRVhzyk5CGsK48ff9UthHPHP3/w8uzrl18bws1obJEGjIFVCyp10xJH2ddS8hXNhG3ZOsjrgfPGMUNc7QZwLifXrE/2yz8t4tZhR+rov7Omnm+XqhDu8AW11UbApCJ6TnLYZjnn76eTO7St5ICi52EDRgp1AtXP+Z+WlM/FzpQ6MbHpFIbt0DwJv9VnETN5GsXXkfN9Oxwzilwx2DMX/ifJx6IP4fM50Ftr7266Vx27BGoPIZYTOO6LBInT5GQVRRPbXtTQio1/puidhQHD3nJgz7EqN4wBawHD1hWFhCnJUAyW77A03/0qJs1HGoit+XNxWh80h0YrCCK4YWAyCN712WZNZE1z82zejyVsuMdMvet5H4j8A6gVfk9HJKXka1LwF4AFY+PIjUC5pLDptOBT0dNAB5jzefOecfEW7u8p9P3wLdXapV3GsrKJC0iZJlSU1/hQzZxlm5Uj/H9sLTg5D53DrxJ0f9KSyfJDNAvaHm8W3SouftLFmHrWl7ofvcATYh6GOBNHsjcZMBixKc9oj5ISNtw8a1BNTa0dsI8jdYsUJJZUi0cl69iinwog/GO1YYyR5vWLrpls5nZMtKj0vXI9c1PqWqSrbBQTNvWXsJKOavKn3JCmCpKXFPl+Em 0TSCp96z N3kNeaKy7rZZAaLtmTNBV0g9D5CNWpSmbo4Ewy7y75P/hpAb56j2gbeJ6ugKpN4BoC3OsJKz5rJR5tpy5X9CNUS/KUKbTaJwUJ5yE7fZc9xLj/qcvjSQBPLdSS8QCS0vVBkh9bkz0Cr0dlMuU3tgoE1wbZvHylPzoDduPV1JtMuziFOKgMWEX31S4j6t3azsonk7nanYoTLm8Sb13x2LsXxbW6j8gjP/VmBhlmzv2ZeNpg8/kOMMFdmw8KzGq47U1DNPwXeakTLpwQ3vfTT1rSMvjtbprM3Q4fhtDev9c6dI6pISZYxgvmCdlL8pq5udydEjk9jkaTL4bLh47P6PmJfNK6JJIS3qPSc5N X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, 29 Jul 2023 at 00:58, Hugh Dickins wrote: > > On Fri, 28 Jul 2023, Matthew Wilcox wrote: > > On Fri, Jul 28, 2023 at 09:53:29PM +0800, Yongqin Liu wrote: > > > Hi, Hugh > > > > > > It seems this change makes pte_offset_map_lock not possible to be > > > called in out of tree modules, > > > otherwise it will report error like this: > > > ERROR: modpost: "__pte_offset_map_lock" > > > [../omap-modules/android-mainline/pvr/pvrsrvkm.ko] undefined! > > > > > > Not sure if you have any idea about it, and any suggestions on how to > > > resolve it? > > > > Please explain why this module needs to map page tables > > +1 Sorry, I am not able to give any explanation here, I am not familiar with the pvrsrvkm source, I just use it to have one working AOSP build. here is the source file where pte_offset_map_lock is called, https://android-git.linaro.org/kernel/omap-modules.git/tree/pvr/services4/srvkm/env/linux/osfunc.c?h=android-mainline#n3508 in case you could know something with a quick look. Otherwise, it has to wait for another one to report the problem again. > Thank you for testing 6.5-rc, and I am sorry to have inconvenienced you. > > But there is not one example of an in-tree module needing that, > which is a very strong hint that no module should be needing that. > > Sounds like pvrsrvkm.ko wants to muck around with page table entries, > without the core mm knowing. Not something core mm can encourage! > > If what pvrsrvkm.ko is aiming to do there would be useful for others, > maybe its owner can share that, and work with core mm developers to > expose a generally useful interface - but that is not likely to be > __pte_offset_map_lock itself. > Thanks for the explanation! Let's see if any other pvrsrvkm engineer or other out of tree modules could help give some explanations on this case or similar cases. Thanks, Yongqin Liu -- Best Regards, Yongqin Liu --------------------------------------------------------------- #mailing list linaro-android@lists.linaro.org http://lists.linaro.org/mailman/listinfo/linaro-android