From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 996F4CA0ECA for ; Tue, 12 Sep 2023 11:26:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EF4596B00DC; Tue, 12 Sep 2023 07:26:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EA3FA6B00DD; Tue, 12 Sep 2023 07:26:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D92F76B00DE; Tue, 12 Sep 2023 07:26:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id CADA86B00DC for ; Tue, 12 Sep 2023 07:26:18 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 95F501CAAC7 for ; Tue, 12 Sep 2023 11:26:18 +0000 (UTC) X-FDA: 81227716836.03.17CF138 Received: from mail-vs1-f46.google.com (mail-vs1-f46.google.com [209.85.217.46]) by imf27.hostedemail.com (Postfix) with ESMTP id DD2414002D for ; Tue, 12 Sep 2023 11:26:16 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=bgdev-pl.20230601.gappssmtp.com header.s=20230601 header.b=ZCckGzRZ; spf=none (imf27.hostedemail.com: domain of brgl@bgdev.pl has no SPF policy when checking 209.85.217.46) smtp.mailfrom=brgl@bgdev.pl; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694517976; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dNmJanv/prkqq1jS6J4qAr7QRHlkbDKkqj7yolXDYiE=; b=TgoTYeOJ7f8syxUrFmM7EkU9UGHXYAHc89k5HK03cju86QXOpBqHSrH6Rsvmi12BNnwJTd dwXFfjLoA8EYqqJcEU5mkVRXCk3wyOip+HLE6tExJHQMVoYKCV0nITEWlAw1kcbUdiwVXN /496df9YOsj+soqGnHSic2E8+syTqRw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694517976; a=rsa-sha256; cv=none; b=p6vsaSlBT+CcIKDlw+cT4QssbKGqrYqbqwg+mEWgsgU5lN7QzKaWi5bXZHY54q+95mBsCf JVm/jZS9FZChem+Yc8F/yNiGEh+dgAYYqZi3dRTI9tv963oUqGNoTyhmOUHDNM83527bdU dtdf+kkbHamZyNNrmU6djO3msmrN0q8= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=bgdev-pl.20230601.gappssmtp.com header.s=20230601 header.b=ZCckGzRZ; spf=none (imf27.hostedemail.com: domain of brgl@bgdev.pl has no SPF policy when checking 209.85.217.46) smtp.mailfrom=brgl@bgdev.pl; dmarc=none Received: by mail-vs1-f46.google.com with SMTP id ada2fe7eead31-44ea1f87427so1997497137.3 for ; Tue, 12 Sep 2023 04:26:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1694517976; x=1695122776; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=dNmJanv/prkqq1jS6J4qAr7QRHlkbDKkqj7yolXDYiE=; b=ZCckGzRZ76gRvFUo8MVge9NVsPfJH7CLTgjO4dyEjHD9klFcF/1B2FygQW6L4kqgn9 ppr3bjs7B+fL6YlZtcYuUtEKncDJC1V1mvVQzd8slviC0d4zFyWpPhN9LQOvaO3KB8R4 UOVd5y8XO+Tp5E6GQ+vkb1LdZWcNZKYwVpBCBiDUlEW3C3DEEM0e3zK1UP1veko4aenB 8OnZbbwNkLQvzWg3d7n17lZQaZ+sJOMtX4xUgTodUGOC/90LmQgSZVSNcWPghpGiSBts sZPmaFhkIHUa044Kk1JLVdTfsXavg8yqXut993pHV8diWAV40ZPKIMGceMDMdsp2xaXA rXCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694517976; x=1695122776; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dNmJanv/prkqq1jS6J4qAr7QRHlkbDKkqj7yolXDYiE=; b=lUfVfjhUbH5ttDUm5+XdkV1CdgFYOi5HUWWgPfW8WRfKYynPKybP6aqVY9ezJnzGFw TGJa/nW9rZOhMF6ppvvxAsWtzCSvw4/fcoEQ7u9iBU2An2F8buZrL/8ShxBBMkmt8Yhp GNIrndnncO7SKQuJGTY/FTKaEjqMDzxnbsNxK8wAi2cVSEtwMVpD21VuySZ5xX0rRnpa L86tG1fYyyplZ70taPMWxUXt5fwv5XTKWhM2NA98Cb1BvnPDbfIS2qDc8WAObkTPgKKG WR/bzCVs4FLw+XLsF8WlurMaXSh/95p1ZLmpxnz6y0h4mJ85KbU5JoA3OGJJJwiBvqun m2Fw== X-Gm-Message-State: AOJu0Yx7lnK1u+do+wqYFXNYw74wL0Yk71LLKwr/DAB1YoxmIa/iPF+F GtLBzOtOMNiQtBEV4Vs7llgKEE0jnGwm6/H/hS28BA== X-Google-Smtp-Source: AGHT+IGWHftjbkZcL3VzQlLrct/Fpc06cLfTzQ+fr2Jd2zm1XlJ6w741bN5feejluBBbvQqa12peKpGgvdRUQM6DRh8= X-Received: by 2002:a67:ec10:0:b0:44e:e401:2854 with SMTP id d16-20020a67ec10000000b0044ee4012854mr9475177vso.13.1694517975881; Tue, 12 Sep 2023 04:26:15 -0700 (PDT) MIME-Version: 1.0 References: <20230912082643.13144-1-brgl@bgdev.pl> <20230912104258.GA12405@noisy.programming.kicks-ass.net> In-Reply-To: <20230912104258.GA12405@noisy.programming.kicks-ass.net> From: Bartosz Golaszewski Date: Tue, 12 Sep 2023 13:26:05 +0200 Message-ID: Subject: Re: [PATCH] slab: drop unneeded NULL-pointer check in kfree auto cleanup To: Peter Zijlstra Cc: Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: DD2414002D X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: wady831oap1nbqp1z994qideyp5m31ie X-HE-Tag: 1694517976-294898 X-HE-Meta: U2FsdGVkX19lsN+6URAi1c8bNu9xtOy6yyxz5YG35j2eIDyzQNRUw+cPLBMYx+kIRQ2HKzy1UEugdE+JLldK1Ogu4M9YdG4jzlUkK31X86OJOAzcTwoxfE6U2INI5m/dxwNZCLOi9osO/uZ9uzZFMWqXBEG/Kp+1pifYiYqHU3fsBbsuNoT5+KFCBr26shx4QvOr3J9xbD1VCCDiRUGtA45iI2adkG2qACdakTx3puSSMLB4qQ8KNEtd8nq+Q7/kDPod5t+iiWL/PWA4d15yLFJqiCjQzVrvlwihj/6rgKlfk8rGAl9tJyng6qq2gOVbj3S7s4YjuCzYuX8yD6TvM3MjyKsPWoE2uPMwGqc2OxwrvrrYJu5wxNX/dBkkLndhBBAADbu2ZxcHNWCAQlVyYFIv7cOccLKM2YSWKiYoPP/AiI1JVB/HmsBn10o6Ga4ZEqEyn95/ZKOA47Whi2ALJJ2TcXAr7wQ+uUUjI+2/suOXS57O6eN50yWTmvMwJPSFuYIiCz0AHyrCVP9machvSOSkdXqOAnicCvpAxdLqYe9zV0KC0WM53NhTW/4qPuAiBz9WfeYc7SFy3Y2c0DukpS5V20olEXFCGcEedolERB/FEsmMkxqU4TQDRPGaeLux0pUWNnlOM2pz8f+WAJxE3Cz9cbmtzxrIrMQb3Hh9nZzdo3gXgf+deRjhholDBEDfTAFq1omzcxT+2KxMWNh53WV3468KarVlV/vX2g9sgahjV+ZXkXqPN7DMMmb3WBiZ78SUZLW4Cy27H5bGwgzBtXmZO0saQ0S2eV7zISk68cjIrdEVWdzcFkde6ZtdzWaww20pTvEVPu5UFZIirw4hckrUN8Zu6tnKVwxm0y/bqR9ghq+wJPcAafX6/PcRkd36zPX6WVuLEhLKVWQ7CX2TbK4475vBbYEVBbhrGzyi3TT8+H32lIE/wigohCVAbPN57sFtZFgn/9xhCuJC0jb evk2/0V8 FLcKT6c6t86gKx4NT9jx616b8kRc6UCnI6ZcYdsBMvLGelVZoLh5B8It13ZM2LHsjpCUtepjQHhJ+5gTc1ECoItzLCaTSjsE6TBdI4O05k4o1ZD75WeEEt73re0Af5NWXUirKUVqeGTlgoNFBiZ5xxTdkymH5SpzuvSFN4DxW8KoIJyTurHSN8dhs4Onyl3nR3H6IZdUEAgOTPcmzwdhGKPGm+eOPKPoN39TnRQsPGZSKPTpoM2uFBBdKTj+O83sJWkR0deeLFSrlmk9LO57GnjmQCOEggvrB/4facnIjVaTUy3FYNbig0VTz3bY/2g5S3WwC7tAGR2eOih04zhaAkQjbOmlmYJtPg+n2D4lMzSQcJAIOMlolOfAPxtYDly6SMw+1XTpuHWucOUmXTnor0Whj97AmJZxxoM4sZZ2L4WVS0vmmJUw2M2OyFH535AiAdcghBwnD71MmlTGtCrUde1EQXm6zRjVqeoerR4hzWLD3VOBlCI7B3QDgdJmar43GHY27M5SPjl9YMCE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Sep 12, 2023 at 12:43=E2=80=AFPM Peter Zijlstra wrote: > > On Tue, Sep 12, 2023 at 10:26:43AM +0200, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski > > > > kfree() already accepts and silently ignores NULL-pointers, there's no > > need to check it when running the auto cleanup routine. > > There is, because now the compiler can't help you anymore. Also see: > > https://lkml.kernel.org/r/169451499208.27769.5856056754166699857.tip-bo= t2@tip-bot2 Makes sense, thanks! Bart