From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6AD6C4CECE for ; Mon, 14 Oct 2019 11:53:11 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A08C8207FF for ; Mon, 14 Oct 2019 11:53:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bp7tU3Oz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A08C8207FF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 461168E0006; Mon, 14 Oct 2019 07:53:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4124F8E0001; Mon, 14 Oct 2019 07:53:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 300DF8E0006; Mon, 14 Oct 2019 07:53:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0070.hostedemail.com [216.40.44.70]) by kanga.kvack.org (Postfix) with ESMTP id 0DBA88E0001 for ; Mon, 14 Oct 2019 07:53:11 -0400 (EDT) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with SMTP id 92A9E2C84 for ; Mon, 14 Oct 2019 11:53:10 +0000 (UTC) X-FDA: 76042229340.25.heat23_90138c4a78b27 X-HE-Tag: heat23_90138c4a78b27 X-Filterd-Recvd-Size: 3870 Received: from mail-lf1-f66.google.com (mail-lf1-f66.google.com [209.85.167.66]) by imf09.hostedemail.com (Postfix) with ESMTP for ; Mon, 14 Oct 2019 11:53:09 +0000 (UTC) Received: by mail-lf1-f66.google.com with SMTP id w6so11600636lfl.2 for ; Mon, 14 Oct 2019 04:53:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ffAwOpYyYrijKov93vskz3rGkU2NebUE5qWk+Iqkotc=; b=bp7tU3OzDe4CTQbmgPP07OB7D4YSsaiHPA6sa07+XUUV7hdtG4WYf9P8arfVZQlhnA vrJvHWIaUPmqZ70WJSSIK8PV2gDAS0RAWDRJGZwuIf6p3jnwHASNK6MO34XslL9TkqAh QA/86GDpidMckLw4ZR5aLFDzYKx4ksI4UClAK81tfbOfbwJIggpT2//8hid6C8xO4879 lRHS2AFFfpre8USlRmOLFsZQ30Xiybm/hLzCVKnCr50spa8WbkWOJf4jPEkD47zm7/d4 ljQVhuGXwkbjGJIv7cw1oYcQwnJQkiZf08cCcSlWCI+jPP357xq+mUG+usjBQA458KLJ KkDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ffAwOpYyYrijKov93vskz3rGkU2NebUE5qWk+Iqkotc=; b=X/eq0y7cgat282ZqrgzjR8Q3MDQ0XbTjwJYXHtQzy5ZelI2P05+qgWXcbBd5QTYcH9 ZDZYQg4uqbJ0mvRPPgZzvKZD8hStANex2l/MsMTaqgdpCe3p1VRM7qD7BHgNEQqbeLI+ 0qtXoqX58au33dcbrLcDKQU7xQDOKoZSaWVTmuXNPrx6Kf0Y8E/om9Tx9g+JzUwuB/xY fmwaYErwxIoecD1rLXGrMOrPS59GvS2YdUChYrGCEN9pbWaC3gLxR7/Kl6UheniiVpa/ T9eis0oKUakhVm6nKQaiCGnrBROUf8C5Y9SPe3F6wQ2hH8FoPr1WWFKNupMF9YINXvU5 VhHg== X-Gm-Message-State: APjAAAXfuelRfO4JaURh+JgHYGL5t9XkoObDAYe6Vs4ysF7HRLhy/QO6 EX4reY4xo796h2pJ9sxs85h1M1vKMTjhL0+loug= X-Google-Smtp-Source: APXvYqyQfkmDe5HAPPqmXflupWahYj+TJRfGIhzhs0YCH/rYiX5Tsu3NcTIyZ+4PsNnhrmjfgT6yRwVCXpaLts3McDE= X-Received: by 2002:ac2:51a6:: with SMTP id f6mr3063582lfk.164.1571053988636; Mon, 14 Oct 2019 04:53:08 -0700 (PDT) MIME-Version: 1.0 References: <20191010230414.647c29f34665ca26103879c4@gmail.com> <20191010232030.af6444879413e76a780cd27e@gmail.com> <20191014104717.GA43868@jagdpanzerIV> In-Reply-To: <20191014104717.GA43868@jagdpanzerIV> From: Vitaly Wool Date: Mon, 14 Oct 2019 13:52:57 +0200 Message-ID: Subject: Re: [PATCH 3/3] zram: use common zpool interface To: Sergey Senozhatsky Cc: Linux-MM , Andrew Morton , Dan Streetman , Minchan Kim , LKML , Vlastimil Babka , Shakeel Butt , Henry Burns , "Theodore Ts'o" Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Oct 14, 2019 at 12:49 PM Sergey Senozhatsky wrote: > > On (10/10/19 23:20), Vitaly Wool wrote: > [..] > > static const char *default_compressor = "lzo-rle"; > > > > +#define BACKEND_PAR_BUF_SIZE 32 > > +static char backend_par_buf[BACKEND_PAR_BUF_SIZE]; > > We can have multiple zram devices (zram0 .. zramN), I guess it > would make sense not to force all devices to use one particular > allocator (e.g. see comp_algorithm_store()). > > If the motivation for the patch set is that zsmalloc does not > perform equally well for various data access patterns, then the > same is true for any other allocator. Thus, I think, we need to > have a per-device 'allocator' knob. We were thinking here in per-SoC terms basically, but this is a valid point. Since zram has a well-established sysfs per-device configuration interface, backend choice better be moved there. Agree? ~Vitaly