linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Vitaly Wool <vitalywool@gmail.com>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: Linux-MM <linux-mm@kvack.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Seth Jennings <sjenning@redhat.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Dan Streetman <ddstreet@ieee.org>
Subject: Re: [PATCH] z3fold: the 3-fold allocator for compressed pages
Date: Thu, 14 Apr 2016 13:13:01 +0200	[thread overview]
Message-ID: <CAMJBoFN3__W1=q7R=ZgDsaiTe3nsmyXJVvDv-eURsqVeM9NR2Q@mail.gmail.com> (raw)

[resending due to mail client issues]

On Thu, Apr 14, 2016 at 10:48 AM, Vlastimil Babka <vbabka@suse.cz> wrote:
>
> On 04/14/2016 10:05 AM, Vitaly Wool wrote:
>>
>> This patch introduces z3fold, a special purpose allocator for storing
>> compressed pages. It is designed to store up to three compressed pages per
>> physical page. It is a ZBUD derivative which allows for higher compression
>> ratio keeping the simplicity and determinism of its predecessor.
>
>
> So the obvious question is, why a separate allocator and not extend zbud?

Well, as far as I recall Seth was very much for keeping zbud as simple
as possible. I am fine either way but if we have zpool API, why not
have another zpool API user?

>
> I didn't study the code, nor notice a design/algorithm overview doc, but it seems z3fold keeps the idea of one compressed page at the beginning, one at the end of page frame, but it adds another one in the middle? Also how is the buddy-matching done?


Basically yes. There is 'start_middle' variable which point to the
start of the middle page, if any. The matching is done basing on the
buddy number.

~vitaly

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

             reply	other threads:[~2016-04-14 11:13 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-14 11:13 Vitaly Wool [this message]
  -- strict thread matches above, loose matches on Subject: below --
2016-04-14  8:05 Vitaly Wool
2016-04-14  8:48 ` Vlastimil Babka
2016-04-14  9:06   ` Vitaly Wool
2016-04-14 15:53     ` Seth Jennings
2016-04-14 17:45       ` Vitaly Wool
2016-04-14 18:07         ` Seth Jennings
2016-04-14 18:21           ` Vitaly Wool

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMJBoFN3__W1=q7R=ZgDsaiTe3nsmyXJVvDv-eURsqVeM9NR2Q@mail.gmail.com' \
    --to=vitalywool@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=ddstreet@ieee.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=sjenning@redhat.com \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox