From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9659BC2BBCD for ; Wed, 16 Dec 2020 06:29:46 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E01D92313C for ; Wed, 16 Dec 2020 06:29:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E01D92313C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cloud.ionos.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 149C36B006E; Wed, 16 Dec 2020 01:29:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0FB4C6B0070; Wed, 16 Dec 2020 01:29:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 011BC6B0071; Wed, 16 Dec 2020 01:29:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0106.hostedemail.com [216.40.44.106]) by kanga.kvack.org (Postfix) with ESMTP id DF4DE6B006E for ; Wed, 16 Dec 2020 01:29:44 -0500 (EST) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id A72718249980 for ; Wed, 16 Dec 2020 06:29:44 +0000 (UTC) X-FDA: 77598169488.04.owner34_160d9b72742a Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin04.hostedemail.com (Postfix) with ESMTP id 8EFFB8001CFA for ; Wed, 16 Dec 2020 06:29:44 +0000 (UTC) X-HE-Tag: owner34_160d9b72742a X-Filterd-Recvd-Size: 7524 Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) by imf29.hostedemail.com (Postfix) with ESMTP for ; Wed, 16 Dec 2020 06:29:43 +0000 (UTC) Received: by mail-ej1-f53.google.com with SMTP id d17so31113858ejy.9 for ; Tue, 15 Dec 2020 22:29:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.ionos.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=LLDIZN+52dHA2Q00ZmFknUbyMne68RE5Ia9rozhDIVg=; b=apSdSC3iTGEsf2zJFsKGu5fTxff9EZjGlsqLnPs1hVIRM07ynp1sJJhmw6adX+mFG+ eQR62ix9kt5bMHex0+8hVfKkxUJ8MGW1vbXrIsaWwS9QPyDPeKsaMMrZMC3xodHg9yeu 088RV0MnCshcKyJtpyfulSfIcUFX/qaGRLbDf+VMMy+YLdm02wwsBIFdj94R3VaygksE Y5k0b6tljXREo/a0VXs/UQM4DtUS0Y5xR3qNwOUodod3pr9ARqwPjO9p+M9eSS08LMBi Buo5I+bai4mOYNHc6Tl/ywC0S1hcmeKnHdnQqANfXsNsw0VXF6xVx7AJOAa7e7Utkg5X +CCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=LLDIZN+52dHA2Q00ZmFknUbyMne68RE5Ia9rozhDIVg=; b=sguHdGW0cXWUw5EkTUJ9mi20MXYTF9alzgpq4kblGVD3l+EPU/b5f25l4u/CZ2lVYw bXgjbVftzEI4NYWYTpvDRzl63d06V8Rvi1GWJUPjiOe5pVUXHKE31LQip5FmerPA79/X aaCUdDSQc3vqqrV1iz6pYPzQYgYUwieUjRdcMedpUuGMRwqM97WcJzeYrruiXHx2pUCi glNGrGVJSkf+g8B4F6vvrZX6+H1c0uHG8Tg+Vn8UPHNFCZR6/DYiUb//FM3sZU3aDuyl 7BXX7ZOtkRP6NKiT0sK1QsGNZ45OYx/vHgfQi7wkcdQesLn9d8NhrsVRkPXkhQxO4SuY pbXA== X-Gm-Message-State: AOAM532e3nWFGwZvG9wwdvz85TOq4MGeJpjG0p3iedAKqkWzOXHD4F4Z 2lXN2238VVwixB0Oi/InS0PKNTeLstOcZKbSsvpXsQ== X-Google-Smtp-Source: ABdhPJyZcxZqxkm5HAE9XblDmGe3dMdwLDzgbyjQT6/nihGv+ikxfZhfr/bxmzKsFE3fJO7BUsX3JgDXQzoyc7uAg9I= X-Received: by 2002:a17:906:2e85:: with SMTP id o5mr7540473eji.521.1608100182486; Tue, 15 Dec 2020 22:29:42 -0800 (PST) MIME-Version: 1.0 References: <202012160612.RJtcXy6U-lkp@intel.com> In-Reply-To: <202012160612.RJtcXy6U-lkp@intel.com> From: Jinpu Wang Date: Wed, 16 Dec 2020 07:29:31 +0100 Message-ID: Subject: Re: [linux-next:master 9830/13311] drivers/block/rnbd/rnbd-clt.c:1397:42: warning: size argument in 'strlcpy' call appears to be size of the source; expected the size of the destination To: kernel test robot Cc: Md Haris Iqbal , kbuild-all@lists.01.org, clang-built-linux@googlegroups.com, Linux Memory Management List , Jens Axboe , Lutz Pogrell Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Dec 15, 2020 at 11:09 PM kernel test robot wrote: > > Hi Md, > > FYI, the error/warning still remains. > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > head: 9317f948b0b188b8d2fded75957e6d42c460df1b > commit: 64e8a6ece1a5b1fa21316918053d068baeac84af [9830/13311] block/rnbd-clt: Dynamically alloc buffer for pathname & blk_symlink_name > config: x86_64-randconfig-a006-20201216 (attached as .config) > compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project a29ecca7819a6ed4250d3689b12b1f664bb790d7) > reproduce (this is a W=1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # install x86_64 cross compiling tool for clang build > # apt-get install binutils-x86-64-linux-gnu > # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=64e8a6ece1a5b1fa21316918053d068baeac84af > git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git > git fetch --no-tags linux-next master > git checkout 64e8a6ece1a5b1fa21316918053d068baeac84af > # save the attached .config to linux build tree > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot Hi robot, The fix has been posted last week: https://lore.kernel.org/linux-block/20201210101826.29656-2-jinpu.wang@cloud.ionos.com/T/#u Thanks! > > All warnings (new ones prefixed by >>): > > >> drivers/block/rnbd/rnbd-clt.c:1397:42: warning: size argument in 'strlcpy' call appears to be size of the source; expected the size of the destination [-Wstrlcpy-strlcat-size] > strlcpy(dev->pathname, pathname, strlen(pathname) + 1); > ~~~~~~~^~~~~~~~~~~~~ > 1 warning generated. > > vim +/strlcpy +1397 drivers/block/rnbd/rnbd-clt.c > > 1363 > 1364 static struct rnbd_clt_dev *init_dev(struct rnbd_clt_session *sess, > 1365 enum rnbd_access_mode access_mode, > 1366 const char *pathname) > 1367 { > 1368 struct rnbd_clt_dev *dev; > 1369 int ret; > 1370 > 1371 dev = kzalloc_node(sizeof(*dev), GFP_KERNEL, NUMA_NO_NODE); > 1372 if (!dev) > 1373 return ERR_PTR(-ENOMEM); > 1374 > 1375 dev->hw_queues = kcalloc(nr_cpu_ids, sizeof(*dev->hw_queues), > 1376 GFP_KERNEL); > 1377 if (!dev->hw_queues) { > 1378 ret = -ENOMEM; > 1379 goto out_alloc; > 1380 } > 1381 > 1382 mutex_lock(&ida_lock); > 1383 ret = ida_simple_get(&index_ida, 0, 1 << (MINORBITS - RNBD_PART_BITS), > 1384 GFP_KERNEL); > 1385 mutex_unlock(&ida_lock); > 1386 if (ret < 0) { > 1387 pr_err("Failed to initialize device '%s' from session %s, allocating idr failed, err: %d\n", > 1388 pathname, sess->sessname, ret); > 1389 goto out_queues; > 1390 } > 1391 > 1392 dev->pathname = kzalloc(strlen(pathname) + 1, GFP_KERNEL); > 1393 if (!dev->pathname) { > 1394 ret = -ENOMEM; > 1395 goto out_queues; > 1396 } > > 1397 strlcpy(dev->pathname, pathname, strlen(pathname) + 1); > 1398 > 1399 dev->clt_device_id = ret; > 1400 dev->sess = sess; > 1401 dev->access_mode = access_mode; > 1402 mutex_init(&dev->lock); > 1403 refcount_set(&dev->refcount, 1); > 1404 dev->dev_state = DEV_STATE_INIT; > 1405 > 1406 /* > 1407 * Here we called from sysfs entry, thus clt-sysfs is > 1408 * responsible that session will not disappear. > 1409 */ > 1410 WARN_ON(!rnbd_clt_get_sess(sess)); > 1411 > 1412 return dev; > 1413 > 1414 out_queues: > 1415 kfree(dev->hw_queues); > 1416 out_alloc: > 1417 kfree(dev); > 1418 return ERR_PTR(ret); > 1419 } > 1420 > > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org