From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C7DFC3DA60 for ; Wed, 17 Jul 2024 21:01:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1B79A6B00A2; Wed, 17 Jul 2024 17:01:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 167356B00A5; Wed, 17 Jul 2024 17:01:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 02E3B6B00B8; Wed, 17 Jul 2024 17:01:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id DAB156B00A2 for ; Wed, 17 Jul 2024 17:01:14 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 83FEC41856 for ; Wed, 17 Jul 2024 21:01:14 +0000 (UTC) X-FDA: 82350464868.12.E50573B Received: from mail-yw1-f182.google.com (mail-yw1-f182.google.com [209.85.128.182]) by imf27.hostedemail.com (Postfix) with ESMTP id AE7984002E for ; Wed, 17 Jul 2024 21:01:11 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=RqhT66a3; spf=pass (imf27.hostedemail.com: domain of jxgao@google.com designates 209.85.128.182 as permitted sender) smtp.mailfrom=jxgao@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721250032; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Qa2XvP+C/3oeccCjHgfKummAIm8e+1hP7Ck2ED7Kxsg=; b=0O29j9rIDPX+VHXNAkINgR5Fc3/18+nwxa4SzzwQnvKWEfQL7UW0ijvjYEl3J2F39aTqKT jmou7QwPTzzFqtJ1pzaOUOyEvHcG/uwaeN+qrnrrA7IERvLJypiD9WAG9+7AL00x+yveEg 0CTTICGzACO7rm1wi4WgwdX4NnTBxP0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721250032; a=rsa-sha256; cv=none; b=V6yogAqwSU/c8A1cuSQ30TbvRD6ATcs0GhiJiXQmSokgAVOg+ZsU8n/wE8XSckjmNb2J+Z 5Oq+d9nY2Ap2CsQCfLMCE+vItmMpmM+KfZFofcSSQ5Etz0MlLYYiGrAOJaUzZkL44do9b0 fT8QM7Ek9RzbWifUcMWNbDC2eDztUJQ= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=RqhT66a3; spf=pass (imf27.hostedemail.com: domain of jxgao@google.com designates 209.85.128.182 as permitted sender) smtp.mailfrom=jxgao@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-yw1-f182.google.com with SMTP id 00721157ae682-65fe1239f12so764917b3.0 for ; Wed, 17 Jul 2024 14:01:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1721250071; x=1721854871; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Qa2XvP+C/3oeccCjHgfKummAIm8e+1hP7Ck2ED7Kxsg=; b=RqhT66a3YgCRy2PDbazvPC7YcX6W/QYS4ZUGjXGLGJQfnDD4/Om0R/VYOLRN0w1D9D 5YApFuBJcJRW/Cll4Bdb5MD6ZyjR3cltVy4/x/7bcgSNUcp47iX5nuJPK0Om7xCtxAfV 66hunLR2cdDmDu501Bi9QGefRP2PXWSAxsWZvq5clwYEMFG9qUHP2MSeOgBNtf1e4Eva Ci8iNN8IFJC8nXkb8mcYpVtCUTUqQNhedAWXCkSpJDOmRg6+MfWIFM2FpdpCLYokwwbF TAxkoZEBpp5uDaN6lXLvFjB48mIKUAnv9QKbKVew/oltIn3oy9Rb9OQzNpksUtaOpVFD 50nA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721250071; x=1721854871; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Qa2XvP+C/3oeccCjHgfKummAIm8e+1hP7Ck2ED7Kxsg=; b=lcAt8U8q4Yzz+VqeQNFRh3ZODqvRS0n8zUA7Fxqr7GLg1gfHF79u+C32KC5hgBLteA BIdxcSiloTMD+amy/ORPSXkm90/2skIgX0ORHdqFOEhN26QDTLq4gj+/0Eg5sLA6Ia7E Kkqep2V369ERhuiFR6KXCgwhn2gZ1r3RPaQBHk8pDtyYOEM7FVYxm1bCXvWbgdsg78fB pf9kEDjKWYdKMNfbzIhkQxa//eWxxaP+X1Dk2eeP43+bYtpheASIjQ24HXsSsHCLL2kl CzTqtmELw03ZJ26Z7bZs+dAGJVEBHF7b3+xlnxMOmcj/k8TwU80CM0QCgxvKs/0UPM8A MNuw== X-Forwarded-Encrypted: i=1; AJvYcCVh9vtSGc2F+qCSposbilBrmnECJGDAfxmDifPr9C9JjLAXxSOKMcvrluVWe2MlqDczKd2OasA674tkUZ2KDNrRLYc= X-Gm-Message-State: AOJu0Yw8CdT/5IPmDhhQ0g4VOlUyTXERNtjKD44ETrr7LwNPbrwrwQYn WQdNoTWm6fV4IRcLj/0l+ErULk5d1b2SBvYO5XyoOmnQQZwkVlI8T+q2uJPwaDtbCp31be2WJ0n NugdTZgLuHXXiU47z3XiOtpx+9Gd8zeLQ47cW X-Google-Smtp-Source: AGHT+IHdAN8Zygajofm83EFiNsxZUGRZYcOfrMblNz/bnqG3bIIRWIxc/dHHBoQXgnAbK/ILfo8V2BUbVMDkWG5u0/k= X-Received: by 2002:a05:6902:1502:b0:e05:fa51:9f89 with SMTP id 3f1490d57ef6-e05fa51a28dmr2191237276.22.1721250070367; Wed, 17 Jul 2024 14:01:10 -0700 (PDT) MIME-Version: 1.0 References: <20240716130013.1997325-1-kirill.shutemov@linux.intel.com> In-Reply-To: <20240716130013.1997325-1-kirill.shutemov@linux.intel.com> From: Jianxiong Gao Date: Wed, 17 Jul 2024 14:00:56 -0700 Message-ID: Subject: Re: [PATCH] mm: Fix endless reclaim on machines with unaccepted memory. To: "Kirill A. Shutemov" Cc: Andrew Morton , "Borislav Petkov (AMD)" , Mel Gorman , Vlastimil Babka , Tom Lendacky , Mike Rapoport , linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: AE7984002E X-Stat-Signature: eam6be14en159rpoziab8936bj4g3wrq X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1721250071-845641 X-HE-Meta: U2FsdGVkX19DaJqfQPXt6ZKSKkOZP5fcFLDBy3aXL0eNSW5+ajD5PbVus9oU+zuuUvV/F6YDsUFHvcjR4mC3zEpEvDSTKIyuLfWj3DEdXqe4HuWysLr5iZG4r/rymgHlRphOKYT5t3no2/8rRYPyoqqj37xR0/dC0mzyYau5Usc0s9ez+BRYK0KQllGIywEwPH7N+ubF6LYSZ4tOnIxJpnemdwKt2S3/Ev6yKGB45JqkEZoJo4Xwb3e7P1g3V7+eK7kZAaABG7IW/59HuD1kvVdyLJ4KTXiwgH5eatJ0dsrUdQ8AOUFFaA7FNvtqARK21LE9y3IO0ZQlOh3SaX5kMGPgyeFiW1nJRuCdUQfWPS09dhD6s9ePBMK93b+0NsMGZglPvREwKjf7786Y+2K3CtNYo3m6o733ilWp6jeNZxrXUvO1wYSJvbia8dW7drtQvEny30R2oqpVIT13anZM1vthXeKfk8SmIjdr4Ilz7CncefWUrZ3M4D7v/6MSM+SWbZtKKQcHeBk24z8JhHvCPBl3cDfwiLrnmIkIflwENAwPIEWy6uMsbdATwR1iyohlJjxOGdrapaCoIHxV6nM1uxhZVoaJPnmMvJMgUB0MmbwMdi3sG9mZ7w5T6SOc4vZUnlzIujPy7FfJcSvrIC0HacHx0KqJ94KCAGchkOSywLg8HSNXVkQbIngS9UUhbdsyIXxILPfBqEeb1mYm7HUPrT5oOWcnxXbzcUZOERf3wkvIrLrNUbL+fTxw0fppGQeQM6zQKElsRer5XQOyke9xxv8wutD5McFcDwpLlTu+dtHQhUVx1voNlzQIBnvHq9tEwhQ3F7tF/Y565fyARkbaGHLj31eTlFbCiwUVAnSUYilZbhgOPwrccasFylaRSx5RvHYKCnGKgAJaMavlT4hHNTiS19jplKLauDxMBGyz1mh82vl36gVSAFcIM9loi6iSQzRjLhjA/2d1kAQsqsZ wJOIHTw8 ZSxFo2qQ0Igirnxs5+nJt7CbW8jTlZKf+Gclr6s03rqO77WxjfLcRzhuL4bpunlKIkv+SAaCpdxTEl+WL2hE5Mhuc00LBi1KQOAnKSfZUU479EGfhRKyu40QTvdyc2lER0mFlYpZgv4gEIPOjk5mNlJRH9j3vfAqvruB4aNiVeGMl1eanWF7Mdf4XP85OgTLAEZh+FpRbE8gdBRpNilQxA7fgLo4z0bwR2ZnojXPkaodWJMMc26KzBHd/ZC1fb7JY2Nm0ENX2IO5MYbJ1ZPQW6Lq4Lw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jul 16, 2024 at 6:00=E2=80=AFAM Kirill A. Shutemov wrote: > > Unaccepted memory is considered unusable free memory, which is not > counted as free on the zone watermark check. This causes > get_page_from_freelist() to accept more memory to hit the high > watermark, but it creates problems in the reclaim path. > > The reclaim path encounters a failed zone watermark check and attempts > to reclaim memory. This is usually successful, but if there is little or > no reclaimable memory, it can result in endless reclaim with little to > no progress. This can occur early in the boot process, just after start > of the init process when the only reclaimable memory is the page cache > of the init executable and its libraries. > > To address this issue, teach shrink_node() and shrink_zones() to accept > memory before attempting to reclaim. > > Signed-off-by: Kirill A. Shutemov > Reported-by: Jianxiong Gao > Fixes: dcdfdd40fa82 ("mm: Add support for unaccepted memory") > Cc: stable@vger.kernel.org # v6.5+ Tested-by: Jianxiong Gao I have verified that the patch fixes the systemd issue reported.