From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 545B1C52D7D for ; Mon, 12 Aug 2024 22:13:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 829D06B008A; Mon, 12 Aug 2024 18:13:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7D9966B008C; Mon, 12 Aug 2024 18:13:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6A1066B0095; Mon, 12 Aug 2024 18:13:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 4C8476B008A for ; Mon, 12 Aug 2024 18:13:06 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id E015F1C2365 for ; Mon, 12 Aug 2024 22:13:05 +0000 (UTC) X-FDA: 82444994730.25.ED6A3FB Received: from mail-qv1-f45.google.com (mail-qv1-f45.google.com [209.85.219.45]) by imf04.hostedemail.com (Postfix) with ESMTP id 2538840019 for ; Mon, 12 Aug 2024 22:13:03 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=OeK4QjMf; spf=pass (imf04.hostedemail.com: domain of jxgao@google.com designates 209.85.219.45 as permitted sender) smtp.mailfrom=jxgao@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723500748; a=rsa-sha256; cv=none; b=ORFLBchilhHq4rX3wqaAdxua8clWXHcj/lDc1WQatWrfzruyINsMrb6JpMDrnRNUpmvYWN fS2+enLVkoQdNJtLIba78xJxomzlrHEE6p5IIFc6ih1PN7iBs/HJb1jRgcedhC2OdaXByG nlCVPGBAjJOvx/iEQbIxbP9Qfo2EDCw= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=OeK4QjMf; spf=pass (imf04.hostedemail.com: domain of jxgao@google.com designates 209.85.219.45 as permitted sender) smtp.mailfrom=jxgao@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723500748; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LyFKsDEgjnxNEVYqxUkhyYjIwPC3euwsxGOU2i6sWGk=; b=JKAdZTyXccOTWIP9FzBOc6GSUMXBfmA/Usxwc5y3VuByA4PmmTpjtcpaYZ3F2r3i9/YC1V T58pMOc2dQEo4hCuTlWw5AL2jF4m1jblmI+E82ZU6mB09nAXFHJfDFh/HVnT1kq+xr13qZ 4fCDQqLMxFnoqRV4JLJRS2Oz0qbFkvE= Received: by mail-qv1-f45.google.com with SMTP id 6a1803df08f44-6b7b23793c1so28978136d6.0 for ; Mon, 12 Aug 2024 15:13:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1723500783; x=1724105583; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=LyFKsDEgjnxNEVYqxUkhyYjIwPC3euwsxGOU2i6sWGk=; b=OeK4QjMfX6ASXh0aomxDQi8XbOGXHiBEyyTPwfbO/qQRvxYBQqmRo2n6z9VUkIdLS3 PPvo4+afLKb1PIbfxKrOWG5j9ZPqtlx4JcFbizeZkye/2t9sETaOFLYG0bCsBzRK5nIr JcAhbvd4dvZD6cJtDoPboMLda31TnxLqSBEiujRz9C8iOrTiIoLNfIbQN8dS/aNuUhsN B8S6o3uwxF9RxyHuEUWDEkI3poplF8xCD476PZRFJyQLzA3FGJu8CLoODLuNJ/lkTgh6 ADs4bdPALzHufxedfUJ4Yo5T9D55uEVLr6YM30pc+NTilRnKQuYhpJm+Kq3cSsECIcLt e4PA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723500783; x=1724105583; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LyFKsDEgjnxNEVYqxUkhyYjIwPC3euwsxGOU2i6sWGk=; b=ZVTpX4UnC+uH3wdwEEm0TfuncxRkdPbGVEaZg3tSWgzBIHZya6/Jw7pKs3gwQrHklX oB+qZ/ZVaogn43sSJPjGqUA9aNml/RaURR865+VqqQW3fJjwF2X6G8tchN5xqjiR8Em5 vih3sX4whxBkCURr/f4JQz0jjB7qCCSrdJKOUx2LNGdGJgSvGrtIkI55FSpIXQQ6Oztv HuiStZb+bL2uiLknRS3KE1AEg3YXghEvq5LEx4baDVA1cLYwfagvvvV1V7cVowzJqSz3 lGgUA3FUWkgubaxCLEfIfL9bVEQTWAg2PBaiZqj7wOwTHLCyDzfy+iXTzWhC83V3nezq KPiQ== X-Forwarded-Encrypted: i=1; AJvYcCXpmOGtfH1DgQ5e7G1FjPzl25mzI1AbNgH5zfXmW000y2d2md7L6YKKfhWQoEq3l5GhndJlrgo07TOjMzvDWbbK1v0= X-Gm-Message-State: AOJu0Yza/ZU+QJcaJ9QaALgKFkcPOEZ9iP6YF4YSFqe9UcbQV8mfHxZ3 iAerRrD4PLUdcWhmJfJycyFROUACpQ03MbLfvoO5KJEE08KfSaUibabPLJi83oDhJKN6+ih93qd tPHDTZ4uSkeMaIRJ2mh0mDtVe1ndUmPFr0f7s X-Google-Smtp-Source: AGHT+IEoO+b9pY7C5DoqMaKmNrfWrx3T3pQDUYneGHRDOHmrDXK+WYRUv2ZXVfLXYFWMQ9tgg2yWFX1PctT326bWJv4= X-Received: by 2002:a05:6214:3a03:b0:6b9:5cf1:65a3 with SMTP id 6a1803df08f44-6bf4f84c149mr17036116d6.43.1723500782966; Mon, 12 Aug 2024 15:13:02 -0700 (PDT) MIME-Version: 1.0 References: <20240809114854.3745464-1-kirill.shutemov@linux.intel.com> <20240809114854.3745464-2-kirill.shutemov@linux.intel.com> In-Reply-To: <20240809114854.3745464-2-kirill.shutemov@linux.intel.com> From: Jianxiong Gao Date: Mon, 12 Aug 2024 15:12:50 -0700 Message-ID: Subject: Re: [PATCHv2 1/8] mm: Fix endless reclaim on machines with unaccepted memory To: "Kirill A. Shutemov" Cc: Andrew Morton , "Borislav Petkov (AMD)" , Mel Gorman , Vlastimil Babka , Tom Lendacky , Mike Rapoport , "Matthew Wilcox (Oracle)" , David Hildenbrand , Johannes Weiner , linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: coeegs7j3gf7u33csnighq779u9pwpbi X-Rspamd-Queue-Id: 2538840019 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1723500783-806505 X-HE-Meta: U2FsdGVkX1+IB8ZaiNoMIU7IU0XJGZ3cfWjDzgzNKDMvznEPa0tMC2B4sDuxIXLwp7TJlrOhrNEaUP9j33rCn7X04Jle+7kRkYGV+jYJ1K8nBarOOsW6NA0cdUZfmsfoiy8eJjXUBpIV8gZywFFkdjfO4guJRA5Hlkbh0uXq7sbn0IUevSg8/bQz77J4EELvS4vnSnJcgYuWQBpYaWFk2a0L/Fmg/Gh0+hMmyZV+FssMTdPCJtLI4XfMOM7FZHnSKifRkNhV89vprTvnawLgtcnzEGLIUvElV/xqEdSHzhpYOv4aEHvh8ov9BAZ/XtCyF5M9Z1wDDNZES3HsdkPch8eyxfv+CFB1OyNGTRX/KbJPoCO/UIZ94GMoZdeOlhwYJCR2d3zeoJ44n428/QcydA1AwuhPCnndsVT7m6GRjUVfB1gSf4+bHZh8ZxSEgum54cGQwigMdfLLvhkbyR/ee6wquJnC2YKKU/eOjwS8+3dIFya6xwPEw3h/c32tV5gsWdaqGtM7rWdlPW/vMnWLf/f/waNuYWOoAVIV1dCgsNk4K267ss/kJ5x1SApH16ZIHEnXLvVj1dxwbK+mQ15biS1mKAO4QzbiepEeObJ+DMMNNrb1QHqYwxJd4dZG1sID55sTSk5hxHP10+OQo1+AUz3KJP6gp6oVHQmSU2FCdVjX4eCCYoa3YrpsEX1JhZ7p+MnJy83kQpe7GCxlhzuXMeZF4rTgj+DR8WRaJRyFlsIVVh51rOAWmoKLjWT34o8K/50t29hneHTK9/AFAebNrZF50KlgvvLdjEvyrpK6dZJIfTditqW8Uoz8OD3KdcrVxnPps44z6Tk5Cky6TZQav46OLXnLfDUX5/18EqLqMToHBF6Mc/gZiz/476WzWr3LAqekdGHmt9DH8qmBYXZ0vGsYOHHv5mukluDclEcuXwJt2GDgYllMV5PxCRvEFkUPHTNh/+Kxw6MPEc3BRn5 wRDHPk/Q MEJdb5eoYUlocct2UbrbjNsbW9HJXBB5o2ZVbgW+mGHSOM0eaDmTkuwec3knqknuPG90qVJtqv7H8LJAMu1IQlf4OUmyRaw0ptACEWmrYJg4sqwfJ++TC5Mgp3KFnc0oz9GOwUN11OyCQenX3+RxDAAtxAfAGo1tyKbQRRu5+EQmChuAITCrFMS/6WQ498oq99kxQzbHdHx8ii7ITRipYlvY+F8Qe5JONr7y0xoYkjBD9e3A726i+sRJsM+X0V580a9HAvolcza0Y9FAlF4D16VKodI14hV0uU0mvNO8xLuhRSWY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Aug 9, 2024 at 4:49=E2=80=AFAM Kirill A. Shutemov wrote: > > Unaccepted memory is considered unusable free memory, which is not > counted as free on the zone watermark check. This causes > get_page_from_freelist() to accept more memory to hit the high > watermark, but it creates problems in the reclaim path. > > The reclaim path encounters a failed zone watermark check and attempts > to reclaim memory. This is usually successful, but if there is little or > no reclaimable memory, it can result in endless reclaim with little to > no progress. This can occur early in the boot process, just after start > of the init process when the only reclaimable memory is the page cache > of the init executable and its libraries. > > Make unaccepted memory free from watermark check point of view. This way > unaccepted memory will never be the trigger of memory reclaim. > Accept more memory in the get_page_from_freelist() if needed. > > Signed-off-by: Kirill A. Shutemov > Reported-by: Jianxiong Gao > Acked-by: David Hildenbrand > Fixes: dcdfdd40fa82 ("mm: Add support for unaccepted memory") > Cc: stable@vger.kernel.org # v6.5+ Tested-by: Jianxiong Gao I have verified that the patch fixes the systemd issue reported.