From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35306C636D4 for ; Mon, 13 Feb 2023 17:43:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BD6A46B0073; Mon, 13 Feb 2023 12:43:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B86D06B0074; Mon, 13 Feb 2023 12:43:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A277E6B0075; Mon, 13 Feb 2023 12:43:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 8EE186B0073 for ; Mon, 13 Feb 2023 12:43:39 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 5D0A5C01AD for ; Mon, 13 Feb 2023 17:43:39 +0000 (UTC) X-FDA: 80462990958.06.060B88A Received: from mail-vk1-f174.google.com (mail-vk1-f174.google.com [209.85.221.174]) by imf07.hostedemail.com (Postfix) with ESMTP id 9407640010 for ; Mon, 13 Feb 2023 17:43:36 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=pB2tn5tH; spf=pass (imf07.hostedemail.com: domain of namhyung@gmail.com designates 209.85.221.174 as permitted sender) smtp.mailfrom=namhyung@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676310216; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9482UVrO1xOex3fDG9vOfHJvbLYfZSOVxzqODqZLrhM=; b=0me+JGtn01hAgdLgu8oLvGTjC1K7JbbRp7ZFUNH8MweeQpsa9vPefQgPBrwIU0L76hph6P RJe+DIbxbqYhTvs5jgMcT0k+IRMW17o9+BqgGfCWP+9t7ROQxrPxYLMivbWVnIctleHTsq o19eA0Tbhng0POS+TLVZlxLcw2qI8Ww= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=pB2tn5tH; spf=pass (imf07.hostedemail.com: domain of namhyung@gmail.com designates 209.85.221.174 as permitted sender) smtp.mailfrom=namhyung@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676310216; a=rsa-sha256; cv=none; b=I9vzhJQpyb7nKaIkewqOoPB6iWFs01RXaimDtiUIvctbWg8eiZDCuyPQlO2pkih8JGn56r /2Yps8oXfZ3gFpvkBZDVd8GcxBbuvP+lw0TJXTN6AGzdL9n01EMCNEOYRt+vEx5/Fz8UdQ Lv2TUXS+Z7mCry9s632Mj7mpHeKSHNI= Received: by mail-vk1-f174.google.com with SMTP id a12so3919444vkl.8 for ; Mon, 13 Feb 2023 09:43:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=9482UVrO1xOex3fDG9vOfHJvbLYfZSOVxzqODqZLrhM=; b=pB2tn5tHtfdCBMJjYMpCnJdlfezc6ccapdYO+jtaejPe3lAp31vt7hDCh/K1Qmk+an iT+5ExitRyh2ov/ygn+EM2zyfFsJOrlA0tdr04jXPHVVGKG3L0T/SZoNY8SBtnGHXe+B F/iAH2FmUy7ZlvOTvTc3+n9Bc2tNwmAiuypafTYDtfBnlg08SaTzS3elt8Xq0fPrGZ83 nGa8MLNwHr7g5pG5KKnkp6VHc/sDxyUNCeo52VFtfey7pB0o6d69Hhk4O3/FvOOzF3YT hHUSIun+9lxMk+VcHUR/MXqlrzU31901zhjtB6kVCrFFk3TwbOKoqoteKAzeUDH09+IO H20w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=9482UVrO1xOex3fDG9vOfHJvbLYfZSOVxzqODqZLrhM=; b=uQV4Y6W4j48AWao4FB4xYBZQ+mczkos1uwhxajx0AL8BDsRS6GYYVyC3/tk12QvGMa RMn8xbcVfX2c9awqSMGfAuEHRiFxJk/gswj/h5iWVtoCea3EAA1FMLemkTV1gOVBD06W paSoyo0hisPJwFIz/nKjBWyfuV35YMNdIf+d3PIs+QzRhxmHUv3yXmW6nmAOf9nBr2QE /l/zslOJmvU9OtRUBLbnK44bEGUqKcUTmqcV32SmI3ms+QoDUX9oMLdKgsHXHmoNq86w 9437sC2niS9jsUsxhudc7k4jryU12Uprd2eC5317KcRFQx6fJVVBFksmICZzPmXsAixs 1pkw== X-Gm-Message-State: AO0yUKWMQXUNWJLV4oCCNn1dU6+1drrUCeMsCgTW+9PodDJ04vmHMvOQ Ln1H4X1jT76Lvcbfmc8pQoFAKBUnCiOzXM9hP8k= X-Google-Smtp-Source: AK7set9naPVyKCrqkGR7F/qNK9P9Tk3CooQcQ6h1dj4d/zgb+ama5O2Sbg2TvqL3Nq/Ktr1Ruv/ioL+LSUFZ1zV47KU= X-Received: by 2002:a1f:3883:0:b0:401:58fe:533 with SMTP id f125-20020a1f3883000000b0040158fe0533mr968170vka.25.1676310215561; Mon, 13 Feb 2023 09:43:35 -0800 (PST) MIME-Version: 1.0 References: <20211120112738.45980-1-laoar.shao@gmail.com> <20211120112738.45980-8-laoar.shao@gmail.com> <20230208212858.477cd05e@gandalf.local.home> <20230208213343.40ee15a5@gandalf.local.home> <20230211140011.4f15a633@gandalf.local.home> <20230211224455.0a4b2914@gandalf.local.home> In-Reply-To: <20230211224455.0a4b2914@gandalf.local.home> From: Namhyung Kim Date: Mon, 13 Feb 2023 09:43:23 -0800 Message-ID: Subject: Re: [PATCH v2 7/7] tools/testing/selftests/bpf: replace open-coded 16 with TASK_COMM_LEN To: Steven Rostedt Cc: Yafang Shao , John Stultz , Alexei Starovoitov , Andrew Morton , Network Development , bpf , "linux-perf-use." , Linux-Fsdevel , linux-mm , LKML , kernel test robot , kbuild test robot , Andrii Nakryiko , David Hildenbrand , Mathieu Desnoyers , Arnaldo Carvalho de Melo , Andrii Nakryiko , Michal Miroslaw , Peter Zijlstra , Matthew Wilcox , Al Viro , Kees Cook , Petr Mladek , Kajetan Puchalski , Lukasz Luba , Qais Yousef , Daniele Di Proietto , Linus Torvalds Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: e3fc9etxjip3y4nq3a5k1p5is1rqh33b X-Rspamd-Queue-Id: 9407640010 X-HE-Tag: 1676310216-682281 X-HE-Meta: U2FsdGVkX1+G0N684kaucicM0jkRwVeKdwNroSC4GBRblwdqTG35NWLGxZgAAYTEp81xrVmondXgnY+MLl+bLVWMK/rYPxxEiMXdBAfwArAIqZwrU6emsxZc+v3IE5QJqzw3XSewt9TwADfCH7Ew9wL7pF94/MptCa3jvlRgOokHnqO94DB81P1qG5v8mlxFfkA9Gs2oht9b9STeHt8c6wHsZF69sxlGO/2terY8/aHAHUMYO/2Mg/y43NrJY34ER0ccPZ+yGr1/kszWk+4knZguydme33mxf6/tfnfIIFlAtSmuoH3Duc2hvbdk2+hGOoRzL7O4M4gvDtHZsicmivK8a6W1JCb7ARM10J4hQ6wgxfm3s/0ruDPYF5dXmZzLFLMNgpkWBYfrVbq159JEgD/H1IYoagWlvq6QnQ7ZnMqK8MpQKdDE1m9KEC83WHEDkSGKknPCP+4FluoT9NENE7FAy6kZUc/fFko3NOoyRUvwG63fjtQSyxu6Q0MgevmrAWukh0HYS4lOwkKso2CAcfShopau3e91/prtSWpLhyQ/t2Mhp5JXr5wvHkOIl7+/EA66sGx+UO2/LgQjcJUR+Z6u6pkuxvUCR/q2ak4lhB+cu8zTM9D0C8L5EAIxgEYHupjnI64z1LxFu/hN6/BQL4Q1yt5jDMKQdtWkxGWCZRi/XHria0r0qq6hgF5nuGhP1SHZBvCVIkSsh1hPtXBzH0Rq/nQ0c3et9sFbzr0EUlWL+SzjvPEwdKMIFjZkvCdcxR7JxgJlJbQd0kQoE8/L3b6qgOrIOfJWHfzVMmXjh5JBTLY+qfRheXL61t1ZhjjMv6snL4BOivtKsObNhgAhCLwlgurba0kUzH5aNkHhy5jnM826f+66dGf6OPD/grCsU1fWVe7mvfJX8zK9Xz4Muo4ouWWvLhKETZ2Kqu6AzCclswROhsV06+/JcQFZxs08tS1j/82JtE1TY7DIH5X qudecKQ5 fNwZtn7y8/MOQY9JhzSYanf7gORtouKglMrIiuXeC9NHPwRapPR6vyp+RKYd7Cl9CLKsAEPJLNE1pnRWaq6/RyLgb3auscRFHEiAoT4bttgGWOX4fpcEqExzqYW1zXNyp+wXqSuxeT7nMK6ObbtqkI+z8oimps15UVG9ZswSEyB4V0J/WD3L3u17JwcSgPre07DCT2q/NwB2U6Kl/L3voyRuoNVznurkRZIGBB2JpHbHDX3OzZo9Lux3aBjobU40PwRB1fDyegi3iYkSJwwf1sToxF7c+LzMaaQ75FZVEiO68Z79/yiPINJE4Oq0haSSCnpywWsCndIAE1PprR/bQL7cvM1qqaMhCuC6E6OHM0h+ipWIDAWLvn6Hbt0aoTYM0EanPqstTBPvpAjChbFtB4aoEt53+1VEiGgpCk4r1FTVIg1V7tXzk8qZ0l+5aJaahWkRyWZ4IfhJTXfKsIWpjQbCtB+k11VstpXHJ49dkPSdGBs3qjYF5gj0U2NL+XxudPcVHupyu/mox51mFmV7NMk3SHrpMsX46az++iAGC8L/0bC/7VjxpqoyhYyXk9ED7ilX7 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Steve, On Sat, Feb 11, 2023 at 8:07 PM Steven Rostedt wrote: > > On Sun, 12 Feb 2023 11:38:52 +0800 > Yafang Shao wrote: > > > > Actually, there are cases that this needs to be a number, as b3bc8547d3be6 > > > ("tracing: Have TRACE_DEFINE_ENUM affect trace event types as well") made > > > it update fields as well as the printk fmt. > > > > > > > It seems that TRACE_DEFINE_ENUM(TASK_COMM_LEN) in the trace events > > header files would be a better fix. > > NACK! I much prefer the proper fix that adds the length. Can we just have both enum and macro at the same time? I guess the enum would fill the BTF and the macro would provide backward compatibility. Thanks, Namhyung