From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA9D4C61DA4 for ; Thu, 9 Feb 2023 19:38:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 27D516B0071; Thu, 9 Feb 2023 14:38:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 22DBC6B0072; Thu, 9 Feb 2023 14:38:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0F6476B0074; Thu, 9 Feb 2023 14:38:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id F0DB06B0071 for ; Thu, 9 Feb 2023 14:38:27 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id C8E54A9CB3 for ; Thu, 9 Feb 2023 19:38:27 +0000 (UTC) X-FDA: 80448765054.18.01DCA38 Received: from mail-io1-f42.google.com (mail-io1-f42.google.com [209.85.166.42]) by imf01.hostedemail.com (Postfix) with ESMTP id 0770640013 for ; Thu, 9 Feb 2023 19:38:25 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=eZBK7bsG; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf01.hostedemail.com: domain of namhyung@gmail.com designates 209.85.166.42 as permitted sender) smtp.mailfrom=namhyung@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675971506; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6Jdh4VULJ6F+h4MAiYTsb2LTjagqLadibqRKQMHpvOE=; b=pZeecDnFA9nclAn1yF5QjCtJxw3AuygVHvmX2cMhQmEZC4ScwWl88v9fVBpj+HXp0PMFQW mcG99nsHYnFtKf+HLLFdSjN9hrqxAk4VIlWQyOobjxr3GwyLJcnLFbEXy3oCqfEp2eTojJ d+mPGNWhGlYDFyGCaelRStwOgy3vzJc= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=eZBK7bsG; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf01.hostedemail.com: domain of namhyung@gmail.com designates 209.85.166.42 as permitted sender) smtp.mailfrom=namhyung@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675971506; a=rsa-sha256; cv=none; b=ePJUPGpYfFKtNboekZFqmLlHjpiOkLy3ntGVM3Tvw2oXospAgI/s8zTnNs8vLwk79Dfsc5 mi15tq8NJZcbEBVzfIDnBbCljm1ydD5AAoEbLzj8tkgBAEeHfR/rP3XCuRMTWpCfo+vZkw UG4zt416k42xnwqwVYmJ7tfM/VLXQ+U= Received: by mail-io1-f42.google.com with SMTP id l128so1106505iof.2 for ; Thu, 09 Feb 2023 11:38:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=6Jdh4VULJ6F+h4MAiYTsb2LTjagqLadibqRKQMHpvOE=; b=eZBK7bsG54sHx0p7PAQy2iX/zWTjNGA/Qd2/ZdxdVyvp0yXbv8yOGGG3EWPo99DRtz D41JPGxHrKpnMA2ZENevlEV6JriYGPcTumXjSnsCJZwn5IrH5m3MDKobvNnUu2QaxaNv +WiUlme18JXjpbjqrOg7uTaDWpVBzldrKQFEOrgFo/ISWjXyFrg8oofCUNE5uxKa4fQa qqPF0R2NmRh4nBz+9U9FaEP7AHFZCLVSA96LHlfeeqzN265jRXHEQ9O8YMYBZcK9PUrQ esy+bkwI35pyARvJmzRbZzKGOtkGzjGwSFU7dXqiDzoO47SEOS2+of7u8fQwhZszP01/ yFIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6Jdh4VULJ6F+h4MAiYTsb2LTjagqLadibqRKQMHpvOE=; b=gbvW+TjKb0LMCgUptcWM36vsiDZesvouC4nii8kjFlTRWX+HiGugnp+fHn2LrzEYfI h2PfBD/SLIj7Kl3OLIeNY4QzDlO9rCdRDKtljFaocdlWS3SqmTFc086lBkzI/5JbVm7X tdemNJVaRdk3mX8PRkBBFp8j7pXNgeE0dMuJSItLd61MfqPJN34vC049ZVDGgK+6XN6q 34W+90Z0H2gb7luufvkNKvC7qYVUfnr2I4OVJ1QQs2qOkQJCjZwJhLmFTv4252PSH0kt Oe+tcxgz6nSEzO7zkNQh9UgAm3tYmUC55QES2dzXXducR5jJq7Jht/9auq8ozNFPH917 A3tw== X-Gm-Message-State: AO0yUKV91Nnr09URH+tCNHJQpKl8C+AHT97X+/ENcoINEtR8qgziAG9S 6A0ruqsEZ/MmEZ91cNksX1JoIa6+Kb8cjOgLQTM= X-Google-Smtp-Source: AK7set/SRwK2j1K6/X1ct4MebC7m2uZKEvZh2iPzd2xeOuLUL++LqTwMGYRVKWqAXTayJdIPTpmag/h5t3V8QGEoDGA= X-Received: by 2002:a02:b80a:0:b0:3b0:5216:258a with SMTP id o10-20020a02b80a000000b003b05216258amr7282175jam.23.1675971505154; Thu, 09 Feb 2023 11:38:25 -0800 (PST) MIME-Version: 1.0 References: <20230201135737.800527-1-jolsa@kernel.org> In-Reply-To: From: Namhyung Kim Date: Thu, 9 Feb 2023 11:38:13 -0800 Message-ID: Subject: Re: [RFC 0/5] mm/bpf/perf: Store build id in file object To: Jiri Olsa Cc: Alexei Starovoitov , Andrii Nakryiko , Hao Luo , Andrew Morton , Alexander Viro , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Matthew Wilcox , bpf@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-perf-users@vger.kernel.org, Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Daniel Borkmann Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 0770640013 X-Stat-Signature: fmwkekpmepoyrpgo1doq87j8t1edxq5m X-HE-Tag: 1675971505-171435 X-HE-Meta: U2FsdGVkX19RRXjR+kMhqtvHLHPm+O9rPeOMLSor8snAR808LXRx32O4bFKX/ECzvx9jKcmMphjinuBdwebrPgMFeIgA/rl9OLv/nnwzx6b8hNoheFP11+3p+CKE6G3ZkNivO5cAlGS0r8wKNxtr2QjNvUXLYiB3DyMEije0/R5eVHRcZ6xXFCQZ7b60hVP3eXvwbIcTwrxqR+9tm97srZ5bJCqD8esbohJ8WXHDRmxB93Rr7JxSXxEY+hU2evgQtIKpahSppuvl4rKIsAuwiQjJjKu3uE2erwsPOhV+oTPVh4ZfJrf/BDbTAm49QhFmn0hN5Y93Ev99jd5NPGQKHhECoZgbL165wQvm43NBvJDJR3COnaZkKftkQAXkHjMp3Mu8JL0a3DGuRHuxbveexJzAqI2bQho5VZoQ13OF+/3xr+2SemTtF4U2Cw+huKjahrgjThEgJlCCzAe8aS2qrsLWz0BxgVT8rzVUARNmv+6LQmpzUOgMY4n5yl7b6Ev7geR5PjRNE/YtLkmJ7rbsjV6r3TAu8sadvYTJb+wMleJU/Ixo8vHcgk4auPDEL1lgf4ybIdSpN6gTtqiliT7pAPc7o0vFKQs7JT+wU9WuNHwag3UNV9EAFrF/JTqcao515gB4VKarRwZ/OfdJMtmvn6yg3D07yfIMoNYKvL7pes+f7tOgfkM/VdiSAg713s0Teu8uVDCcJ9bICwfWMZRPO2y3WzWw4h37GqfqXlWeSYfMNWUe4MthQaWBo1AkpOD0RzNepuI2EXO2OioWCkJDKyt/ufYyBysrhkApwmNBREntJJHJliS3DEjfa5ttGCpX3wEsOOpTEVeaIh+s4jS4en653Bdbcqe8VxuEpRgRAr4cBNcxJoDaWpjQ7x6pf7UnuwjIPOHwDhkplO6V38rM1qcnSdreT7l1uwT5703NpicEVVECbwXo0eloIi2RWoiuYXpqxcdtVYHgH3l4sP7 1l0FdXXC 86d44BbiVCXl2lOMSlD0MgsnFP/KwauLW/c1SmRLZyOjp2d7ZhJjWiUF780ulZlG0O0UdH3Q4zGOt8opP/xG4OlmQuhfjDHoVaLpluOe3ZvGVh2z+T08C+vo1452FCaKGJDAc7gAylKWpI1WZKHn0uAY7b+Ljta2MgKhuMqL3aeANQwyfNaKlYA3MLVM8LCHbT0xCNAHktZpw88bkQ2N6zheiO/GGvwMO1dQwB9N/sNTPcdH++G8k9jEwEZgfTdcgMKHq5YiTtCMtcXRbiyLho7QLCK6KsEGOj1fxVfjd7q/LSEYry798rczVS7l7l3dzbR5+aUBw7UoLUf1iKgyMU9U83F396R1BcFO1YzlRyP2zHsVs6u8bZrJI7f8yXUVs5/8k3ERU/9eManjzrOhLIV+1Z/lxlAyiglv7gcLweDdYW23veKp74ihrWRh5WcF0W4sm2ZckJaS0Pg2ydgSexSC4NtAqgSlnR9x+uJi1Owyj+w4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Jiri, On Thu, Feb 9, 2023 at 6:25 AM Jiri Olsa wrote: > > On Wed, Feb 01, 2023 at 02:57:32PM +0100, Jiri Olsa wrote: > > hi, > > we have a use cases for bpf programs to use binary file's build id. > > > > After some attempts to add helpers/kfuncs [1] [2] Andrii had an idea [3] > > to store build id directly in the file object. That would solve our use > > case and might be beneficial for other profiling/tracing use cases with > > bpf programs. > > > > This RFC patchset adds new config CONFIG_FILE_BUILD_ID option, which adds > > build id object pointer to the file object when enabled. The build id is > > read/populated when the file is mmap-ed. > > > > I also added bpf and perf changes that would benefit from this. Thanks for working on this! > > > > I'm not sure what's the policy on adding stuff to file object, so apologies > > if that's out of line. I'm open to any feedback or suggestions if there's > > better place or way to do this. > > hi, > Matthew suggested on irc to consider inode for storing build id Yeah, that's my idea too. > > I tried that and it seems to have better stats wrt allocated build > id objects, because inode is being shared among file objects > > I took /proc/slabinfo output after running bpf tests > > - build id stored in file: > > # name : tunables : slabdata > build_id 668 775 160 25 1 : tunables 0 0 0 : slabdata 31 31 0 > > - build id stored in inode: > > # name : tunables : slabdata > build_id 222 225 160 25 1 : tunables 0 0 0 : slabdata 9 9 0 Cool! > > > I'm stranger to inode/fs/mm code so I'll spend some time checking on > what I possibly broke in there before I send it, but I'd appreciate > any early feedback ;-) > > the code is in here: > git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git > inode_build_id > > I'll send another version with inode if there's no objection I'll take a look. Thanks, Namhyung > > > > [1] https://lore.kernel.org/bpf/20221108222027.3409437-1-jolsa@kernel.org/ > > [2] https://lore.kernel.org/bpf/20221128132915.141211-1-jolsa@kernel.org/ > > [3] https://lore.kernel.org/bpf/CAEf4BzaZCUoxN_X2ALXwQeFTCwtL17R4P_B_-hUCcidfyO2xyQ@mail.gmail.com/ > > --- > > Jiri Olsa (5): > > mm: Store build id in file object > > bpf: Use file object build id in stackmap > > perf: Use file object build id in perf_event_mmap_event > > selftests/bpf: Add file_build_id test > > selftests/bpf: Add iter_task_vma_buildid test > > > > fs/file_table.c | 3 +++ > > include/linux/buildid.h | 17 +++++++++++++++++ > > include/linux/fs.h | 3 +++ > > kernel/bpf/stackmap.c | 8 ++++++++ > > kernel/events/core.c | 43 +++++++++++++++++++++++++++++++++++++++---- > > lib/buildid.c | 44 ++++++++++++++++++++++++++++++++++++++++++++ > > mm/Kconfig | 7 +++++++ > > mm/mmap.c | 15 +++++++++++++++ > > tools/testing/selftests/bpf/prog_tests/bpf_iter.c | 88 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > tools/testing/selftests/bpf/prog_tests/file_build_id.c | 70 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > tools/testing/selftests/bpf/progs/bpf_iter_task_vma_buildid.c | 49 +++++++++++++++++++++++++++++++++++++++++++++++++ > > tools/testing/selftests/bpf/progs/file_build_id.c | 34 ++++++++++++++++++++++++++++++++++ > > tools/testing/selftests/bpf/trace_helpers.c | 35 +++++++++++++++++++++++++++++++++++ > > tools/testing/selftests/bpf/trace_helpers.h | 1 + > > 14 files changed, 413 insertions(+), 4 deletions(-) > > create mode 100644 tools/testing/selftests/bpf/prog_tests/file_build_id.c > > create mode 100644 tools/testing/selftests/bpf/progs/bpf_iter_task_vma_buildid.c > > create mode 100644 tools/testing/selftests/bpf/progs/file_build_id.c