From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DBD7C19F21 for ; Wed, 27 Jul 2022 05:20:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 78F7B6B0071; Wed, 27 Jul 2022 01:20:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 718288E0001; Wed, 27 Jul 2022 01:20:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 591796B0073; Wed, 27 Jul 2022 01:20:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 394906B0071 for ; Wed, 27 Jul 2022 01:20:08 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id EB5C71A0B52 for ; Wed, 27 Jul 2022 05:20:07 +0000 (UTC) X-FDA: 79731728454.30.8E84D4A Received: from mail-yw1-f177.google.com (mail-yw1-f177.google.com [209.85.128.177]) by imf31.hostedemail.com (Postfix) with ESMTP id 955A920007 for ; Wed, 27 Jul 2022 05:20:07 +0000 (UTC) Received: by mail-yw1-f177.google.com with SMTP id 00721157ae682-31f56c42ab5so27475247b3.10 for ; Tue, 26 Jul 2022 22:20:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=e1XaWllZ4VWSveoLSOzRoa564aJjg0+qopyBxzu00FY=; b=QsFXqQa2VT6MewzWLDl1p7LqWLp/GZjqMN5nIwW0W6SPQFQwiK3DdfS40mVVtTda7k 6CYbPEyF1wteuz4TzLFwXyBzsVQF0Rpr9GOr7BTxvO4a28VUQpgKFGQm49VrdlGrH5nN gg6i2chrLsMYY2l7Zs2LIx8fY3r+AAFCLVxhOzX8xvROOj9Fx+ymHrQWDR4f/ZS/5uwn ph+2eAqslL/SwmrWVkI1bGNMGSq2V9I5DHWajwJ4AIArkSSMn6TncTIQJmTMR9fgnguR OpKd/BXR3fJUUiTRMuyBy21YkeeFuVmNYT6F5FZpiJJbDsJMqmZVgig2BXSX9CNcmVz4 HWeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=e1XaWllZ4VWSveoLSOzRoa564aJjg0+qopyBxzu00FY=; b=B+lS8NdagLwvcY9zQClHBp1fhwZ+MXW2K2qaD0ukrlYRsdQm6huxYm5IKBhB/uuT4q J3EOJ1QlUave656f6GyampDR2MDxIReuFBVcqgRoRmDppV7nI0znivYGXwsy/ojspCdJ 3PoRsPJVvYQSj+oJQkiMH5ihFJzaqEBsp+VgglGJcjy8rgp8s7M8LWe7B810DyW/+Yk1 kZHcXuSaPLU1qiyMLGtjQm1w5kWrwgMqtbFcfBGOo/GlaxfOp5IkxdvKR1MTFOEN5FOv r564XmRiwUV+ky4LqQ2LY5HPIUFMsmM9NrzvlZ9yKcn6GZJnab7RJPSdVxOVvi7B3R8R MU2Q== X-Gm-Message-State: AJIora8GwEAEl9QpnFTuSe4jQmUMXyQxhvqfcw11I8lECCOafjCWkHRe iTOgokWolV2L5FDy/3+O/ZxPEPP+7eH9KzaiARc= X-Google-Smtp-Source: AGRyM1t+dYFVbS4kNLO07ivSV2tGuNi9LrX6P+qozwdKPT5IOrVEFjBt5nHfYpnsT9o6aQhfUg21WAhvZ/JdBpY33xU= X-Received: by 2002:a0d:cb03:0:b0:31f:49a2:3470 with SMTP id n3-20020a0dcb03000000b0031f49a23470mr5466300ywd.386.1658899206837; Tue, 26 Jul 2022 22:20:06 -0700 (PDT) MIME-Version: 1.0 References: <20220726131135.146912-1-wangkefeng.wang@huawei.com> In-Reply-To: <20220726131135.146912-1-wangkefeng.wang@huawei.com> From: Pankaj Gupta Date: Wed, 27 Jul 2022 07:19:56 +0200 Message-ID: Subject: Re: [PATCH] mm: use is_zone_movable_page() helper To: Kefeng Wang Cc: David Hildenbrand , Oscar Salvador , Andrew Morton , Linux MM , Jason Wang , "Michael S. Tsirkin" , LKML Content-Type: text/plain; charset="UTF-8" ARC-Authentication-Results: i=1; imf31.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=QsFXqQa2; spf=pass (imf31.hostedemail.com: domain of pankaj.gupta.linux@gmail.com designates 209.85.128.177 as permitted sender) smtp.mailfrom=pankaj.gupta.linux@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1658899207; a=rsa-sha256; cv=none; b=ZLHDBs1AofQ5vcdyH82MHVOdINaBNqQwRtGCRD8unQos/W/lQqNFZPKNxSFj2XC8j3iakK PYIYXrd8wVM4JnqfsMZPRtipRwTcFsavPY5D0WpGToTrASfMmphGGwSha5loYtHGs/BS1i h4shbXFdejSYSAfTWI8lan/7sS+GjWM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1658899207; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=e1XaWllZ4VWSveoLSOzRoa564aJjg0+qopyBxzu00FY=; b=ZITm7rvoD8dd5YtcSlN9gJW6dRRFnjizEMV0y7TOb90QKxnJTLJSlhNxRGfz8aTIWUhu3D RxFQTNYTfYpywWNDF3X0jedu8mQIO2CcXpkkt60hGYrHufTdba4oEdaVTFr7X97qJOEN98 +/P9jgXlY7TOGN2qWxJRGZWPCwxzSeQ= Authentication-Results: imf31.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=QsFXqQa2; spf=pass (imf31.hostedemail.com: domain of pankaj.gupta.linux@gmail.com designates 209.85.128.177 as permitted sender) smtp.mailfrom=pankaj.gupta.linux@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspam-User: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 955A920007 X-Stat-Signature: eamiy6aqwgwwkjmojkgfkk1w8ds4wr61 X-HE-Tag: 1658899207-322774 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > Use is_zone_movable_page() helper to simplify code. > > Signed-off-by: Kefeng Wang > --- > drivers/virtio/virtio_mem.c | 6 ++---- > mm/memory_hotplug.c | 2 +- > 2 files changed, 3 insertions(+), 5 deletions(-) > > diff --git a/drivers/virtio/virtio_mem.c b/drivers/virtio/virtio_mem.c > index e07486f01999..0c2892ec6817 100644 > --- a/drivers/virtio/virtio_mem.c > +++ b/drivers/virtio/virtio_mem.c > @@ -862,8 +862,7 @@ static void virtio_mem_sbm_notify_online(struct virtio_mem *vm, > unsigned long mb_id, > unsigned long start_pfn) > { > - const bool is_movable = page_zonenum(pfn_to_page(start_pfn)) == > - ZONE_MOVABLE; > + const bool is_movable = is_zone_movable_page(pfn_to_page(start_pfn)); > int new_state; > > switch (virtio_mem_sbm_get_mb_state(vm, mb_id)) { > @@ -1158,8 +1157,7 @@ static void virtio_mem_fake_online(unsigned long pfn, unsigned long nr_pages) > */ > static int virtio_mem_fake_offline(unsigned long pfn, unsigned long nr_pages) > { > - const bool is_movable = page_zonenum(pfn_to_page(pfn)) == > - ZONE_MOVABLE; > + const bool is_movable = is_zone_movable_page(pfn_to_page(pfn)); > int rc, retry_count; > > /* > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index 1213d0c67a53..0f5914964a32 100644 > --- a/mm/memory_hotplug.c > +++ b/mm/memory_hotplug.c > @@ -936,7 +936,7 @@ static struct zone *auto_movable_zone_for_pfn(int nid, > if (!page) > continue; > /* If anything is !MOVABLE online the rest !MOVABLE. */ > - if (page_zonenum(page) != ZONE_MOVABLE) > + if (!is_zone_movable_page(page)) > goto kernel_zone; > online_pages += PAGES_PER_SECTION; > } Reviewed-by: Pankaj Gupta