From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14F14C433E0 for ; Sat, 30 May 2020 07:08:58 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 96BBA2075A for ; Sat, 30 May 2020 07:08:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YKQz3Imw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 96BBA2075A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id F2AB180009; Sat, 30 May 2020 03:08:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EDB3C80008; Sat, 30 May 2020 03:08:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DF00380009; Sat, 30 May 2020 03:08:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0148.hostedemail.com [216.40.44.148]) by kanga.kvack.org (Postfix) with ESMTP id C829B80008 for ; Sat, 30 May 2020 03:08:56 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 80CC7824556B for ; Sat, 30 May 2020 07:08:56 +0000 (UTC) X-FDA: 76872508272.22.mind15_4e02253773513 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin22.hostedemail.com (Postfix) with ESMTP id 6275718038E67 for ; Sat, 30 May 2020 07:08:56 +0000 (UTC) X-HE-Tag: mind15_4e02253773513 X-Filterd-Recvd-Size: 4874 Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by imf12.hostedemail.com (Postfix) with ESMTP for ; Sat, 30 May 2020 07:08:55 +0000 (UTC) Received: by mail-wr1-f68.google.com with SMTP id e1so6332535wrt.5 for ; Sat, 30 May 2020 00:08:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=O8BduaMh4UecgYnKme0JNCRgXH5vtivBSGRZ1LWNJ6k=; b=YKQz3Imw2HUvSXG0Dil+E+Uao1qIQuKEM9/MoSk0zq1sa5IyZ1GdRra670H2DTOPGl mrCaVRK/CG3oRk1JCpQih530qatB9/MMAihyiFbhmZ/YRDg1FjVdHGAsgbq6MonailYA /7UXAY8gpublsRUlQpcEwyLMB8Bizd2eYUSTC3s7e+QFb37txYw87tuITFbi7ljlgjfl RfTD45Jsqzk1gfGbifOKeCb+hhU4iDcSsfB5eC3jKDumOjbT2/Nm7EAimlGWdl5VHJ0U y20OgARcHo5xelhmtXATkXjFKANEwCKgKfD5XyHxYPCLRSyvob7n1rfmYWU5Wmy5fXE8 EynA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=O8BduaMh4UecgYnKme0JNCRgXH5vtivBSGRZ1LWNJ6k=; b=qyot4TtuvNg53o5vtyHwUND9yYWtuNk/aTsGpRRble/O6l5HtR8ZbdUhWiPEYuBRVT OcFvty43ITep3s8sFuR/94sDiS3TGorK56A15/9Nb6xCFfFl0/GeoIpJxXbjwiMoMrJA 74FZMjEmqPqd2lVSvdDJPUBZIU5jfUd8bX5LA+t8mBr7ODpsKtJpUsNmOctJv/jN8cra xY1a5K+pl/cRLC91pt3HP4MME8bHZGp/OYufbbNGNHB9cTpTxcpO5NJyzr19t7Ztgc/U y95CHYssdnV2MDQXSIGP5UEIhI9E+y6GnYZ6aid/qtfRgqHT/nTQnBV34l8krI/Tg7yB cbkw== X-Gm-Message-State: AOAM5313+03ic6m5DivryanmWUBM/i2gybfwP728ehWnKDppz3GOXjHh UaGyfk86vMNTABzA2n3bZc9ZV/qDiU21yOGPZrw= X-Google-Smtp-Source: ABdhPJyA44wyL2GXsxrDDw/3EXNIzjH9L/hV4blJi+2hohhTdxTOG29oKXHuKMUEGfYehxWHBY91khTZJwOgXF9s0f8= X-Received: by 2002:adf:ec45:: with SMTP id w5mr12572901wrn.96.1590822534798; Sat, 30 May 2020 00:08:54 -0700 (PDT) MIME-Version: 1.0 References: <1590817116-21281-1-git-send-email-wetp.zy@linux.alibaba.com> In-Reply-To: <1590817116-21281-1-git-send-email-wetp.zy@linux.alibaba.com> From: Pankaj Gupta Date: Sat, 30 May 2020 09:08:43 +0200 Message-ID: Subject: Re: [PATCH V2] mm, memory_failure: don't send BUS_MCEERR_AO for action required error To: Wetp Zhang Cc: n-horiguchi@ah.jp.nec.com, naoya.horiguchi@nec.com, Andrew Morton , Linux MM , LKML Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 6275718038E67 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > Some processes dont't want to be killed early, but in "Action Required" > case, those also may be killed by BUS_MCEERR_AO when sharing memory > with other which is accessing the fail memory. > And sending SIGBUS with BUS_MCEERR_AO for action required error is > strange, so ignore the non-current processes here. > > Suggested-by: Naoya Horiguchi > Signed-off-by: Wetp Zhang > --- > mm/memory-failure.c | 15 +++++++++------ > 1 file changed, 9 insertions(+), 6 deletions(-) > > diff --git a/mm/memory-failure.c b/mm/memory-failure.c > index a96364be8ab4..dd3862fcf2e9 100644 > --- a/mm/memory-failure.c > +++ b/mm/memory-failure.c > @@ -210,14 +210,17 @@ static int kill_proc(struct to_kill *tk, unsigned long pfn, int flags) > { > struct task_struct *t = tk->tsk; > short addr_lsb = tk->size_shift; > - int ret; > + int ret = 0; > > - pr_err("Memory failure: %#lx: Sending SIGBUS to %s:%d due to hardware memory corruption\n", > - pfn, t->comm, t->pid); > + if ((t->mm == current->mm) || !(flags & MF_ACTION_REQUIRED)) > + pr_err("Memory failure: %#lx: Sending SIGBUS to %s:%d due to hardware memory corruption\n", > + pfn, t->comm, t->pid); Maybe we can generalize the message condition for better readability. Thought a bit but did not get any other idea. > > - if ((flags & MF_ACTION_REQUIRED) && t->mm == current->mm) { > - ret = force_sig_mceerr(BUS_MCEERR_AR, (void __user *)tk->addr, > - addr_lsb); > + if (flags & MF_ACTION_REQUIRED) { > + if (t->mm == current->mm) > + ret = force_sig_mceerr(BUS_MCEERR_AR, > + (void __user *)tk->addr, addr_lsb); > + /* send no signal to non-current processes */ > } else { > /* > * Don't use force here, it's convenient if the signal > -- Looks good to me. Acked-by: Pankaj Gupta