From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0175C12002 for ; Wed, 14 Jul 2021 20:41:46 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 93DDB613C1 for ; Wed, 14 Jul 2021 20:41:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 93DDB613C1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B3DEA6B0080; Wed, 14 Jul 2021 16:41:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AEE336B0081; Wed, 14 Jul 2021 16:41:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 967FA6B0083; Wed, 14 Jul 2021 16:41:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0072.hostedemail.com [216.40.44.72]) by kanga.kvack.org (Postfix) with ESMTP id 7224E6B0080 for ; Wed, 14 Jul 2021 16:41:46 -0400 (EDT) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 4E0BE184571EA for ; Wed, 14 Jul 2021 20:41:45 +0000 (UTC) X-FDA: 78362364570.15.3F5B754 Received: from mail-il1-f175.google.com (mail-il1-f175.google.com [209.85.166.175]) by imf16.hostedemail.com (Postfix) with ESMTP id 0E109F000099 for ; Wed, 14 Jul 2021 20:41:44 +0000 (UTC) Received: by mail-il1-f175.google.com with SMTP id j5so2915767ilk.3 for ; Wed, 14 Jul 2021 13:41:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dqcSJ3+RdO5AVQF2XIn7OGZkaQyuAY3R+z4rvhGNyD4=; b=pQFLoNaGNyjMVOXUkwfQkEuNRkOc+zygrTlctP5bdT4McvO6Ng4hwvedqUBVQUAkqs wPtowxZDjSKq+yFESIb64yRfq5QLOkJeWEJIwxxbS3HGpJ7k+koBAXbYMYBM4k1jYjB3 GsMCfzBHy5/sr6Bxyf84y4zVzXDAWxCKMfxKpzPTMIYJrKlYiWllALzshoMt++Pd+585 TCgf3rf6QwtRbvM6dXmd6Zxq2nkp//FnnHM+Uq26FcXwqLtTy9zJFJbtZxvkgSNaR6YT UaJavclTVfamQ9KqM6AE4kU0FGN1C2933QfUQ2Bxk8kRlOzwMkCpcAFg1MRfozFmTJME q8ZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dqcSJ3+RdO5AVQF2XIn7OGZkaQyuAY3R+z4rvhGNyD4=; b=LBVu9tjLhGj/QdAbvlCkGOdro5Q7uVzt9keNinLFe//3kqABlCUtypId0qJ9idnb4Q jLBHtcx7CBiINmYJ/XA46vzHDr/TlCFQ4Mqahs/3GKho2bCQDJqNuN5NUDiQbKQADGOs ApL2kIa+9dKtbOWS6Lme0uvAgWzBNJCxqv9uSRGczDizqJTF2pENFEMiUsx3R5RnLo9o eqSk3r22t/qWroXhCi3FKCs2yGu6/RN5APEK47R2N5lTQSEE/RY9pyvgkomcc76bJ8h8 CNdRPqNFo/vNUhstxi2YNjixLwRrs0irbC8zP+9Iq/uWgVFgqM1Ls8zAaiTEONYslgwJ abaw== X-Gm-Message-State: AOAM530HDuU6k6ixZlyGSmImCCWbThRVZNqHmGhSquCsQu+jcSk7SZwT TvB2kBGzpmWCIs5jYPWsd2yJq+2lOvRqnamQs24= X-Google-Smtp-Source: ABdhPJzO7STrjt80s023NvMYhE0SPvgFGt3L4pny0yb79MK4xbAu75rcqNQ2debzSFJu5KmuzIqVn7PveRA96RL/IS4= X-Received: by 2002:a92:a005:: with SMTP id e5mr7701226ili.22.1626295304242; Wed, 14 Jul 2021 13:41:44 -0700 (PDT) MIME-Version: 1.0 References: <20210712124052.26491-1-david@redhat.com> <20210712124052.26491-2-david@redhat.com> In-Reply-To: <20210712124052.26491-2-david@redhat.com> From: Pankaj Gupta Date: Wed, 14 Jul 2021 22:41:33 +0200 Message-ID: Subject: Re: [PATCH v1 1/4] mm/memory_hotplug: use "unsigned long" for PFN in zone_for_pfn_range() To: David Hildenbrand Cc: LKML , Linux MM , Andrew Morton , Vitaly Kuznetsov , "Michael S. Tsirkin" , Jason Wang , Wei Yang , Oscar Salvador , Michal Hocko , Dan Williams , Anshuman Khandual , Dave Hansen , Vlastimil Babka , Mike Rapoport , "Rafael J. Wysocki" , Len Brown , Pavel Tatashin , Heiko Carstens , Michael Ellerman , Catalin Marinas , virtualization@lists.linux-foundation.org, linux-acpi@vger.kernel.org, Andy Lutomirski , "Aneesh Kumar K.V" , Anton Blanchard , Ard Biesheuvel , Baoquan He , Benjamin Herrenschmidt , Borislav Petkov , Christian Borntraeger , Christophe Leroy , Dave Jiang , "H. Peter Anvin" , Ingo Molnar , Jia He , Joe Perches , Kefeng Wang , Laurent Dufour , Michel Lespinasse , Nathan Lynch , Nicholas Piggin , Paul Mackerras , Peter Zijlstra , Pierre Morel , "Rafael J. Wysocki" , Rich Felker , Scott Cheloha , Sergei Trofimovich , Thiago Jung Bauermann , Thomas Gleixner , Vasily Gorbik , Vishal Verma , Will Deacon , Yoshinori Sato Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=pQFLoNaG; spf=pass (imf16.hostedemail.com: domain of pankajguptalinux@gmail.com designates 209.85.166.175 as permitted sender) smtp.mailfrom=pankajguptalinux@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Stat-Signature: htk8i3yfaykanmw19pqneowzo17aioz9 X-Rspamd-Queue-Id: 0E109F000099 X-Rspamd-Server: rspam01 X-HE-Tag: 1626295304-414482 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > Checkpatch complained on a follow-up patch that we are using "unsigned" > here, which defaults to "unsigned int" and checkpatch is correct. > > Use "unsigned long" instead, just as we do in other places when handling > PFNs. This can bite us once we have physical addresses in the range of > multiple TB. > > Fixes: e5e689302633 ("mm, memory_hotplug: display allowed zones in the preferred ordering") > Signed-off-by: David Hildenbrand > --- > include/linux/memory_hotplug.h | 4 ++-- > mm/memory_hotplug.c | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/include/linux/memory_hotplug.h b/include/linux/memory_hotplug.h > index a7fd2c3ccb77..d01b504ce06f 100644 > --- a/include/linux/memory_hotplug.h > +++ b/include/linux/memory_hotplug.h > @@ -339,8 +339,8 @@ extern void sparse_remove_section(struct mem_section *ms, > unsigned long map_offset, struct vmem_altmap *altmap); > extern struct page *sparse_decode_mem_map(unsigned long coded_mem_map, > unsigned long pnum); > -extern struct zone *zone_for_pfn_range(int online_type, int nid, unsigned start_pfn, > - unsigned long nr_pages); > +extern struct zone *zone_for_pfn_range(int online_type, int nid, > + unsigned long start_pfn, unsigned long nr_pages); > extern int arch_create_linear_mapping(int nid, u64 start, u64 size, > struct mhp_params *params); > void arch_remove_linear_mapping(u64 start, u64 size); > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index 8cb75b26ea4f..93b3abaf9828 100644 > --- a/mm/memory_hotplug.c > +++ b/mm/memory_hotplug.c > @@ -708,8 +708,8 @@ static inline struct zone *default_zone_for_pfn(int nid, unsigned long start_pfn > return movable_node_enabled ? movable_zone : kernel_zone; > } > > -struct zone *zone_for_pfn_range(int online_type, int nid, unsigned start_pfn, > - unsigned long nr_pages) > +struct zone *zone_for_pfn_range(int online_type, int nid, > + unsigned long start_pfn, unsigned long nr_pages) > { > if (online_type == MMOP_ONLINE_KERNEL) > return default_kernel_zone_for_pfn(nid, start_pfn, nr_pages); Reviewed-by: Pankaj Gupta