From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DCEEC433E0 for ; Sun, 21 Jun 2020 19:57:52 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1F39824804 for ; Sun, 21 Jun 2020 19:57:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WL8ZpLFi" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1F39824804 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C57618D002C; Sun, 21 Jun 2020 15:57:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BE0C58D001E; Sun, 21 Jun 2020 15:57:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AD0238D002C; Sun, 21 Jun 2020 15:57:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0124.hostedemail.com [216.40.44.124]) by kanga.kvack.org (Postfix) with ESMTP id 921BA8D001E for ; Sun, 21 Jun 2020 15:57:51 -0400 (EDT) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 46FF9824805A for ; Sun, 21 Jun 2020 19:57:51 +0000 (UTC) X-FDA: 76954279542.10.spoon75_52025ca26e2c Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin10.hostedemail.com (Postfix) with ESMTP id 21C8716A0AE for ; Sun, 21 Jun 2020 19:57:51 +0000 (UTC) X-HE-Tag: spoon75_52025ca26e2c X-Filterd-Recvd-Size: 5472 Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by imf19.hostedemail.com (Postfix) with ESMTP for ; Sun, 21 Jun 2020 19:57:50 +0000 (UTC) Received: by mail-wr1-f67.google.com with SMTP id h5so14620587wrc.7 for ; Sun, 21 Jun 2020 12:57:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=xVtO0mf5+18xL2wyRUh4C8eKDbifEpFUpjq+V/g/lJQ=; b=WL8ZpLFio6q8DFXdiT+zwbQD5AaPUNF0d+V8V4EXXgRu9kOUgdjhUqKXOLfdnVqM5v 6Z+Vguv3+SGBgKiQkGsxcYhWNzGBiPhm1iZlLsJv4ycKR4DMbATJ8OI/LNsZzn3RqMtX AndVH1BJHsu9Ej6bUXi423R2qOOA639VAXzUAQ36ZOHAQihALUuqNR9SWl3A8omsU63w t+8lEhoMcPsQWXlPWZ4LXtt+7vJOgTbYq6TRhDeSx1b2uX0Z7K6Phk8I4GftIme3wCHg O/g+cnQNqYmAry/H0r9ZzR3kQx6d8XQ1SebUXBb3mE6UUVclOghiVXrAVQ+C/pKbwzhX Z5QQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xVtO0mf5+18xL2wyRUh4C8eKDbifEpFUpjq+V/g/lJQ=; b=K6MgDVSfiVN6UnCIGottDTlhoMpt9ebcl4uVyHGbvyDfxgOEvPrO5G+YSjWIuLJ3b0 md0xyw2uN4oXvnvQOZUkaOsNWmMsBHelVRRE8XdGPfcSmTv3cW3Q/dcD8bPNvezxcGon LVZ5aBLoHJt0cSPRDI4Xy9J+SGt5k0oGk1axfRtj2sROPo39SlQaHVnXTi+L2P6amHhj nVdiJ9RvbXBPMiQqZ/oSwd7PAEgmGYKu2HynFe/cEFjaj2DPuK1UQ0ZS5enqevfPUCM/ M5XoPemP7dRXfraBRfq70NK7Gi4ToCvJHhc8KLCUePvNlOQ+8c5AnV+WgzTv2nqgemey twoA== X-Gm-Message-State: AOAM533NDMQfGwdb1aei8Np/HjxD68mpi4jBfaW+KbsOxQYU7cfJ1JFq jQZj5Uqx2vrfH/c7htbgi0jGAs8vBbwxeqhnGT8= X-Google-Smtp-Source: ABdhPJwZyTYwNoOwTrFxeUfjkqvqeKiAhlF+F7UYGS9p4EeqwhWfVZaDY8nYXJLazazVAeLPyEFYjHUBXWeDJt+MHCg= X-Received: by 2002:adf:93e3:: with SMTP id 90mr15331654wrp.298.1592769469774; Sun, 21 Jun 2020 12:57:49 -0700 (PDT) MIME-Version: 1.0 References: <20200619132410.23859-1-david@redhat.com> <20200619132410.23859-3-david@redhat.com> In-Reply-To: <20200619132410.23859-3-david@redhat.com> From: Pankaj Gupta Date: Sun, 21 Jun 2020 21:57:38 +0200 Message-ID: Subject: Re: [PATCH v1 2/2] mm/page_alloc: drop nr_free_pagecache_pages() To: David Hildenbrand Cc: LKML , Linux MM , Andrew Morton , Johannes Weiner , Michal Hocko , Minchan Kim , Huang Ying , Wei Yang Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 21C8716A0AE X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > nr_free_pagecache_pages() isn't used outside page_alloc.c anymore - and > the name does not really help to understand what's going on. Let's inline > it instead and add a comment. > > Cc: Andrew Morton > Cc: Johannes Weiner > Cc: Michal Hocko > Cc: Minchan Kim > Cc: Huang Ying > Cc: Wei Yang > Signed-off-by: David Hildenbrand > --- > include/linux/swap.h | 1 - > mm/page_alloc.c | 16 ++-------------- > 2 files changed, 2 insertions(+), 15 deletions(-) > > diff --git a/include/linux/swap.h b/include/linux/swap.h > index 124261acd5d0a..9bde6c6b2c045 100644 > --- a/include/linux/swap.h > +++ b/include/linux/swap.h > @@ -327,7 +327,6 @@ void workingset_update_node(struct xa_node *node); > /* linux/mm/page_alloc.c */ > extern unsigned long totalreserve_pages; > extern unsigned long nr_free_buffer_pages(void); > -extern unsigned long nr_free_pagecache_pages(void); > > /* Definition of global_zone_page_state not available yet */ > #define nr_free_pages() global_zone_page_state(NR_FREE_PAGES) > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 7b0dde69748c1..c38903d1b3b4d 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -5177,19 +5177,6 @@ unsigned long nr_free_buffer_pages(void) > } > EXPORT_SYMBOL_GPL(nr_free_buffer_pages); > > -/** > - * nr_free_pagecache_pages - count number of pages beyond high watermark > - * > - * nr_free_pagecache_pages() counts the number of pages which are beyond the > - * high watermark within all zones. > - * > - * Return: number of pages beyond high watermark within all zones. > - */ > -unsigned long nr_free_pagecache_pages(void) > -{ > - return nr_free_zone_pages(gfp_zone(GFP_HIGHUSER_MOVABLE)); > -} > - > static inline void show_node(struct zone *zone) > { > if (IS_ENABLED(CONFIG_NUMA)) > @@ -5911,7 +5898,8 @@ void __ref build_all_zonelists(pg_data_t *pgdat) > __build_all_zonelists(pgdat); > /* cpuset refresh routine should be here */ > } > - vm_total_pages = nr_free_pagecache_pages(); > + /* Get the number of free pages beyond high watermark in all zones. */ > + vm_total_pages = nr_free_zone_pages(gfp_zone(GFP_HIGHUSER_MOVABLE)); > /* > * Disable grouping by mobility if the number of pages in the > * system is too low to allow the mechanism to work. It would be Reviewed-by: Pankaj Gupta