From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45B51C433DF for ; Thu, 30 Jul 2020 04:31:14 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DB57022B43 for ; Thu, 30 Jul 2020 04:31:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="rCTc8xvg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DB57022B43 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 39DB56B0008; Thu, 30 Jul 2020 00:31:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 34CE46B000A; Thu, 30 Jul 2020 00:31:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 23C876B000C; Thu, 30 Jul 2020 00:31:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0158.hostedemail.com [216.40.44.158]) by kanga.kvack.org (Postfix) with ESMTP id 158806B0008 for ; Thu, 30 Jul 2020 00:31:13 -0400 (EDT) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id A6F4E8248D51 for ; Thu, 30 Jul 2020 04:31:12 +0000 (UTC) X-FDA: 77093467584.26.flesh20_0a17d1026f78 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin26.hostedemail.com (Postfix) with ESMTP id 823121804A32C for ; Thu, 30 Jul 2020 04:31:12 +0000 (UTC) X-HE-Tag: flesh20_0a17d1026f78 X-Filterd-Recvd-Size: 4933 Received: from mail-il1-f193.google.com (mail-il1-f193.google.com [209.85.166.193]) by imf41.hostedemail.com (Postfix) with ESMTP for ; Thu, 30 Jul 2020 04:31:12 +0000 (UTC) Received: by mail-il1-f193.google.com with SMTP id b18so16191574ilo.12 for ; Wed, 29 Jul 2020 21:31:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=K8IWClMf+Ao4pEqXoB9q668049Xra3AgdP5q2Ybi4E0=; b=rCTc8xvgE9Ui97ENvy7ojAC5zhzBo56lHoEpYw8H7EUHC+JPaBfIbyGZ5nwC2FrYXk JehpEw6CYfgWp+fSumr4EfDjvXv1y51KnUMbbsvz0lrrCugYsh9dXr5Ud+tpElv2RfiI plP+lyZa6iPkzc2GTh3DxSW0B9xeFpAkwcJXK48OiF6XhUfAz9FyXiyFG2j7WAhdx5mZ AA2CJOnhBxi7QKS9w37F+n2AlK2i/jqc9q1B3Nw3QOdSweM1NyqFWJPyrd/Gmgd+J4MP 4QKE1hDuIEDwcMj9eGWdGU4mrhXRO+ml006SJPd2H/d6S2xB+ox9tMVNHpzihUfeyS7e t0oA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=K8IWClMf+Ao4pEqXoB9q668049Xra3AgdP5q2Ybi4E0=; b=P2yy8xeUKBJ2nPQcTVF2HgwoaWpr0uY5XXqger8KCkHsxTpW9pwnn2jn+bFDUc6FJo L6+m4eq47ArFvmm8OKjGjieEmNXJ5Zr2a0kqJ9n32DQ7brytkTUEK8U5Y0VSXYfY+gEK sZ883u/30NO0aGmCpKZuS9pBezhKykK5fq3ka6RC1TIu9hr72J6TEI8tgfb9Puj17f9Y kHbTJs7GTwWUaWvO+YgUCdKA2TCA56hsMZ3DEHnzlTfD7FgKUeHufvRyPk8dFHV5ODPb HVZpauinR7CpKKeHX4fvJfXDcxqre3LB/hzogXo+eN6aSFcwqRpFpZIVUQfdx1SJY9tW vqDw== X-Gm-Message-State: AOAM530MEna7MKq9NNpeuw+faHn3YJas4sHEjxqlFUa/j7oGnBQFTZFw TZQzVj68ashd4cGLei5DBS1bG1m8sNjBuj93rXM= X-Google-Smtp-Source: ABdhPJydOlDtkkFQ7R5dCMPMhtBMULJz9VbqLkowKMQpkrafuAntcCxNQaR4Ib8wrP396W86AK02AU1tIJ//znQ0jSc= X-Received: by 2002:a92:ce09:: with SMTP id b9mr15888272ilo.143.1596083471618; Wed, 29 Jul 2020 21:31:11 -0700 (PDT) MIME-Version: 1.0 References: <20200630142639.22770-1-david@redhat.com> <20200630142639.22770-5-david@redhat.com> In-Reply-To: <20200630142639.22770-5-david@redhat.com> From: Pankaj Gupta Date: Thu, 30 Jul 2020 06:31:00 +0200 Message-ID: Subject: Re: [PATCH v1 4/6] mm/page_isolation: cleanup set_migratetype_isolate() To: David Hildenbrand Cc: LKML , virtualization@lists.linux-foundation.org, Linux MM , Andrew Morton , Michal Hocko , "Michael S . Tsirkin" Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 823121804A32C X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > Let's clean it up a bit, simplifying error handling and getting rid of > the label. > > Cc: Andrew Morton > Cc: Michal Hocko > Cc: Michael S. Tsirkin > Signed-off-by: David Hildenbrand > --- > mm/page_isolation.c | 18 +++++++----------- > 1 file changed, 7 insertions(+), 11 deletions(-) > > diff --git a/mm/page_isolation.c b/mm/page_isolation.c > index 02a01bff6b219..5f869bef23fa4 100644 > --- a/mm/page_isolation.c > +++ b/mm/page_isolation.c > @@ -17,12 +17,9 @@ > > static int set_migratetype_isolate(struct page *page, int migratetype, int isol_flags) > { > - struct page *unmovable = NULL; > - struct zone *zone; > + struct zone *zone = page_zone(page); > + struct page *unmovable; > unsigned long flags; > - int ret = -EBUSY; > - > - zone = page_zone(page); > > spin_lock_irqsave(&zone->lock, flags); > > @@ -51,21 +48,20 @@ static int set_migratetype_isolate(struct page *page, int migratetype, int isol_ > NULL); > > __mod_zone_freepage_state(zone, -nr_pages, mt); > - ret = 0; > + spin_unlock_irqrestore(&zone->lock, flags); > + drain_all_pages(zone); > + return 0; > } > > -out: > spin_unlock_irqrestore(&zone->lock, flags); > - if (!ret) { > - drain_all_pages(zone); > - } else if ((isol_flags & REPORT_FAILURE) && unmovable) > + if (isol_flags & REPORT_FAILURE) > /* > * printk() with zone->lock held will likely trigger a > * lockdep splat, so defer it here. > */ > dump_page(unmovable, "unmovable page"); > > - return ret; > + return -EBUSY; > } > > static void unset_migratetype_isolate(struct page *page, unsigned migratetype) > -- This clean up looks good to me. Reviewed-by: Pankaj Gupta > 2.26.2 > >