From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7411C55ABD for ; Fri, 13 Nov 2020 15:14:41 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 60A4322277 for ; Fri, 13 Nov 2020 15:14:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TyE5LDer" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 60A4322277 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id CD1C76B005C; Fri, 13 Nov 2020 10:14:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C80C66B005D; Fri, 13 Nov 2020 10:14:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B6F956B0068; Fri, 13 Nov 2020 10:14:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 7F5AB6B005C for ; Fri, 13 Nov 2020 10:14:40 -0500 (EST) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 05B76362C for ; Fri, 13 Nov 2020 15:14:40 +0000 (UTC) X-FDA: 77479741920.21.girls86_050fa9127310 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin21.hostedemail.com (Postfix) with ESMTP id D967C180442C2 for ; Fri, 13 Nov 2020 15:14:39 +0000 (UTC) X-HE-Tag: girls86_050fa9127310 X-Filterd-Recvd-Size: 4571 Received: from mail-il1-f193.google.com (mail-il1-f193.google.com [209.85.166.193]) by imf20.hostedemail.com (Postfix) with ESMTP for ; Fri, 13 Nov 2020 15:14:39 +0000 (UTC) Received: by mail-il1-f193.google.com with SMTP id h6so5126804ilj.8 for ; Fri, 13 Nov 2020 07:14:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=b8tmgLVe0QVnnIRjLRBTov7jcTK3VR1uLeyQMoPGugs=; b=TyE5LDersmfncx6i1WEQ31JdjIPHQJ2uJUiW5Q/Ew6uOFY9QD39kvdSniaQuYTyKyn r+U9o7ctv2+wydyugdx8uMeSags326bUTrTwfLaD3wBSc3nff6DqYJ9Mq0HdhB8kHBG1 HkOCjesKHeSVWPpmTKSo9DA/YgbLv3pc42XVt/tZEIATqWgzuY+vnKZPZHR5eEIig7t2 /91WlHLfUYdtThpHQbm7kjpGDivgtF7Z1T0a07gFn3v/VlXzCu0pTEJGiH5JvlAm1g61 RUE5uEH+5CoCfXRuVF3pqR8Iln8+y952JTg7unsoUFdDELQsqXo0Im7qv665vx9Xn/gy mJyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=b8tmgLVe0QVnnIRjLRBTov7jcTK3VR1uLeyQMoPGugs=; b=LJcAwJ0mXfappJto3bHKcdiJMz6trCpNBiMQQFYHiscLb+ClWSQPftfyw5uVnOJVQN BnGs5xiYaRrAqveu9B19sh4cTDr05T5s9lgHTUWCWULcqx75Ij9hfFTkOb7ZlFbr8OC4 UbwFWHQHOU8UaYb+v69hDw4tYwgwSi1uDycj8MROSIew45fErAiQutNhSEQn9bhBwfh3 yBqcDmyDLrDEMVGo9D2nNWen/lZ2pwgoBzkLefvVFiu8eY7txVhcourdcZ96dn3Wme1M +jNLa1NgOv/tiJj1sSyBVE6dkeLqwM69srpcYYTBMTaaqNBtVpCb/szYqUCXAtgjxJl7 M10A== X-Gm-Message-State: AOAM533VRgQI+vpV+sFGHhOi1BeL8nW33cfuR4ZQ+OFmh3LzmVoCl+nM GN0tHGVtPxrR3fRc9DIJgqLaSzkuMWLBWiPzkC4= X-Google-Smtp-Source: ABdhPJxQV4da3rxcBfVIBeHEkfu8gz4/gtZofefwV1S5OTVXHEoanPrftTn0wZeOOa+3Nyv/nVwXdSrnfYhU6pEvtZw= X-Received: by 2002:a05:6e02:ca3:: with SMTP id 3mr211397ilg.85.1605280478912; Fri, 13 Nov 2020 07:14:38 -0800 (PST) MIME-Version: 1.0 References: <20201113135427.GA167783@rlk> In-Reply-To: <20201113135427.GA167783@rlk> From: Pankaj Gupta Date: Fri, 13 Nov 2020 16:14:28 +0100 Message-ID: Subject: Re: [PATCH] mm/shmem.c: make shmem_mapping() inline To: Hui Su Cc: Hugh Dickins , Andrew Morton , Linux MM , LKML Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > inline the shmem_mapping(), and use shmem_mapping() > instead of 'inode->i_mapping->a_ops == &shmem_aops' > in shmem_evict_inode(). > > Signed-off-by: Hui Su > --- > include/linux/shmem_fs.h | 2 +- > mm/shmem.c | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/include/linux/shmem_fs.h b/include/linux/shmem_fs.h > index a5a5d1d4d7b1..154a16fe7fd5 100644 > --- a/include/linux/shmem_fs.h > +++ b/include/linux/shmem_fs.h > @@ -67,7 +67,7 @@ extern unsigned long shmem_get_unmapped_area(struct file *, unsigned long addr, > unsigned long len, unsigned long pgoff, unsigned long flags); > extern int shmem_lock(struct file *file, int lock, struct user_struct *user); > #ifdef CONFIG_SHMEM > -extern bool shmem_mapping(struct address_space *mapping); > +extern inline bool shmem_mapping(struct address_space *mapping); > #else > static inline bool shmem_mapping(struct address_space *mapping) > { > diff --git a/mm/shmem.c b/mm/shmem.c > index 537c137698f8..7395d8e8226a 100644 > --- a/mm/shmem.c > +++ b/mm/shmem.c > @@ -1152,7 +1152,7 @@ static void shmem_evict_inode(struct inode *inode) > struct shmem_inode_info *info = SHMEM_I(inode); > struct shmem_sb_info *sbinfo = SHMEM_SB(inode->i_sb); > > - if (inode->i_mapping->a_ops == &shmem_aops) { > + if (shmem_mapping(inode->i_mapping)) { > shmem_unacct_size(info->flags, inode->i_size); > inode->i_size = 0; > shmem_truncate_range(inode, 0, (loff_t)-1); > @@ -2352,7 +2352,7 @@ static struct inode *shmem_get_inode(struct super_block *sb, const struct inode > return inode; > } > > -bool shmem_mapping(struct address_space *mapping) > +inline bool shmem_mapping(struct address_space *mapping) > { > return mapping->a_ops == &shmem_aops; > } Reviewed-by: Pankaj Gupta