From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E7E7C43331 for ; Thu, 26 Mar 2020 07:20:01 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3E5D620714 for ; Thu, 26 Mar 2020 07:20:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BEpbLZ6X" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3E5D620714 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id DB1B16B0010; Thu, 26 Mar 2020 03:20:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D608E6B0032; Thu, 26 Mar 2020 03:20:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C9D176B0072; Thu, 26 Mar 2020 03:20:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0174.hostedemail.com [216.40.44.174]) by kanga.kvack.org (Postfix) with ESMTP id B372F6B0010 for ; Thu, 26 Mar 2020 03:20:00 -0400 (EDT) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id B7A6DF96 for ; Thu, 26 Mar 2020 07:20:00 +0000 (UTC) X-FDA: 76636664160.08.bone09_1d2b4c46ab121 X-HE-Tag: bone09_1d2b4c46ab121 X-Filterd-Recvd-Size: 4828 Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by imf35.hostedemail.com (Postfix) with ESMTP for ; Thu, 26 Mar 2020 07:20:00 +0000 (UTC) Received: by mail-wm1-f67.google.com with SMTP id g62so5821492wme.1 for ; Thu, 26 Mar 2020 00:19:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=udY4IxAu4+qBI0VVKoFSj5VQzPLtjOmL74dmx17lD1U=; b=BEpbLZ6XT3fHzXgdnVfXkTmNBXDa6UAEYn4FOV/LwqEXXg2tc6UbIV86xAZPGDiDrG 1de7vV2LABFiGVyHP74oIuuzNqY1SLzxkyOZEVs9AqFqhdhoCL6ePEpOahO3pWNjY6rD YuxfREhfec8qU9JviGWcdntXLrNVFBj6hQZdsAakbJFYT4buJOOZEwvlkBNW4cIjInLd vfYQRytF5Y056gU124I4U51o1Dbhoe6O/jPPhjRNN+KbCXgBNwB1oeypmknKitdRZxL0 rjtvwQncKst3+kgPdVubfMahgLp4wXYSC/QYoTFE+P3h53T/3C+aARhrdN9pBRKDKnmz Hjtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=udY4IxAu4+qBI0VVKoFSj5VQzPLtjOmL74dmx17lD1U=; b=Eg+CmAQj5ZDAjWj+O4F1fCPqbpZwpe3NQOziWV0Fj4KkAACgXncX/wBB0FWFm5NIYW rkQpK2TAmMuqYuoO+TQxgp9I9nZkarjXTm+lLOzqpkRZ1Gh4JlvOHPVtCFPu7OXe/uLn 92PkAcsc1KptkVGl6lhvvfwYsbaCy9b7PH+0XI3llqZfgactmQrTHxmjfziygmW4RjG4 dL7DQHSM5Y0LTW/DJx5qQ/2bAfFmVsC1f+gGftRPcARhUomzVwLTw/2ZVexpnbH6K2Rj PKPwWQySx2pfI5zFw9yPU+zEq1437M4MONdLK5RTvj6NQ2lX2qiFaIBtHXle7jACfu5A yxxg== X-Gm-Message-State: ANhLgQ2SPB5+bXhgQXBJ6HY91t381xSSqCSNqbYZ8dQdLUsbtxrXsTKy N2Vjc52N6MYGzJYuMb+LFIM7zqXSwvM2GUFM/0c= X-Google-Smtp-Source: ADFU+vvQEBhAU7ND16P7NOyZPA8RvhuFNLqp7LcJBtkXT/DY6/gdim+O/mf1U6mhyqA/FLaGt5G65FqLM4fapjkUyAg= X-Received: by 2002:a1c:5506:: with SMTP id j6mr1657330wmb.127.1585207198626; Thu, 26 Mar 2020 00:19:58 -0700 (PDT) MIME-Version: 1.0 References: <20200324201123.3118-1-thomas_os@shipmail.org> <20200324201123.3118-2-thomas_os@shipmail.org> In-Reply-To: <20200324201123.3118-2-thomas_os@shipmail.org> From: Pankaj Gupta Date: Thu, 26 Mar 2020 08:19:47 +0100 Message-ID: Subject: Re: [PATCH v7 1/9] fs: Constify vma argument to vma_is_dax To: =?UTF-8?Q?Thomas_Hellstr=C3=B6m_=28VMware=29?= Cc: linux-mm@kvack.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, pv-drivers@vmware.com, linux-graphics-maintainer@vmware.com, Andrew Morton , Michal Hocko , "Matthew Wilcox (Oracle)" , "Kirill A. Shutemov" , Ralph Campbell , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , =?UTF-8?Q?Christian_K=C3=B6nig?= , Dan Williams , Roland Scheidegger Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > From: "Thomas Hellstrom (VMware)" > > The function is used by upcoming vma_is_special_huge() with which we want > to use a const vma argument. Since for vma_is_dax() the vma argument is > only dereferenced for reading, constify it. > > Cc: Andrew Morton > Cc: Michal Hocko > Cc: "Matthew Wilcox (Oracle)" > Cc: "Kirill A. Shutemov" > Cc: Ralph Campbell > Cc: "J=C3=A9r=C3=B4me Glisse" > Cc: "Christian K=C3=B6nig" > Cc: Dan Williams > Signed-off-by: Thomas Hellstrom (VMware) > Reviewed-by: Roland Scheidegger > Acked-by: Christian K=C3=B6nig > --- > include/linux/fs.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/fs.h b/include/linux/fs.h > index 3cd4fe6b845e..2b38ce5b73ad 100644 > --- a/include/linux/fs.h > +++ b/include/linux/fs.h > @@ -3391,7 +3391,7 @@ static inline bool io_is_direct(struct file *filp) > return (filp->f_flags & O_DIRECT) || IS_DAX(filp->f_mapping->host= ); > } > > -static inline bool vma_is_dax(struct vm_area_struct *vma) > +static inline bool vma_is_dax(const struct vm_area_struct *vma) > { > return vma->vm_file && IS_DAX(vma->vm_file->f_mapping->host); > } > -- Acked-by: Pankaj Gupta > 2.21.1 > >