From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC868C2D0EF for ; Tue, 31 Mar 2020 06:53:57 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A2A9620748 for ; Tue, 31 Mar 2020 06:53:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pBq0Oh9X" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A2A9620748 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1FA326B0032; Tue, 31 Mar 2020 02:53:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1A9AD6B0037; Tue, 31 Mar 2020 02:53:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0BF346B006C; Tue, 31 Mar 2020 02:53:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0055.hostedemail.com [216.40.44.55]) by kanga.kvack.org (Postfix) with ESMTP id EA2A16B0032 for ; Tue, 31 Mar 2020 02:53:56 -0400 (EDT) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id A8339180AD804 for ; Tue, 31 Mar 2020 06:53:56 +0000 (UTC) X-FDA: 76654742472.24.lift99_5c9e012e0692e X-HE-Tag: lift99_5c9e012e0692e X-Filterd-Recvd-Size: 4129 Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by imf34.hostedemail.com (Postfix) with ESMTP for ; Tue, 31 Mar 2020 06:53:56 +0000 (UTC) Received: by mail-wm1-f66.google.com with SMTP id r16so1210502wmg.5 for ; Mon, 30 Mar 2020 23:53:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=TIdfTSo/e484Z3PHPHMJ/sokMhYtX+vwmXQLZC2QabA=; b=pBq0Oh9Xy6hU00u/+o8eOfRC0LhWSvo83BSzyEEuxoSEVIKKAdARxOWS4TZxH1tM+r zRo4mw7gQWkHJZ23Q2NYuGXwArr/uRoMWqSSfWomhaFqyjWd4GbFzqNwI/HljS3ZQh7M GOgSlHdzIUGVM03X9wcySplZtR7UhLxDs4GLHwrkE5/xaMdjLZEdtL8sNaSNJNXvcNkO UUidKhR9FQFyOL7WabyBBc5KHYBIIBy4Z8+PzrcWzNhm/cvGMjn45Aac5dbDcnrQIRaZ GWQJugWgsxGsU3FpKqRkjmUK/ySbzggz35S1KB26n5gQ/jxhBjowFFW2KLTCkJ4f3yIo 3fxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TIdfTSo/e484Z3PHPHMJ/sokMhYtX+vwmXQLZC2QabA=; b=qGds4arX5UpUktm9/iLiZ+M95eP994jupycH6e6rR06r5A4UnpQMZHZV4pfxumw7J4 A7j7HMRd2Pf3nrlFe9RgtMXh01FWrM+gTow4XWce38aTF7qm5YcN9wp3bk4Fnz4yGZd3 57bp+AN8mHJpCmCG5Q+R/xGmxWTBlVYS7AmB64Bioalcv8TlMcjHb3SkFWr9/5d8tc/2 O0PVAHwdyWBCWLJRh4VBw3/2S9XbAsSqziVGabv98pFU9AsANJT9HhxhMTQbMmdmJNi1 qmX8BAc91k0MIiyP/J6n63ld93OlVvm3oSW4jZLl+I+lkSKQuvqZX/k3FnBWiOfp4EsE WeJA== X-Gm-Message-State: ANhLgQ3LtDa42Vke4uKsfvhLlsSBdxvxdfF3Qrlm3WR1/11874hxMD3W qHXprVP5w97xZO8kT8Hvm5JHhMRWrt4LNz4nyjI= X-Google-Smtp-Source: ADFU+vs3wLHXuJQLMByTyAYUwEHsLPKn2CFMgsYdlAca+TWGCwpk7wahIsjNVEjB6mfColESYnBMlYXAaPHvHM3JYyw= X-Received: by 2002:a1c:a982:: with SMTP id s124mr1941458wme.105.1585637635174; Mon, 30 Mar 2020 23:53:55 -0700 (PDT) MIME-Version: 1.0 References: <20200330220840.21228-1-richard.weiyang@gmail.com> In-Reply-To: <20200330220840.21228-1-richard.weiyang@gmail.com> From: Pankaj Gupta Date: Tue, 31 Mar 2020 08:53:44 +0200 Message-ID: Subject: Re: [Patch v4] mm/page_alloc.c: use NODE_MASK_NONE in build_zonelists() To: Wei Yang Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, jgg@ziepe.ca, David Hildenbrand , jhubbard@nvidia.com, Baoquan He Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > Slightly simplify the code by initializing user_mask with NODE_MASK_NONE, > instead of later calling nodes_clear(). This saves a line of code. > > Signed-off-by: Wei Yang > Reviewed-by: John Hubbard > Reviewed-by: David Hildenbrand > > --- > v4: adjust subject/description as suggested by John Hubbard > v3: adjust the commit log a little > v2: use NODE_MASK_NONE as suggested by David Hildenbrand > --- > mm/page_alloc.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index ef790dfad6aa..dfcf2682ed40 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -5587,14 +5587,13 @@ static void build_zonelists(pg_data_t *pgdat) > { > static int node_order[MAX_NUMNODES]; > int node, load, nr_nodes = 0; > - nodemask_t used_mask; > + nodemask_t used_mask = NODE_MASK_NONE; > int local_node, prev_node; > > /* NUMA-aware ordering of nodes */ > local_node = pgdat->node_id; > load = nr_online_nodes; > prev_node = local_node; > - nodes_clear(used_mask); > > memset(node_order, 0, sizeof(node_order)); > while ((node = find_next_best_node(local_node, &used_mask)) >= 0) { > -- > 2.23.0 Reviewed-by: Pankaj Gupta