From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DB78C433EF for ; Wed, 8 Dec 2021 12:36:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 35FB56B0071; Wed, 8 Dec 2021 07:35:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 30FD96B0073; Wed, 8 Dec 2021 07:35:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1D7B46B0074; Wed, 8 Dec 2021 07:35:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay036.a.hostedemail.com [64.99.140.36]) by kanga.kvack.org (Postfix) with ESMTP id 0F1176B0071 for ; Wed, 8 Dec 2021 07:35:58 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id CC88380891 for ; Wed, 8 Dec 2021 12:35:47 +0000 (UTC) X-FDA: 78894573534.26.8A302BD Received: from mail-io1-f46.google.com (mail-io1-f46.google.com [209.85.166.46]) by imf24.hostedemail.com (Postfix) with ESMTP id 60C8BB0000A0 for ; Wed, 8 Dec 2021 12:35:47 +0000 (UTC) Received: by mail-io1-f46.google.com with SMTP id c3so2587106iob.6 for ; Wed, 08 Dec 2021 04:35:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=BGELNsFyoDgwcncbtGABFzj/JFF5sXZuONj0OzMW4bM=; b=H9aiRvODe0vHHHIrYGNALS0wpsMJ1AX6T7TUWx4MCAsbZ45M9SMEc8e1l16oM9b6l5 fc1W50YQElBI2E3guVAQWFjV+mDwhj/YqDAVGPdrOeeFoDUxD/K+n/urQuYSXYYdcwc0 v3c5rK093YbhQjEDcepL0FrwzeWFN1Cde3oIQqlQ5Ap4kFQrpxNKzByaMqm8keS+FApP ONe4TvB0pxfK+R913pmOme8qdHo/CEv7zR8hwZRfIeRjfvqsxXFqr+MA0VL7fUWg/qKN iDtiPmFM0vclrSxnuHdcWWcRG7Bi5tFVMx6RvcB5lE/Y1lrblN2vpXhzwwYDLPBlJtbi s3hQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BGELNsFyoDgwcncbtGABFzj/JFF5sXZuONj0OzMW4bM=; b=bZ5OrNPjt3FotNcDmgou48HjKyaFJfjAVEj7kHMbgEA60ClSd+b1uPVAPY4cAafLwg WmazNTFc03dKO7qqhvKxD0pDSrfqfpXfCk+Snj4Vi3OSQv1jsKK330bTvxH/5hTrYGqG NFN2BYvvTdTBqniKGsU7SFi2usrB3w6sItUeice3FReGa7Xon60jca2jE/uiKznPzfdZ Drw5qqnYHoPLkpaiA/CsiorA7iXL+EVPuwq3scLChgFftv5oFvNnKo6TVubE2EJZdcKs hr2IItG4ztLZtQBSA8fVitr1Mn0nHyqgNx7u3i0+Dxvr98+Xpjkb/DOf3yjZB7CeoF+c B1ow== X-Gm-Message-State: AOAM530vOKUs1HavAy99jq8CVKbPhyf14uVQoWnFbofWcIKgJ5AtMkU4 QHlzMlcaUWiOfzCRFkEZvPGI4XrvAc6Qe5BDv/o= X-Google-Smtp-Source: ABdhPJzFS8DJObIpKJW0Ydpe/O8gHGS+92jvF2gQGK8VLOStppRoGBAnRUikQGm5KUTfT3L7B4D4a05O3sjpM3m9X00= X-Received: by 2002:a05:6638:2727:: with SMTP id m39mr58565004jav.75.1638966946730; Wed, 08 Dec 2021 04:35:46 -0800 (PST) MIME-Version: 1.0 References: <20211207083222.401594-1-chi.minghao@zte.com.cn> In-Reply-To: <20211207083222.401594-1-chi.minghao@zte.com.cn> From: Pankaj Gupta Date: Wed, 8 Dec 2021 13:35:35 +0100 Message-ID: Subject: Re: [PATCH] mm:remove unneeded variable To: cgel.zte@gmail.com Cc: Andrew Morton , Linux MM , LKML , chiminghao , Zeal Robot Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 60C8BB0000A0 X-Stat-Signature: 9nqajrb3xoztturxur1w5ho9p5u1gngn Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=H9aiRvOD; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf24.hostedemail.com: domain of pankaj.gupta.linux@gmail.com designates 209.85.166.46 as permitted sender) smtp.mailfrom=pankaj.gupta.linux@gmail.com X-HE-Tag: 1638966947-192820 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > return value form directly instead of > taking this in another redundant variable. > > Reported-by: Zeal Robot > Signed-off-by: chiminghao > --- > mm/truncate.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/mm/truncate.c b/mm/truncate.c > index cc83a3f7c1ad..41b8249b3b4a 100644 > --- a/mm/truncate.c > +++ b/mm/truncate.c > @@ -205,7 +205,6 @@ static void truncate_cleanup_page(struct page *page) > static int > invalidate_complete_page(struct address_space *mapping, struct page *page) > { > - int ret; > > if (page->mapping != mapping) > return 0; > @@ -213,9 +212,7 @@ invalidate_complete_page(struct address_space *mapping, struct page *page) > if (page_has_private(page) && !try_to_release_page(page, 0)) > return 0; > > - ret = remove_mapping(mapping, page); > - > - return ret; > + return remove_mapping(mapping, page); > } > > int truncate_inode_page(struct address_space *mapping, struct page *page) Reviewed-by: Pankaj Gupta