From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEDDAC0044D for ; Mon, 16 Mar 2020 08:45:32 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 696A520663 for ; Mon, 16 Mar 2020 08:45:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UGYTrq+w" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 696A520663 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 014486B0003; Mon, 16 Mar 2020 04:45:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F07346B0005; Mon, 16 Mar 2020 04:45:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E1D5D6B0007; Mon, 16 Mar 2020 04:45:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0054.hostedemail.com [216.40.44.54]) by kanga.kvack.org (Postfix) with ESMTP id C632B6B0003 for ; Mon, 16 Mar 2020 04:45:31 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 93421180AD802 for ; Mon, 16 Mar 2020 08:45:31 +0000 (UTC) X-FDA: 76600591662.22.quiet30_3035758c2d257 X-HE-Tag: quiet30_3035758c2d257 X-Filterd-Recvd-Size: 4300 Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by imf34.hostedemail.com (Postfix) with ESMTP for ; Mon, 16 Mar 2020 08:45:31 +0000 (UTC) Received: by mail-wm1-f68.google.com with SMTP id z12so7793774wmf.5 for ; Mon, 16 Mar 2020 01:45:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=iwDxRenN/QksZzu/5s9ELTQ8S6eMbiMgxDLU6f6aULc=; b=UGYTrq+wIrsYoU4Da6ipaDPBJHvyL31hDFGqzJyPI8a/Q2jk3YGoFXR3+ZdujDnwTX zxXJDi6hcswo9vqzqfp4Xh6du3S9CEgQo7jDhBCTswcCK8cmLYIz1/ygvh1zXi9f15yA KsyIBSA7vefvpESVjr0ybotDD95yC2meaobLvKSMy+nYJavnx0dXhdxH4sNpc39R2wTd yofDZOgK/V2SPRaEQkZFETkXGTWRtCjrm8ZGwDgfGXyYcdJM9sIy9WCTTQUcaDqCfZ+b pVd1KHYRgzhbWcENvf306peKSaaXYQ6K99u5CNUWN0VMrbHy1vVpFTzER0tI1HsSaZFO +jkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=iwDxRenN/QksZzu/5s9ELTQ8S6eMbiMgxDLU6f6aULc=; b=eatjOBJ9my7m138TKxIoRZK8fHkscIgizkeBJ78Q17NrM0ZYTaM18pHafe/wJoP+pQ jDh9/YJZcbYZB167+xxd78ZrDEgqkIK0iuLNrzWDivWWxtpzM+GzUFNrq9+D5XGZ4Kjs g1gok92mkb1iiIqcu0Lp/kWhnmBw1BnpzBhF/DcVYadGM9+WUDufLsagan+GFFjD95pJ brlDXo82fndKz7XeOT2OgrSGs4nvpLkitZlh0f3gXAhd4fRrmpzpVBaFEA75VLohe3FB ER+rJOPXUpKoWsmnXceCnpUV3tHXSiNPm4D5Prttq2yIRXRBQVuXK7VV8t9HBDMI1AY3 xTCA== X-Gm-Message-State: ANhLgQ0MIMl6Lom70jvDHzQPv3whB9sDXUtEAeZWOYZhIn5akHn4jVDv ThVJDs8MLnvCvLsvAo+TL6/yZUuL0cfN2g1kLMI= X-Google-Smtp-Source: ADFU+vv/ApbQ8CagHhNxhsW3a3kkOa3FHYZhzULVaZi1y5KGo/nLWpq2fksh8qOXczCGDqGxz/D3085YcVF7uf55P8E= X-Received: by 2002:a1c:f204:: with SMTP id s4mr22858074wmc.127.1584348329804; Mon, 16 Mar 2020 01:45:29 -0700 (PDT) MIME-Version: 1.0 References: <1584345587-16769-1-git-send-email-qiwuchen55@gmail.com> In-Reply-To: <1584345587-16769-1-git-send-email-qiwuchen55@gmail.com> From: Pankaj Gupta Date: Mon, 16 Mar 2020 09:45:18 +0100 Message-ID: Subject: Re: [RESEND PATCH] mm/sparse: remove duplicated pfn_to_section_nr() To: qiwuchen55@gmail.com Cc: Andrew Morton , linux-mm@kvack.org, chenqiwu Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > From: chenqiwu > > Remove duplicated pfn_to_section_nr() in pfn_valid() and pfn_present() > to increase executing efficiency of code. > > Signed-off-by: chenqiwu > --- > include/linux/mmzone.h | 11 +++++++---- > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h > index 462f687..35763b5 100644 > --- a/include/linux/mmzone.h > +++ b/include/linux/mmzone.h > @@ -1358,10 +1358,11 @@ static inline int pfn_section_valid(struct mem_section *ms, unsigned long pfn) > static inline int pfn_valid(unsigned long pfn) > { > struct mem_section *ms; > + unsigned long sec_nr = pfn_to_section_nr(pfn); > > - if (pfn_to_section_nr(pfn) >= NR_MEM_SECTIONS) > + if (sec_nr >= NR_MEM_SECTIONS) > return 0; > - ms = __nr_to_section(pfn_to_section_nr(pfn)); > + ms = __nr_to_section(sec_nr); > if (!valid_section(ms)) > return 0; > /* > @@ -1374,9 +1375,11 @@ static inline int pfn_valid(unsigned long pfn) > > static inline int pfn_present(unsigned long pfn) > { > - if (pfn_to_section_nr(pfn) >= NR_MEM_SECTIONS) > + unsigned long sec_nr = pfn_to_section_nr(pfn); > + > + if (sec_nr >= NR_MEM_SECTIONS) > return 0; > - return present_section(__nr_to_section(pfn_to_section_nr(pfn))); > + return present_section(__nr_to_section(sec_nr)); > } > > static inline unsigned long next_present_section_nr(unsigned long section_nr) > -- Looks ok. Acked-by: Pankaj Gupta > 1.9.1 > >