From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0282EC433E0 for ; Tue, 2 Jun 2020 06:08:58 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B7CA4206A2 for ; Tue, 2 Jun 2020 06:08:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="o7YovVxE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B7CA4206A2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 56B6E280027; Tue, 2 Jun 2020 02:08:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 51B49280019; Tue, 2 Jun 2020 02:08:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3E31E280027; Tue, 2 Jun 2020 02:08:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0053.hostedemail.com [216.40.44.53]) by kanga.kvack.org (Postfix) with ESMTP id 243B7280019 for ; Tue, 2 Jun 2020 02:08:57 -0400 (EDT) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id D8C7E45B3 for ; Tue, 2 Jun 2020 06:08:56 +0000 (UTC) X-FDA: 76883243472.09.time44_13dd17ddb113a Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin09.hostedemail.com (Postfix) with ESMTP id B6954180AD804 for ; Tue, 2 Jun 2020 06:08:56 +0000 (UTC) X-HE-Tag: time44_13dd17ddb113a X-Filterd-Recvd-Size: 4910 Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by imf02.hostedemail.com (Postfix) with ESMTP for ; Tue, 2 Jun 2020 06:08:56 +0000 (UTC) Received: by mail-wm1-f65.google.com with SMTP id r15so1792052wmh.5 for ; Mon, 01 Jun 2020 23:08:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NDGYSbP7uksg9+a4r1iJamlh67Acsz3aGJVeqfoyDV0=; b=o7YovVxEvNBhAdPPNBFaK+JmkxuBB4/xKKIT1qcpOELnjJ/YTf7DUjI3RFuu+qY2+X NITAv3fgVQXIKRMRHSMVeyO6ajyBkf2OOQLpHCRN9pQGs8X+gqhCjaZSxu29v1Tami3u MM7CY2e2hyRLnvqiV6gBifOfQAhqlSALfor+ITJr3qIPIcAJ7na+qMogYTp3rg4fgxwB lfte6gUwulmhd+4FLeZy0Oj1mKnQK73EdD8hRAsDdjg9EDhwHmAt8CLUoiuJ8XJ3SFQl f9D2jZX7IXB5zKvIj9CViLa3mJt4xvarJOhKrnqWawXJzMKY6rFXl91VnuA7v7ongqf9 SYYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NDGYSbP7uksg9+a4r1iJamlh67Acsz3aGJVeqfoyDV0=; b=JsaDq6g3R5hpRmKCjfI/eq1LzYTR0vRPHz4wiT9nS1Wn8epYJwqS2LDheys7jMskKZ aHvkqs4EOro6km2MBHBOtcnaosVaVwitSXzDFIGo4/mTuX+hgQ+pFn4kLGWPDVakjOME KNbVzX+yWLHyCAPFGgUiuqMgwo4ztT5x9BZQGpDA2Hgt4ltig/KH0hBHS1J8yLd5VySM CxPceLTob6JtR5HmKXvMo1pIywAwsEgwdrPyn6lfpv6a3oaBYxPfG/JOwgTd/UpP50Yq +90gwr+7pKeOXo57fd+SIN1IFHaj311XeZehOiXR6r0lMdc6+z6FcK8KLqSwMXgpDNVN 8q7Q== X-Gm-Message-State: AOAM530TZPptPvAPfrIbsCZFQKtEGGNnQv3KY2GripdkWrGRaDr5ZTeg igt7w+KTH/xMtoNnykgJ/3q2pBOfxmdSFVDj9Hk= X-Google-Smtp-Source: ABdhPJxbMW9gOsV6GMtEx1bIdBTWOTc6p9HlxeOtGMzSdOLfpQydLKKu4tsXYDL8918ULpDLfXZBeSLCzLSyoGzPpk8= X-Received: by 2002:a7b:cbd9:: with SMTP id n25mr2533226wmi.30.1591078135229; Mon, 01 Jun 2020 23:08:55 -0700 (PDT) MIME-Version: 1.0 References: <20200601052633.853874-1-jhubbard@nvidia.com> <20200601052633.853874-3-jhubbard@nvidia.com> In-Reply-To: <20200601052633.853874-3-jhubbard@nvidia.com> From: Pankaj Gupta Date: Tue, 2 Jun 2020 08:08:44 +0200 Message-ID: Subject: Re: [PATCH v2 2/2] vhost: convert get_user_pages() --> pin_user_pages() To: John Hubbard Cc: Andrew Morton , "Michael S . Tsirkin" , Jason Wang , Vlastimil Babka , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Jan Kara , Dave Chinner , Souptick Joarder , Jonathan Corbet , linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, LKML , Linux MM Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: B6954180AD804 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > This code was using get_user_pages*(), in approximately a "Case 5" > scenario (accessing the data within a page), using the categorization > from [1]. That means that it's time to convert the get_user_pages*() + > put_page() calls to pin_user_pages*() + unpin_user_pages() calls. > > There is some helpful background in [2]: basically, this is a small > part of fixing a long-standing disconnect between pinning pages, and > file systems' use of those pages. > > [1] Documentation/core-api/pin_user_pages.rst > > [2] "Explicit pinning of user-space pages": > https://lwn.net/Articles/807108/ > > Cc: Michael S. Tsirkin > Cc: Jason Wang > Cc: kvm@vger.kernel.org > Cc: virtualization@lists.linux-foundation.org > Cc: netdev@vger.kernel.org > Signed-off-by: John Hubbard > --- > drivers/vhost/vhost.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c > index 21a59b598ed8..596132a96cd5 100644 > --- a/drivers/vhost/vhost.c > +++ b/drivers/vhost/vhost.c > @@ -1762,15 +1762,14 @@ static int set_bit_to_user(int nr, void __user *addr) > int bit = nr + (log % PAGE_SIZE) * 8; > int r; > > - r = get_user_pages_fast(log, 1, FOLL_WRITE, &page); > + r = pin_user_pages_fast(log, 1, FOLL_WRITE, &page); > if (r < 0) > return r; > BUG_ON(r != 1); > base = kmap_atomic(page); > set_bit(bit, base); > kunmap_atomic(base); > - set_page_dirty_lock(page); > - put_page(page); > + unpin_user_pages_dirty_lock(&page, 1, true); > return 0; > } Acked-by: Pankaj Gupta