From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29206C55ABD for ; Fri, 13 Nov 2020 15:10:51 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 53AC82225D for ; Fri, 13 Nov 2020 15:10:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="b8fsqVWo" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 53AC82225D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 869AB6B005C; Fri, 13 Nov 2020 10:10:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 81AAF6B005D; Fri, 13 Nov 2020 10:10:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 72FB36B0068; Fri, 13 Nov 2020 10:10:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0068.hostedemail.com [216.40.44.68]) by kanga.kvack.org (Postfix) with ESMTP id 4604C6B005C for ; Fri, 13 Nov 2020 10:10:49 -0500 (EST) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id E27A43625 for ; Fri, 13 Nov 2020 15:10:48 +0000 (UTC) X-FDA: 77479732176.03.push38_2111e8c27310 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin03.hostedemail.com (Postfix) with ESMTP id C36A028A4E8 for ; Fri, 13 Nov 2020 15:10:48 +0000 (UTC) X-HE-Tag: push38_2111e8c27310 X-Filterd-Recvd-Size: 3710 Received: from mail-io1-f67.google.com (mail-io1-f67.google.com [209.85.166.67]) by imf50.hostedemail.com (Postfix) with ESMTP for ; Fri, 13 Nov 2020 15:10:48 +0000 (UTC) Received: by mail-io1-f67.google.com with SMTP id r9so10060429ioo.7 for ; Fri, 13 Nov 2020 07:10:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=GqYVfEHdstLJDcIWROjqjtKTyucRszCwmWGVvQDjJQs=; b=b8fsqVWoMa2+F6qaJDtvjZCrUpTN1Js6GmdfH65U/3qx+2sc7Ub1OCwWrwTVXGPkYR aitwxAiVdrVH/EA9SZpTwx6r+t69UebGqmW94+9xXD6YmIIoKE9h4D/WfuE3mnl7on4L dXb6GeOSeqgatB2hrpzGoNKmMp7WqDT9+bir9A0cUoUPxeUTaYNkutSBgNaMqN17Q1ob o8TcZiGln9ExgwXDTvlMQ50f+kRe33bv9F45LOWXXFCPxATfv5yLqzRqotqFcdMNP+pj qHarggnP3fTnOkc15OyeugUuEYGrTnOXAW3d/K2fgUX4rL5oaKWrIrxl+ZahIQThwJzR hUVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GqYVfEHdstLJDcIWROjqjtKTyucRszCwmWGVvQDjJQs=; b=kkunVjG1E1//qrdOzEDsB2QU+Zid5Pa7Ms/O/A4ZzCP0m9qxG6xFFGR6PnCpEcFjrS qsCurPa9DraJZkGiI6L9D1cnYXPj9nDN5yMCmlugw+yA8eV9+3sZnTMzJxi1WhHS+DGl hBAS6LL75T/1QPL6oBYlBFt+y8g9yEL6AXbtkfdGEVNHsVM2PgQWsk1nSc2ua5UTCwFa RENETjPuAd3BheCzrZyTgrA2cPrt9L76+c2oFbe0vJbXseUEbtMun5oXXOqqai6OFo4C 42En+FlFQSrXSBjJaTewCQjHcdZGMyymAskocVPiSLYzWne6pIRgBDVnl9P8OaLHJVl5 QGdA== X-Gm-Message-State: AOAM533n7KkDV2cHEXi+PlwtAfpKC3U1i7HzvhNVpwN9BuMXVoRzY6YK +Dqn2vlQpoT2oLbo2yczObTh42CbpyFKUpu1iWY= X-Google-Smtp-Source: ABdhPJzLdPima03y6qgVeBglv6heP573C6yMxNq/WpghhqVue/a675oAsC21xYYdtg8PJRGlVRTKpAZOPXk4ZuyuPTs= X-Received: by 2002:a05:6602:123b:: with SMTP id z27mr148789iot.167.1605280246091; Fri, 13 Nov 2020 07:10:46 -0800 (PST) MIME-Version: 1.0 References: <20201113141048.GA178922@rlk> In-Reply-To: <20201113141048.GA178922@rlk> From: Pankaj Gupta Date: Fri, 13 Nov 2020 16:10:34 +0100 Message-ID: Subject: Re: [PATCH] mm/page_counter: use page_counter_read in page_counter_set_max To: Hui Su Cc: Andrew Morton , Linux MM , LKML Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.001395, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > use page_counter_read() in page_counter_set_max(). > > Signed-off-by: Hui Su > --- > mm/page_counter.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/page_counter.c b/mm/page_counter.c > index b24a60b28bb0..c6860f51b6c6 100644 > --- a/mm/page_counter.c > +++ b/mm/page_counter.c > @@ -183,14 +183,14 @@ int page_counter_set_max(struct page_counter *counter, unsigned long nr_pages) > * the limit, so if it sees the old limit, we see the > * modified counter and retry. > */ > - usage = atomic_long_read(&counter->usage); > + usage = page_counter_read(counter); > > if (usage > nr_pages) > return -EBUSY; > > old = xchg(&counter->max, nr_pages); > > - if (atomic_long_read(&counter->usage) <= usage) > + if (page_counter_read(counter) <= usage) > return 0; > > counter->max = old; Reviewed-by: Pankaj Gupta