From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92425C0044D for ; Mon, 16 Mar 2020 16:28:35 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 481D02051A for ; Mon, 16 Mar 2020 16:28:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DAFK1uuq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 481D02051A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C271E6B000A; Mon, 16 Mar 2020 12:28:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BD76D6B000C; Mon, 16 Mar 2020 12:28:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AC5916B000D; Mon, 16 Mar 2020 12:28:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0209.hostedemail.com [216.40.44.209]) by kanga.kvack.org (Postfix) with ESMTP id 9565A6B000A for ; Mon, 16 Mar 2020 12:28:34 -0400 (EDT) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 4138F52CE for ; Mon, 16 Mar 2020 16:28:34 +0000 (UTC) X-FDA: 76601758548.24.bee32_10951269f9461 X-HE-Tag: bee32_10951269f9461 X-Filterd-Recvd-Size: 4369 Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by imf13.hostedemail.com (Postfix) with ESMTP for ; Mon, 16 Mar 2020 16:28:33 +0000 (UTC) Received: by mail-wr1-f67.google.com with SMTP id y2so6549147wrn.11 for ; Mon, 16 Mar 2020 09:28:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=INtESC7LaymD+ZrokYwY/ad7JOusvguI8SpcCtk9QTU=; b=DAFK1uuq7wY2sQ4B4diRYu5SUY2n7ytN7R9Mk7WUdWye4u+2F4oqiqO2t77Gqal7lD rHIyv3mvFyw6z/fisE684rYZwXHusE/t3LfKUr4QiX30XBA+H9XIjfWGmYjfgeTuk6FS Z+KmzL4f0Iqy/4jLiIFE0MAem8SlNwXn/YZocogI+qR4xJ0fEdVJtTgmfLnF5RZnZAf0 kRCdSG7IK+fRUhwfrc18iIYDCehwKV9dlG9x2xXEktlJwIN9KqvOrCsdBiHXa/r4onre +Z1TM9LlU6sYI8X7pPtxcOfBG2PwoTJ08P2OeDxGVQx0BBy0ASNzvj5PajCYZQkiTAUh JrzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=INtESC7LaymD+ZrokYwY/ad7JOusvguI8SpcCtk9QTU=; b=IOh1IKz0j3t+NdDE/JjeETWT69RlJKQXjkz7h0mbZXF9MrFT7wPDmXXQJuOfDkMTgI Ntq0mZ53jwB1dMXT3iVLJAU3Wqci5rNjvRpcSyezsNqo6HCXwDN1BAxCKkByE3EhcREs O0xggH/IabuY0+STyBabfxbUMQ8ZOiNUrnSqesjahYs2wvzsBHzcEcaBlcrOfSjI/s4V cQg9aqlSA6gMTj2YyoQ66hTFZAc/5lVHobBvlhfXhbvjdv3mmYF+ZkrmBygB40Lja6Sz EBoiTwgiE1NwHAmqKvHfUcNR8ERNTrhlhLJvV0uSF1vJ0/eLnM+d31OeJWE3xj3P77Rp 0pYw== X-Gm-Message-State: ANhLgQ1BxeqqmEDBfT24UqMg4oxq3ksmrHf04R2eZyWEknW4xGCV0atu k3lO7I1qh9k+cbKZDnvmVH9cyXP/qz26xBpCIZw= X-Google-Smtp-Source: ADFU+vvEySzO9mn2X5PpSIqCEpCLL7mvrxB9ayexrjw+ipuMsCaIURnQnGgitbzQLyZbmOH0n1ynwhzvbtQXKOgvsrY= X-Received: by 2002:a5d:56c9:: with SMTP id m9mr134402wrw.289.1584376112780; Mon, 16 Mar 2020 09:28:32 -0700 (PDT) MIME-Version: 1.0 References: <20200316102150.16487-1-bhe@redhat.com> <20200316102150.16487-2-bhe@redhat.com> <20200316125625.GH3486@MiWiFi-R3L-srv> In-Reply-To: <20200316125625.GH3486@MiWiFi-R3L-srv> From: Pankaj Gupta Date: Mon, 16 Mar 2020 17:28:21 +0100 Message-ID: Subject: Re: [PATCH v5 2/2] mm/sparse.c: allocate memmap preferring the given node To: Baoquan He Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, mhocko@suse.com, Andrew Morton , David Hildenbrand , willy@infradead.org, richard.weiyang@gmail.com, Vlastimil Babka Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > When allocating memmap for hot added memory with the classic sparse, the > specified 'nid' is ignored in populate_section_memmap(). > > While in allocating memmap for the classic sparse during boot, the node > given by 'nid' is preferred. And VMEMMAP prefers the node of 'nid' in > both boot stage and memory hot adding. So seems no reason to not respect > the node of 'nid' for the classic sparse when hot adding memory. > > Use kvmalloc_node instead to use the passed in 'nid'. > > Signed-off-by: Baoquan He > Acked-by: Michal Hocko > Reviewed-by: Matthew Wilcox (Oracle) > --- > mm/sparse.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/sparse.c b/mm/sparse.c > index 3fa407d7f70a..31dcdfb55c72 100644 > --- a/mm/sparse.c > +++ b/mm/sparse.c > @@ -719,8 +719,8 @@ static int fill_subsection_map(unsigned long pfn, unsigned long nr_pages) > struct page * __meminit populate_section_memmap(unsigned long pfn, > unsigned long nr_pages, int nid, struct vmem_altmap *altmap) > { > - return kvmalloc(array_size(sizeof(struct page), > - PAGES_PER_SECTION), GFP_KERNEL); > + return kvmalloc_node(array_size(sizeof(struct page), > + PAGES_PER_SECTION), GFP_KERNEL, nid); > } > > static void depopulate_section_memmap(unsigned long pfn, unsigned long nr_pages, > -- Acked-by: Pankaj Gupta > 2.17.2 > >