From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB021C433E7 for ; Mon, 31 Aug 2020 09:45:33 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7010E2064B for ; Mon, 31 Aug 2020 09:45:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BTO4yNSg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7010E2064B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C39E16B0005; Mon, 31 Aug 2020 05:45:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BEA6D6B0006; Mon, 31 Aug 2020 05:45:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B00CB6B0007; Mon, 31 Aug 2020 05:45:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0248.hostedemail.com [216.40.44.248]) by kanga.kvack.org (Postfix) with ESMTP id 9A04C6B0005 for ; Mon, 31 Aug 2020 05:45:32 -0400 (EDT) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 5AED9180AD811 for ; Mon, 31 Aug 2020 09:45:32 +0000 (UTC) X-FDA: 77210381304.14.tiger27_09120d22708e Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin14.hostedemail.com (Postfix) with ESMTP id 2B74E18229818 for ; Mon, 31 Aug 2020 09:45:32 +0000 (UTC) X-HE-Tag: tiger27_09120d22708e X-Filterd-Recvd-Size: 3525 Received: from mail-io1-f66.google.com (mail-io1-f66.google.com [209.85.166.66]) by imf03.hostedemail.com (Postfix) with ESMTP for ; Mon, 31 Aug 2020 09:45:31 +0000 (UTC) Received: by mail-io1-f66.google.com with SMTP id h4so5179025ioe.5 for ; Mon, 31 Aug 2020 02:45:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=d/wJhQzLekIbhWUFB8CBHk7CDQYQkmDO/XAl9zxuSaU=; b=BTO4yNSgCoI25Xg7JSJrzr10BL4nA+/KtGiUNOUOfG2H7W7QvoCE3EPKXBVnUObt54 H3KcidXy063F3eVEIdySSwsgKwFnSXd88rxrRfpNkqNUwiLwmkqktstHxTzwobj5S35B uvhwqbKtxZKNLmVLiWGEcr9Bh0njlbSX8+g8LiJr4Ehro3tF4CdmCFbCgZu4XkQmloJ/ w3usDuRF0eQPVFCsk+9nLyDq6owIf1+bus1z3Ag9jZ6fQYnHFr5QSCci6O1iWYOG0w3e QPj+EsSh8f0dHt9LFq79mrQBvEMisdmTXHTN9SVEBWQt8/DSYtLzZYFNchuL+RH12JIX nGuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=d/wJhQzLekIbhWUFB8CBHk7CDQYQkmDO/XAl9zxuSaU=; b=rV6afJ8ZUJ0NeBy1djH92DkZ4JFBXLDvaVfxN0jYw+YyWSeBfDYxKeeRokEoxAjZn9 ynsY0t7II69+lsVkts2GqPgNznzJ0y0CWklkatx5H6+OhLX05whYKFkcgHcNSHLvn6Ux HKzC4BejT7Ct+n3o2wzdUDZevrMlx3kw5MCmEEtgmqHjyWPhORIYEypL6PvMPL+eTaCM mYqaPXkyBHLbdhBT4i2cBJ9xGdkOO+rvTJRSd6MNedaTWrix7fq7/wjohzLMGE60DLTK gO/Q+lg9fghSatVtH/vUfqL3yhE7JgDanziMB5RTopPCeRL1fZZPqDN1Wu1LvlGEj13W Lgew== X-Gm-Message-State: AOAM533qF+rczfUhC21E4UbgEW//p1eKIiOoiPEbloY8KtqrTXnBJw2l AqjvkOcswl1gIdkyn6imyUU5s3EZy34nZrlN9qw= X-Google-Smtp-Source: ABdhPJwWYaGimABsUFlmyBNL2gNq2/et8GfL8wEB7EeSIW66hiMjHMYtzhgWnn4EkRrP89FRe5AI8poN0nfcV70UKwc= X-Received: by 2002:a05:6602:1694:: with SMTP id s20mr575122iow.159.1598867131223; Mon, 31 Aug 2020 02:45:31 -0700 (PDT) MIME-Version: 1.0 References: <20200830081053.64981-1-songmuchun@bytedance.com> In-Reply-To: <20200830081053.64981-1-songmuchun@bytedance.com> From: Pankaj Gupta Date: Mon, 31 Aug 2020 11:45:20 +0200 Message-ID: Subject: Re: [PATCH] mm/memory-failure: Fix return wrong value when isolate page fail To: Muchun Song Cc: naoya.horiguchi@nec.com, Andrew Morton , Linux MM , LKML Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 2B74E18229818 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam03 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > When we isolate page fail, we should not return 0, because we do not > set page HWPoison on any page. > > Signed-off-by: Muchun Song > --- > mm/memory-failure.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/mm/memory-failure.c b/mm/memory-failure.c > index 696505f56910..4eb3c42ffe35 100644 > --- a/mm/memory-failure.c > +++ b/mm/memory-failure.c > @@ -1850,6 +1850,7 @@ static int __soft_offline_page(struct page *page) > } else { > pr_info("soft offline: %#lx: %s isolation failed: %d, page count %d, type %lx (%pGp)\n", > pfn, msg_page[huge], ret, page_count(page), page->flags, &page->flags); > + ret = -EBUSY; > } > return ret; > } > -- Acked-by: Pankaj Gupta > 2.11.0 > >