From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3CA4C10DCE for ; Thu, 12 Mar 2020 13:30:54 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 87A70206E7 for ; Thu, 12 Mar 2020 13:30:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DVRH8Apv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 87A70206E7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 373856B0008; Thu, 12 Mar 2020 09:30:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2D5926B000A; Thu, 12 Mar 2020 09:30:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 177086B000C; Thu, 12 Mar 2020 09:30:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0026.hostedemail.com [216.40.44.26]) by kanga.kvack.org (Postfix) with ESMTP id EF06D6B0008 for ; Thu, 12 Mar 2020 09:30:53 -0400 (EDT) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id C8AA6181AEF21 for ; Thu, 12 Mar 2020 13:30:53 +0000 (UTC) X-FDA: 76586795586.04.leaf78_7c31e05bede0f X-HE-Tag: leaf78_7c31e05bede0f X-Filterd-Recvd-Size: 5528 Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by imf08.hostedemail.com (Postfix) with ESMTP for ; Thu, 12 Mar 2020 13:30:53 +0000 (UTC) Received: by mail-wm1-f68.google.com with SMTP id a141so6315357wme.2 for ; Thu, 12 Mar 2020 06:30:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=YFj8ouBRBQRWFj3KwgY//JcyUR/0eXxupmXWGHAN4Vw=; b=DVRH8Apv2LINZDFgD8KwFPHDjaTQswejXip32XqeIb2rCC+defR+2oSnBWDwR453Yu DEvugxEZDrIRUJNtRn0zeIx+cSHY2U0RCKQdhEi6UkDRHNB0r2qNmhbnXcpzmiZk3HHa 82cm6C+jrAlUw3zL0nur/Vk0u/RcYTKd4gdzi5aoWei0HOziatZC+G7E73xYwvRSRC/G dsmL9AycDzhogRPw5Zt7yRBZIuz+qtUzZU4PQmMJxOpE5ndZKY4ckZsL7XHMfRwcX0by oXrvsGOwbRS+CW45RK7Cxv0mnvR9zOI8OO0PFSRNxJvkf3O05wGTIKDxXzaUWIveMem4 TQGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YFj8ouBRBQRWFj3KwgY//JcyUR/0eXxupmXWGHAN4Vw=; b=YFNd95xE7sjxajk71xmYhGqSPinNE87Qi45vSb4YGDPuGOcQFhq5PCHYwYRBs0V0Uk Lf95jl7Uo6BezHtxbUCFtYN9Hadms5YcICOCpwnCVp0+TdhQKLIse/nXZQasapk8MDE6 rFSI7VSjuswmuSxaiNDEogYSH9UesDuvI0u671ili2eCaKoYh0R4sCMuNzgLCF8zmBJz sZOFU7BNFZRBf876M+1uUuCmcsbcJHxGMdwrJX/Hrrcbqlgak7EhvCWuA1e2FKL2n78/ LwKP7NLQATukUqGydSBUYQB/4w82xFeLc1se4lOjIMClDfWWbe6RNiYB0ry4CDeF+7W3 ZsMA== X-Gm-Message-State: ANhLgQ02hfkJPo6ShkyxuMqwnVorpnXIZh/h1bg1rw2kUzsDWrsQgdR3 E8J/GQpgCaz1cdQMHL1EiFy56JXEO2A8BKcR0BM= X-Google-Smtp-Source: ADFU+vsv1KiMmMA9QEO7iTQY9DWEiRMAYh9G6htFZh3AFiMGQuMRc9LZSyCS1oJr94mdwlv5KNdiaU7T9dFQbyn9KUk= X-Received: by 2002:a1c:1fc7:: with SMTP id f190mr4787185wmf.2.1584019852225; Thu, 12 Mar 2020 06:30:52 -0700 (PDT) MIME-Version: 1.0 References: <20200312124414.439-1-bhe@redhat.com> <20200312124414.439-2-bhe@redhat.com> In-Reply-To: <20200312124414.439-2-bhe@redhat.com> From: Pankaj Gupta Date: Thu, 12 Mar 2020 14:30:41 +0100 Message-ID: Subject: Re: [PATCH v4 1/5] mm/sparse.c: introduce new function fill_subsection_map() To: Baoquan He Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , mhocko@suse.com, David Hildenbrand , richard.weiyang@gmail.com, dan.j.williams@intel.com Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > > Factor out the code that fills the subsection map from section_activate() > into fill_subsection_map(), this makes section_activate() cleaner and > easier to follow. > > Signed-off-by: Baoquan He > Reviewed-by: Wei Yang > Reviewed-by: David Hildenbrand > --- > mm/sparse.c | 32 +++++++++++++++++++++----------- > 1 file changed, 21 insertions(+), 11 deletions(-) > > diff --git a/mm/sparse.c b/mm/sparse.c > index cf28505e82c5..5919bc5b1547 100644 > --- a/mm/sparse.c > +++ b/mm/sparse.c > @@ -792,24 +792,15 @@ static void section_deactivate(unsigned long pfn, unsigned long nr_pages, > ms->section_mem_map = (unsigned long)NULL; > } > > -static struct page * __meminit section_activate(int nid, unsigned long pfn, > - unsigned long nr_pages, struct vmem_altmap *altmap) > +static int fill_subsection_map(unsigned long pfn, unsigned long nr_pages) > { > - DECLARE_BITMAP(map, SUBSECTIONS_PER_SECTION) = { 0 }; > struct mem_section *ms = __pfn_to_section(pfn); > - struct mem_section_usage *usage = NULL; > + DECLARE_BITMAP(map, SUBSECTIONS_PER_SECTION) = { 0 }; > unsigned long *subsection_map; > - struct page *memmap; > int rc = 0; > > subsection_mask_set(map, pfn, nr_pages); > > - if (!ms->usage) { > - usage = kzalloc(mem_section_usage_size(), GFP_KERNEL); > - if (!usage) > - return ERR_PTR(-ENOMEM); > - ms->usage = usage; > - } > subsection_map = &ms->usage->subsection_map[0]; > > if (bitmap_empty(map, SUBSECTIONS_PER_SECTION)) > @@ -820,6 +811,25 @@ static struct page * __meminit section_activate(int nid, unsigned long pfn, > bitmap_or(subsection_map, map, subsection_map, > SUBSECTIONS_PER_SECTION); > > + return rc; > +} > + > +static struct page * __meminit section_activate(int nid, unsigned long pfn, > + unsigned long nr_pages, struct vmem_altmap *altmap) > +{ > + struct mem_section *ms = __pfn_to_section(pfn); > + struct mem_section_usage *usage = NULL; > + struct page *memmap; > + int rc = 0; > + > + if (!ms->usage) { > + usage = kzalloc(mem_section_usage_size(), GFP_KERNEL); > + if (!usage) > + return ERR_PTR(-ENOMEM); > + ms->usage = usage; > + } > + > + rc = fill_subsection_map(pfn, nr_pages); > if (rc) { > if (usage) > ms->usage = NULL; > -- Acked-by: Pankaj Gupta > 2.17.2 > >