From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7EA4C4361B for ; Fri, 11 Dec 2020 07:33:48 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 55E0E2064C for ; Fri, 11 Dec 2020 07:33:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 55E0E2064C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6A6EA6B0036; Fri, 11 Dec 2020 02:33:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 630796B005D; Fri, 11 Dec 2020 02:33:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4F8CE6B0068; Fri, 11 Dec 2020 02:33:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0107.hostedemail.com [216.40.44.107]) by kanga.kvack.org (Postfix) with ESMTP id 367076B0036 for ; Fri, 11 Dec 2020 02:33:47 -0500 (EST) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id E3D503631 for ; Fri, 11 Dec 2020 07:33:46 +0000 (UTC) X-FDA: 77580186852.27.steam55_2116de8273ff Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin27.hostedemail.com (Postfix) with ESMTP id BE1EA3D668 for ; Fri, 11 Dec 2020 07:33:46 +0000 (UTC) X-HE-Tag: steam55_2116de8273ff X-Filterd-Recvd-Size: 4717 Received: from mail-il1-f196.google.com (mail-il1-f196.google.com [209.85.166.196]) by imf47.hostedemail.com (Postfix) with ESMTP for ; Fri, 11 Dec 2020 07:33:46 +0000 (UTC) Received: by mail-il1-f196.google.com with SMTP id g1so7892678ilk.7 for ; Thu, 10 Dec 2020 23:33:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=v5HpxdPWwk62UINvDZk+rcjGzodsUyDT59+6kcdYqLY=; b=UuSx1zwxSFyQ3GOKZPndz1Tc7V8nFIvuFUBR8XbCXonEXa/XEZK873OgDWO1WKAxQk xcg3++SlORlx+0DWHNTCHFq7Zuo11PQaeHDOZTYDn22vZ19NluY2W2a2Fbc5MU99I/pJ nM4pak6ZupQAvqGpu9xvLkaJqRUeKvpnOG6r6JS3lhf26yhelnGnVSmwUOjZ/pT3mZb3 pMypx52dKsij5h0z0Dc+dVnx67o8UjCJgjNnnMfS5xy5CeK+9oeThog2DL0PUNXAjOzf 6VsG2mXexTC0hH+p9cdUbtr0/oGltOyvtPfvG1kTEpXIOG8SFRiO6oMCvDGWMw5eDLtq d9bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=v5HpxdPWwk62UINvDZk+rcjGzodsUyDT59+6kcdYqLY=; b=OaWR6NG74Xm3UdN6nTQo6gzkxxvjsJXKC/m8D8nQBYcnCbH5ML8O/D2+BTbi44OVvM d0Fs0eKo2ocM8x1Sg5LS1JTIkp1zfiYMKL86DeRx59TSAyNDdNgZgTHam3XeHHuCsJeA MYcWo1+ZgipVigxn8PYi5MA+dhzepVLOXueSfWMz50vK6anIZp8E0UYreoUSG/SAJiuz 7cblCzHNlya182lxsqqad0/a39LZPjpUD1eNAy9J8Cm0ZoUulDXL+6lTWd/c2iUUt7Kv diet47I20EfNYKbIfEnwmkyvpfegH65xJfsn+ms+4t+zG5EX/9k7y3IKicRTxujCQ4VQ GS2Q== X-Gm-Message-State: AOAM5327Mt9CG7tsIzma66SpyjFfsRSGb6wc480Tz4nllkG6DG6wP746 +0g3fa/ix7NpLw78ks5ctwFAQLv0yhrOodu8L18= X-Google-Smtp-Source: ABdhPJw7MbJqRtZnDVadtFjF/7vY4pbLtnDux/WDt8xuFRiA2d0CeZYC+4LK6GKUgZn1jy6fENahVXkzfUGmG9BDxx8= X-Received: by 2002:a92:c112:: with SMTP id p18mr14707710ile.89.1607672025843; Thu, 10 Dec 2020 23:33:45 -0800 (PST) MIME-Version: 1.0 References: <20201211041954.79543-1-songmuchun@bytedance.com> <20201211041954.79543-2-songmuchun@bytedance.com> In-Reply-To: <20201211041954.79543-2-songmuchun@bytedance.com> From: Pankaj Gupta Date: Fri, 11 Dec 2020 08:33:34 +0100 Message-ID: Subject: Re: [PATCH v4 1/7] mm: memcontrol: fix NR_ANON_THPS accounting in charge moving To: Muchun Song Cc: Greg Kroah-Hartman , "Rafael J. Wysocki" , adobriyan@gmail.com, Andrew Morton , Johannes Weiner , Michal Hocko , vdavydov.dev@gmail.com, Hugh Dickins , Shakeel Butt , guro@fb.com, Sami Tolvanen , feng.tang@intel.com, neilb@suse.de, Joonsoo Kim , Randy Dunlap , LKML , linux-fsdevel@vger.kernel.org, Linux MM , cgroups@vger.kernel.org, Michal Hocko Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > The unit of NR_ANON_THPS is HPAGE_PMD_NR already. So it should inc/dec > by one rather than nr_pages. > > Fixes: 468c398233da ("mm: memcontrol: switch to native NR_ANON_THPS counter") > Signed-off-by: Muchun Song > Acked-by: Michal Hocko > Acked-by: Johannes Weiner > Reviewed-by: Roman Gushchin > --- > mm/memcontrol.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index b80328f52fb4..8818bf64d6fe 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -5653,10 +5653,8 @@ static int mem_cgroup_move_account(struct page *page, > __mod_lruvec_state(from_vec, NR_ANON_MAPPED, -nr_pages); > __mod_lruvec_state(to_vec, NR_ANON_MAPPED, nr_pages); > if (PageTransHuge(page)) { > - __mod_lruvec_state(from_vec, NR_ANON_THPS, > - -nr_pages); > - __mod_lruvec_state(to_vec, NR_ANON_THPS, > - nr_pages); > + __dec_lruvec_state(from_vec, NR_ANON_THPS); > + __inc_lruvec_state(to_vec, NR_ANON_THPS); > } > > } Acked-by: Pankaj Gupta