From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 299E7C433E2 for ; Wed, 2 Sep 2020 18:54:46 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CEC6920773 for ; Wed, 2 Sep 2020 18:54:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NQnxgMfX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CEC6920773 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 577A1900011; Wed, 2 Sep 2020 14:54:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 527EA90000F; Wed, 2 Sep 2020 14:54:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 43D99900011; Wed, 2 Sep 2020 14:54:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0210.hostedemail.com [216.40.44.210]) by kanga.kvack.org (Postfix) with ESMTP id 2F74290000F for ; Wed, 2 Sep 2020 14:54:45 -0400 (EDT) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id DD27B181AEF07 for ; Wed, 2 Sep 2020 18:54:44 +0000 (UTC) X-FDA: 77219022888.11.whip12_0b04036270a3 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin11.hostedemail.com (Postfix) with ESMTP id B0F44180F8B81 for ; Wed, 2 Sep 2020 18:54:44 +0000 (UTC) X-HE-Tag: whip12_0b04036270a3 X-Filterd-Recvd-Size: 4226 Received: from mail-io1-f68.google.com (mail-io1-f68.google.com [209.85.166.68]) by imf35.hostedemail.com (Postfix) with ESMTP for ; Wed, 2 Sep 2020 18:54:44 +0000 (UTC) Received: by mail-io1-f68.google.com with SMTP id g13so8394ioo.9 for ; Wed, 02 Sep 2020 11:54:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=HF56mZMJ2WsC21vuD8YlR44aW/J9Nv1kdlXNn6+0Jmc=; b=NQnxgMfX9wCh2os1ZOmAHNWgN8zzEMfrZbO5AEPVjZv0XdJnxNppuiYPUOTdW6mg5a XHcrItkgB5FofTpctF3wGtgUhhpulJNTzJBbNdasn6xB2F0Z67jLO0I6iDmbYJfWPnk0 hF/lbJnKwbBzFrWro3omc+6I4k9XqEHHo7Hkvd7/yUN17rMq9R6vXjp9xu3ogKcPbQmA azNzJyXtRcaJsFMHhh+K2Hwp1r9z1DJ9pELY+PS5qBVS7s+IxSm3p1Swdb65cIwG5bGR DISjcfloDr7oVm9mTR2t+3ZrTG+Ap+F7lJYGaoxLrHnbXB4RHCOwlWTf/OSFriKgbiKa IbCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HF56mZMJ2WsC21vuD8YlR44aW/J9Nv1kdlXNn6+0Jmc=; b=NPfmh0ValUNNX/Kfp6qZsa+Zcws4wqUMP46AYQYABwOeAZffLJqvHFTo3umzk62m3J SYOsobj+srrdUNYWipfXQLIal06ohCCfojNEfAAwxaecv+uefKyKckbjMMy9pdc5HRZ5 cNDc4g7Btq4s0jyhS1JgyVMnizkk4Yusmr2CqEFQahbSFXPlblyuz3bezytI5Z6zrmSk UQXvky/SBQGsiIP5Lv/GET1d8QMkeD402voQRwKAVTa83Ygn5gJul9sUAQG66QPTxhkf fbBX9S0NM+ilj96zj95iA4Wz81iRm75Iu/td8mfOD8sHQitnbhUow5Eq6awWRIIdmWNP j89w== X-Gm-Message-State: AOAM531lEz6RbaJ12CDtIPjyz6jBUDyA6GBg0h+4QaBhsVusdojiP/dI 6n7T8yaC2XKmbLtwxqfZLIafat5xiZsEtju9Xo4T6P2+UcI= X-Google-Smtp-Source: ABdhPJymnhlrdDdnHN9QbXZ8plCeo5oARAUu45klg6LMfnATgzaisqhmYVn2br9fNybt7R3g58duVGwp2lt3slZWmNw= X-Received: by 2002:a05:6638:1607:: with SMTP id x7mr4419966jas.109.1599072883749; Wed, 02 Sep 2020 11:54:43 -0700 (PDT) MIME-Version: 1.0 References: <159905616280.521200.12444250032673650063.stgit@warthog.procyon.org.uk> In-Reply-To: <159905616280.521200.12444250032673650063.stgit@warthog.procyon.org.uk> From: Pankaj Gupta Date: Wed, 2 Sep 2020 20:54:32 +0200 Message-ID: Subject: Re: [PATCH] Fix khugepaged's request size in collapse_file() To: David Howells Cc: Andrew Morton , Song Liu , "Matthew Wilcox (Oracle)" , Linux MM , LKML Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: B0F44180F8B81 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > collapse_file() in khugepaged passes PAGE_SIZE as the number of pages to be > read ahead to page_cache_sync_readahead(). It seems this was expressed as a > number of bytes rather than a number of pages. > > Fix it to use the number of pages to the end of the window instead. > > Fixes: 99cb0dbd47a1 ("mm,thp: add read-only THP support for (non-shmem) FS") > Signed-off-by: David Howells > Acked-by: Song Liu > Reviewed-by: Matthew Wilcox (Oracle) > --- > > mm/khugepaged.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/khugepaged.c b/mm/khugepaged.c > index 6d199c353281..f2d243077b74 100644 > --- a/mm/khugepaged.c > +++ b/mm/khugepaged.c > @@ -1706,7 +1706,7 @@ static void collapse_file(struct mm_struct *mm, > xas_unlock_irq(&xas); > page_cache_sync_readahead(mapping, &file->f_ra, > file, index, > - PAGE_SIZE); > + end - index); > /* drain pagevecs to help isolate_lru_page() */ > lru_add_drain(); > page = find_lock_page(mapping, index); > Acked-by: Pankaj Gupta