From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89921C6FA82 for ; Sun, 25 Sep 2022 23:42:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E69758E0024; Sun, 25 Sep 2022 19:42:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E19258E0007; Sun, 25 Sep 2022 19:42:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CE1AB8E0024; Sun, 25 Sep 2022 19:42:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id BF02E8E0007 for ; Sun, 25 Sep 2022 19:42:06 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 9B30F1A06CE for ; Sun, 25 Sep 2022 23:42:06 +0000 (UTC) X-FDA: 79952233452.04.A6C3AE5 Received: from mail-yb1-f178.google.com (mail-yb1-f178.google.com [209.85.219.178]) by imf18.hostedemail.com (Postfix) with ESMTP id 426351C000A for ; Sun, 25 Sep 2022 23:42:06 +0000 (UTC) Received: by mail-yb1-f178.google.com with SMTP id f189so6351958yba.12 for ; Sun, 25 Sep 2022 16:42:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=CgjSy+2ejnk7MEuLqzJRIcaoiriN+DzQM58IBT5sbmU=; b=MxB8kuY/Jz4suS30u9gdMCg1NmRHy7jGX3MdABghdLVr87NI4IIfTxzPGNHmTc6NAc nn65f3mlzPiwW0dWwHiDLD3IX9RmQLYGbxPkSER9kGYMcaZ1u6aiOSjwsBH5d5gpycSx /rTFny1tquqJBimXFj8CC6Oh1d7ML8gEPzwtN6xGGASFMGF49WRNpsx/M+gbK2xzR4c5 NrErPgXkzxcJFQxENcNnwgmdeateH1gt4cntx7SEm/BG301zsG/VX0tvZBWE5MhNhWKQ bh1BMpGQR6J6Spqe34TC/PDbX79XiXBoJIkXjLmFEb5lwMdBD7ltdoGlmFQFjdE2OJ99 lg6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=CgjSy+2ejnk7MEuLqzJRIcaoiriN+DzQM58IBT5sbmU=; b=Ab/pPMyQjxyGQ4eKVxnGFBgJycFG7nYXyhu239WW8oxrNswXYX8j3HK2DIb7Wi2vgO jngFrvWc38qdjw8Ja7DFLdWcQd4uL6xh4aiOldKzWf2phps6R6Q4JAJ+CjnxZ3VJ35pW otP4T3tQCA/wPyR52/ZoQxIB9BgjtRxlFQBiqHjhl3Spa/vbJvyi72RauosdNpb5BQ/E GyeMl3Qx6QmmT+302nGSGNeqcXha8i+6N/KBFQKQfRQG45Mzs0/YGtbFoZi7xL8DvMZN ufC7JsmaUnHVocbw8LkQrtPd3n4LV7wq5nCeiwPuh/ZsTOjF/cqAD+4N1l5p1KxeAfDB MnSQ== X-Gm-Message-State: ACrzQf2QNSbGQXLu4lAM5uka+SXfNM0zLwui46KL8Q9AM6tSrGJskfsv VcT/oagHTdX54j6oH1vgXqvAuFv3lKxeo16R24I= X-Google-Smtp-Source: AMsMyM6jHUKcbAFtoCv5LF/5Q+NMxVdnL6cMpTsaDqZbOOLOzz4Xl1cKu4aR7s7RrcNe0buZZ76/6elkRkDjbl5CKLU= X-Received: by 2002:a5b:1c3:0:b0:6ac:c87f:3dc8 with SMTP id f3-20020a5b01c3000000b006acc87f3dc8mr18240908ybp.547.1664149325368; Sun, 25 Sep 2022 16:42:05 -0700 (PDT) MIME-Version: 1.0 References: <20220925234053.26090-1-ppbuk5246@gmail.com> In-Reply-To: <20220925234053.26090-1-ppbuk5246@gmail.com> From: Yun Levi Date: Mon, 26 Sep 2022 08:41:54 +0900 Message-ID: Subject: Re: [PATCH v2] damon/sysfs: Fix possible memleak on damon_sysfs_add_target. To: sj@kernel.org Cc: akpm@linux-foundation.org, damon@lists.linux.dev, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="MxB8kuY/"; spf=pass (imf18.hostedemail.com: domain of ppbuk5246@gmail.com designates 209.85.219.178 as permitted sender) smtp.mailfrom=ppbuk5246@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1664149326; a=rsa-sha256; cv=none; b=qh4GN2jvqCqXT0xjz5Z8JLoxPDpFFsySzKjiBhUFxsb16/CRlzUnEIJmBAGUhaRNsHqwVg NOneU1mH2EzzbEfInudzMFFiP+8jhKPOOc2DQJ9BARsbgqlgfc8WljyvDuSozWQLXMz4Dl fVC7bWpQbFn2pNPwf0xBccBS+rVWLBg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1664149326; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CgjSy+2ejnk7MEuLqzJRIcaoiriN+DzQM58IBT5sbmU=; b=lxgMA9C7zK7NSCx5kwJX6CcJLIKLjwmAPZjoFQpr/d2WefpQ4KS01s2IJ9j9aX7SOnOc06 Bf/yd73VPQn4S+MT2GIm4XXWpVnzXaLA5eqFlf1B1X00ndtufSubVbAkvrRGiyGqwS7r8h Nko1ksKtuFOQGJbMassdn9qC+xmEAMk= Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="MxB8kuY/"; spf=pass (imf18.hostedemail.com: domain of ppbuk5246@gmail.com designates 209.85.219.178 as permitted sender) smtp.mailfrom=ppbuk5246@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Stat-Signature: y9ij5xg5ckxmmn3mowebeftoaw4j1h87 X-Rspamd-Queue-Id: 426351C000A X-Rspamd-Server: rspam12 X-Rspam-User: X-HE-Tag: 1664149326-930980 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000153, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Sorry to make noise... I miss the fixes tag, resend the patch! Thanks! On Mon, Sep 26, 2022 at 8:41 AM Levi Yun wrote: > > When damon_sysfs_add_target couldn't find proper task, > New allocated damon_target structure isn't registered yet, > So, it's impossible to free new allocated one by > damon_sysfs_destroy_targets. > > By calling damon_add_target first as soon as allocate new one, > Fix possible memory leak. > > Signed-off-by: Levi Yun > --- > mm/damon/sysfs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/damon/sysfs.c b/mm/damon/sysfs.c > index 7488e27c87c3..bdef9682d0a0 100644 > --- a/mm/damon/sysfs.c > +++ b/mm/damon/sysfs.c > @@ -2182,12 +2182,12 @@ static int damon_sysfs_add_target(struct damon_sysfs_target *sys_target, > > if (!t) > return -ENOMEM; > + damon_add_target(ctx, t); > if (damon_target_has_pid(ctx)) { > t->pid = find_get_pid(sys_target->pid); > if (!t->pid) > goto destroy_targets_out; > } > - damon_add_target(ctx, t); > err = damon_sysfs_set_regions(t, sys_target->regions); > if (err) > goto destroy_targets_out; > -- > 2.35.1