From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AE1AEB64DD for ; Thu, 27 Jul 2023 21:16:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B3D736B0075; Thu, 27 Jul 2023 17:16:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AECE56B0078; Thu, 27 Jul 2023 17:16:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9B4D36B007B; Thu, 27 Jul 2023 17:16:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 8D1EA6B0075 for ; Thu, 27 Jul 2023 17:16:03 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 3B8AE80306 for ; Thu, 27 Jul 2023 21:16:03 +0000 (UTC) X-FDA: 81058649406.20.8055B7C Received: from mail-oi1-f172.google.com (mail-oi1-f172.google.com [209.85.167.172]) by imf06.hostedemail.com (Postfix) with ESMTP id 75E9118000A for ; Thu, 27 Jul 2023 21:16:01 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=IOAM7fcK; spf=pass (imf06.hostedemail.com: domain of ppbuk5246@gmail.com designates 209.85.167.172 as permitted sender) smtp.mailfrom=ppbuk5246@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690492561; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6D1dKbMUyuMxqTeEeSi4spRio8knbrwzUbIZXRfX+hw=; b=a9Kb/KNiLeSx2+SbH3uCbsbfGGDw0g48ffAu928ksc6pNT3SV5qN44Xm/HkeDVWcrUZ/Ma qGnW4Y2JyBfokTS6XbL1BmaaOf2bjFUPIl9mYEFdIAdo/qaiEdegMXZGJgo+RzhkZqD2aH DmQz71JfN8n7UBx6os4uNGdSYalHG78= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690492561; a=rsa-sha256; cv=none; b=ImP93iST4HgOysaaJgkSYekdn0/e8Ym1doad1LOX5pukY5lKd6kSLs6ux8cmX2tfP/1W5l afH//c8nWScNBFIyWqQKfET1t8rJDXZGr9q08IEwmDNREdoCCC7/bO3C4sKQmA3AfJlcuH rQclBfeY3wf4L88vRfyatgzFDHW+OSI= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=IOAM7fcK; spf=pass (imf06.hostedemail.com: domain of ppbuk5246@gmail.com designates 209.85.167.172 as permitted sender) smtp.mailfrom=ppbuk5246@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-oi1-f172.google.com with SMTP id 5614622812f47-3a426e70575so1003019b6e.0 for ; Thu, 27 Jul 2023 14:16:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690492560; x=1691097360; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=6D1dKbMUyuMxqTeEeSi4spRio8knbrwzUbIZXRfX+hw=; b=IOAM7fcKQP3AJZ1G53VvO+FMwupcfbqVzToDOoQiJYud3dWdDmJb6Jtd760kWvOUgI rl+NquP649J9eHU2kyBq4oFVRVj0tR8rPhz7Ji7xDfcWHJ1ifnhjAhjxOV2uG+bw/7Y2 dhwWvtJk+kyNFnZzLO8zhXzuFxNS2EeGA+AGfxAVI6WEUk/WYGvd5wsxpCZjV7O4d6Uf VL7boBq6vz3GeQ1VQXFX917WhcDwNXpDH0FGGDw6OKSSdcizMPmxExSB+58GXYbTCyFP qXqtahtcdKYTb8JUnOHa3XGxA5clJ6igdYnXEvscYlpAvzLLdDk7vHbm1dF/wJiivo1Y aLNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690492560; x=1691097360; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6D1dKbMUyuMxqTeEeSi4spRio8knbrwzUbIZXRfX+hw=; b=Dv60ytJqN8I1yCBnl2JiwDd24UtZxnqhfroS3yZifSq8J0FsHHYa6WlDlXGvAyiIm/ lBRjLVs61DJsTz6869sipQf6hFswEFHs8l9WscawJj98X8LGxtIdRoHrgo8zVPhgdAtc fiaB7qFKTLBng1W9z+b/gaiq3eZBYjVh/CD0PlDC4tDoB5BHHfLs45c+OeAVvo6UmpqO JyjxxIOSPk76BsvtMxx6rsVj1yZF+YI8ljtjw0Blk6S+DU66+cnM/MQYevccz+IEsNb5 BXPCNtE5okrDoLlrPmCWeHFbfw9dKzlfTiKEf9FdtKKbDDFYenFGTVxjYHsa/E7VE8XW CaKQ== X-Gm-Message-State: ABy/qLYC6Nunec/zqB1ZwGq1JyWBIkzGwGpVuMDcdC8L8AroHoF873/Z 7hl+gkiDtOnR+J+2hhdma0i8FZM9mDr3ROrYm/U= X-Google-Smtp-Source: APBJJlEDDP8mK0hZ5SSzXDsSCp3U0EVYi57aUTLxXKqR+DlsxeNchSLZb4HqSXKBKuyr3p3G0Qt+ujscvg7RD1LQiwY= X-Received: by 2002:a05:6808:140b:b0:3a4:3f74:3bd6 with SMTP id w11-20020a056808140b00b003a43f743bd6mr500196oiv.47.1690492560354; Thu, 27 Jul 2023 14:16:00 -0700 (PDT) MIME-Version: 1.0 References: <20230727183745.682880-1-ppbuk5246@gmail.com> <20230727195453.67611-1-sj@kernel.org> In-Reply-To: <20230727195453.67611-1-sj@kernel.org> From: Yun Levi Date: Thu, 27 Jul 2023 22:15:49 +0100 Message-ID: Subject: Re: [PATCH] damon: Use pmdp_get instead of drect dereferencing pmd. To: SeongJae Park Cc: akpm@linux-foundation.org, damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: irbhpingbzmrncw9ehdihbxoytarmxgt X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 75E9118000A X-Rspam-User: X-HE-Tag: 1690492561-505876 X-HE-Meta: U2FsdGVkX1+OyH9wZMFdGqSczSXQ7JNs2+ubdewKHP3cVw1GspjJBd91bJSI+QLAJXi61QzDeqBQLTIbDnNQH419N+OHfJ9Rg+sWV302zJBRC8x1ZwBdPlMlQ0SRiFcRk9gA+X1+szuX+QICBL2NRJL8yig40jHpVXoLxiATGsTJIYJvc2YpFSGAQchow0sr0lbDW0zlkfalQz7ejQ0xS5N7uw10MXiIsQPakoBddA8DNfPnpD3sRKohg+J+mE43VMBzkl0P8oDNaEpCwzHx6tTi6C8cbINTet1r4RnnvgZToFVMJ9x11itF97spFUWCgVNIDPGGXuquFitWTIY3B7HloBPKYp3s1ds+0cZt4ariwWjRib5jHWkPn67TyBQ6drwhzDMuchOphyik0WMOJYnd9oV6CwiA8lkZpoI9Dcx25YNlsi6E4du1qD2zr0ZMaboBWBW6A70FFvHdG0NQmELuk7GWh42jVi7TXVIufx972EveliW2hELUAUgKd7L3FWCgwdcN9U9JVUAATN3m7rM2G7Ku/Wwsw45DNN+euhf0FOCy3KBwCURMKH+iYJJO7sukEYaWrgV9LfoLDwN4oPvljpl1ElQTAnjjKNLDqTMkl7ypSktwQO7jsf6i7aCglVjv45oiby53Wx8ZsMPCkhA9WqkzMBjV7B6Edqica+6gJwG97JmVr8SKUqVkc3tvs2Uy3HFIgwkANAwjngTg6vBpf9Kf1A2pxlYA4Lg177fAPBZFIF3uNU6OGFG0VlcCkIhcopoMYAzYAksjXrvTLy2NEserS5WT5gRbxG61xJzNYaiYoEgN9Xo4fUXqq5OUMz4rnna5jBVG2AOHF3bDEBgtkXr2XlbOp1PCbeMg6wg0T02M4g3mnpY4Yr8Db/bF9U0/l57jPV28iBU7D3pa/RH+SnzsHEjMPseq9jfozYOaP8fq2weB34eH+kMhuBqkho/NR2G/NPLFJQ/toKp EVBpgGJm 6oLalxqd9LaZpLKE3chLvvoNcutwAUTtXrglBLIN3NCZg9VhYzmhWRhqtllnx+FRpovrisSOj9wih35heVskjEiL9cF+BeA9UIyO3jJDmOknW5207FJWjS1hmtr2juyChRAX0c5LON/pyY66yYRUWNt7t6qWiqNSI0elQwmIHIo6UJLrbvt2UMHOEGsR9AOeytHo8EH8it6gIECYcrN/Tvk9gQPNtT+U+cZ+ctuOtwM5AvaUMu3GFThST5znu/u/BYP9kCuO9wrWZXLXJEKp0EJn10hXGiAqR+8BwvC1zjxBc21zIukU/oBZTZjg3Lee4SovRb//nIPIsE7Lys2s7k2SzeWh7mi5iUCokQ+hyT1ocFjInobwHh1XbRSiHYlGNeHGy0cEI8URMn1MOGguNfzBEvX/aHvwpV2Tm X-Bogosity: Ham, tests=bogofilter, spamicity=0.000023, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi SJ. Thanks for looking into this. > Nit for the subject, what about s/drect/directly/? Also, let's remove the > period at the end. > > On Fri, 28 Jul 2023 03:37:45 +0900 Levi Yun wrote: Thanks. But I don't know why period is added thou I sent via git send-email .. > > - if (pmd_trans_huge(*pmd)) { > > + if (pmd_trans_huge(pmdp_get_lockless(pmd))) { > > I don't think we really need to use pmdp_get_lockless() here, since we will do > this check again with the lock, and we have the fallback for the intermediate > changes. Agree. I'll change. Thanks :) > > @@ -434,26 +437,29 @@ static int damon_young_pmd_entry(pmd_t *pmd, unsigned long addr, > > { > > pte_t *pte; > > pte_t ptent; > > + pmd_t pmde; > > This would cause below build warning if CONFIG_TRANSPARENT_HUGEPAGE is not > defined. > > .../mm/damon/vaddr.c:440:8: warning: unused variable 'pmde' [-Wunused-variable] > 440 | pmd_t pmde; > | ^~~~ > > > > spinlock_t *ptl; > > struct folio *folio; > > struct damon_young_walk_private *priv = walk->private; > > > > #ifdef CONFIG_TRANSPARENT_HUGEPAGE > > - if (pmd_trans_huge(*pmd)) { > > + if (pmd_trans_huge(pmdp_get_lockless(pmd))) { Oh.. I miss this. Many thanks..! > Thanks, > SJ Many Thanks..! --------- Sincerely, Levi.