From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05726EB64DD for ; Fri, 28 Jul 2023 06:59:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7F04D6B0072; Fri, 28 Jul 2023 02:59:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 77A7E6B0074; Fri, 28 Jul 2023 02:59:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5F6C56B0075; Fri, 28 Jul 2023 02:59:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 4E56D6B0072 for ; Fri, 28 Jul 2023 02:59:11 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 292811C9662 for ; Fri, 28 Jul 2023 06:59:11 +0000 (UTC) X-FDA: 81060118902.08.D9FC195 Received: from mail-qt1-f169.google.com (mail-qt1-f169.google.com [209.85.160.169]) by imf13.hostedemail.com (Postfix) with ESMTP id 647532001E for ; Fri, 28 Jul 2023 06:59:08 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=SnpBnY2o; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf13.hostedemail.com: domain of ppbuk5246@gmail.com designates 209.85.160.169 as permitted sender) smtp.mailfrom=ppbuk5246@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690527548; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uBrLltNK/fDQgPKGFScyH1SDUmmIH86PwWRaDh569qE=; b=vQD31IDm71/yHu3Lak+9qKHpAaCDfAAT1PMfmIdRt65Ze6Nb4/WZTpxalkRezejFpVVaaR bCDrJgbEX61uUnMWYymvvRdOKNvdtxREeEdBLPF9Dgv8assPqHPT0L6LNSXZRv5iqLZjrk ABN55kGcbZXRPfFJ0ExB8L7zGlZcg5k= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=SnpBnY2o; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf13.hostedemail.com: domain of ppbuk5246@gmail.com designates 209.85.160.169 as permitted sender) smtp.mailfrom=ppbuk5246@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690527548; a=rsa-sha256; cv=none; b=hkmldzhe6H2iFFt9R7fp4fGjKpV7xmxJrhwtG8QR9ZOUvFUgj/QDuNGBpiAIEmUBZxXD1m wLB0q+oifUBdRBW4c/2cSPR5M9Ld28PDPZkW9EsGSeWozKIRPgIuDooYh8XAWP2RwhDTFW azr1gan8GES9eW7isAGDZAxwOHIdHdc= Received: by mail-qt1-f169.google.com with SMTP id d75a77b69052e-4039f7e1d3aso11588691cf.0 for ; Thu, 27 Jul 2023 23:59:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690527547; x=1691132347; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=uBrLltNK/fDQgPKGFScyH1SDUmmIH86PwWRaDh569qE=; b=SnpBnY2otihuHHHYSDjHJOPZT9jkR75uqSrm0wLVx0ID2esJ6KaK3gH47A6BardiPh y29FLCa+aFMSDSoaUNavqOQDEQ4F8MecDEJmBQCil06OOb+UF1EfrFvv8x0Jlr/USQLC R+iWvdAiHDPucg1tPytbsDytFtFnF9wHhFY+c9WqR0gMU+obe4ooJR6RCw+Q3uD5LX1y TOYz/rt4XK591cUqd3r+4mx/18Hksnq5G2uErJNFszqIavTiCv7lVdUunVVZhB2NMeju ZYyYMb9MVt8KJWYlpmETvumOoKKK7+YPGkJ6Xtv3Fm+xFgJJQz7Av3qBzrLo0lE0JCLP RuyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690527547; x=1691132347; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uBrLltNK/fDQgPKGFScyH1SDUmmIH86PwWRaDh569qE=; b=e0O25qvcfkIpOyrLHnm6owO5D7aKX+K/8uliaHy3z0xORvMVsMnV7s8UkzmRFhQyMj O/5xnJggQcYSy1pSjhVAqzSPy58436JTnYubk9hq66nbYfnh9gkpUbJaINcW07vqdfj3 9nhp3X3Gx40ChvnkQTmZlkBXGwKQ+V1VOxfGkVfH25BYYi47MwqN+8WH7+8fRg0C6AQK eR0NzAGnfMpoJlDkBnzjzcUDcCzaTXo10q2BmWEtu95Q8J5TKYDlBqHOPeA/A4bPXJaD +ClZN1Pdd4vuNskHD4/xn4XnBgL1GQ3JJ8hSD51uTZYGJlHF8NfgHNJixuQ+bu5zPHN7 kuyA== X-Gm-Message-State: ABy/qLaB8LC/tUX8I4MnOLbId9ewyzbAmCLrDmxzjY2Ck5a7pBhNnElV jKxkEaRfdZ1MBUZuZQWJFlMfwo1N+j+BNCpQzpE= X-Google-Smtp-Source: APBJJlHg75yjSFYybiZyNX0p1R660gZtMx4uxNZHQamf2phdSTVEpDTI3nzSY6Fpzgt1B0Epe+/OspI3XwT96qzAg0s= X-Received: by 2002:a05:622a:11cc:b0:403:9be1:c969 with SMTP id n12-20020a05622a11cc00b004039be1c969mr2270692qtk.62.1690527547226; Thu, 27 Jul 2023 23:59:07 -0700 (PDT) MIME-Version: 1.0 References: <20230727212157.2985025-1-ppbuk5246@gmail.com> <20230727215318.43455-1-sj@kernel.org> In-Reply-To: <20230727215318.43455-1-sj@kernel.org> From: Yun Levi Date: Fri, 28 Jul 2023 07:58:56 +0100 Message-ID: Subject: Re: [PATCH v2] damon: Use pmdp_get instead of drectly dereferencing pmd. To: SeongJae Park Cc: akpm@linux-foundation.org, damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 647532001E X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: orcjx8bufaoyxrxcyopn1hhu9qgr3xqd X-HE-Tag: 1690527548-45557 X-HE-Meta: U2FsdGVkX184PZ2lHW1Oimk86WYmpsDR0jhX541ljMT1Z2QJMmq+czN/qwAOARsvkE9RjBAlvXAMgs631KphYRlW0He2Lge8wDAY2wFhtT3c/gZ9U+7kEbICjxjURhjnReCrxyU7Jlhywvrs/eGM9tQaUP+sfK4y/SBNFXDy73mcKZMXx/aaABIgG4dsvQu6loL5cLaQ8jJNKFDHC0IVTuvJdLnUwQgSDnosHCGk7twRhiUla3TTCw9cH/HKxj2laab0Z/vyKT/acTSezpMz9+nbFG17ijvD/rTfhoIQbGHolhmfiN5qqtnU0CnT7ixXHI/Us2/1oYAr61m4o95rNcpsjC2CZfIJAYVx4FjTIx1WPN3/KAzUUtSV47YQlomKiZKBTRmu6A/pEy1iatz2IbdQFAaKlqiVRrtFqIIyOx25DXIoKTd+GBiFvCCZejApVIMTWCjSfjQwgqI2gZHBZ8ZGM0R/9M0ITMOHjCXdPkD4beSNXsH6OblZ3RAV8u4aoV2vN6EF/Vsd135imPmgOkf1thkTyVa4H3D0gzdJWz6UYuIV+HGegqKpRvWPU1kQicgnAeC0jqqh7P/IoSdUGzFH/V7mzTDmW6ro4aCYOnvg/aNG/r5+LyiGEzdSty4vLcYvd7x9AaG0u1AsnSbjS2LKpNin8oGVmcF4Wg+dx4gYACp33mIRYyxAwPk2IbRYcmgxuMh58ZhQE41w6gERlmJtn0mHT9F3cfXZG/IO+aaxrjwHvFkK5r3FkfWaQCh1UfD6IRbXmNZz7a3wsJ+ldNbt9C86xSulQwVUq78e1xoRKIaLP93ug8/0fD7RSQCdkDhoji2gu39HLV1F1x96D7SlxhSEIgyJV5Qj3pTHZ8RC82rEYJNb1PzxxjSyMoZgJtWydk0R/r8OAMWMF5I+D1cQODMutgVk7/OFK3Vc6fzn8Ebyt+OawxTJje89qCAqSlSFviAsd+wTtjbXAK1 xVhEPYZd jCFlvbsBpgnBD0XYKb3ityYv8ls4RS+FvXV1DNfw6BLafC9qYfe3NTSAotnce1y4PoxP76iAoW17tEU+19mxkwDWv6nVZonl6SZd+cC+2M+GWsCYj+edZVKYZjhtJoNnvrIbmQIUW2bEYf7iTw5pp2M9D6Hp/ycXm9GgeVTagLrQ7XnekucdPUuLm9OAY2YRGmTeIcI1X+cj5RRXbC6GxnXiKFQOA5vPV6rNeG5zGoswrAxS/Z82x9XXB7fewxpMMjrW/rfCG93o27ujAoHvlU4PoqYJVLOE8UxDQG5gqNpX2KU66VuaAGn0I+2fdIxNZhXqiNt41a2ppoAyK3tITrRJGZ+u9P7o1VDnHkQ2gFYdGqFAAU681nfWvFB77wpSA7g+vVdRJMhCJduS59Ua3Xm5o2ak3M+IY0yV17phaxzDmNyZ0xllAlBnz/ddb7xyF3Gn22bqb+lHaymiz77/eBQhZ6MPY9aPhTpwYN4Rk8i7tINQfWzH4NXsm1A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.118909, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jul 27, 2023 at 10:53=E2=80=AFPM SeongJae Park wrot= e: > > Hi Levi, > > > Thank you for quick respin. > > I still hope the subject to drop the ending period, and start the subject= with > lowercase, like other mm/damon/ commits. > Sorry to bother you, I should find why the ending period inserted.. > > As ptep_get, Use the pmdp_get wrapper when we accessing pmdval > > instead of directly dereferencing pmd. > > Based on the usual git commit message line length recommendation (72 > characters), there is nothing really wrong, but putting 'instead' at the = first > line may look more consistent with other messages. > Since this is the good place to put additional comments not suitable for = the > changelog[2], it would be helpful if you could put changes of this patch = that > made after the v1 here, from next time. > > Above comments are only my trivial and personal preferences, so I wouldn'= t ask > you to respin, unless you really want to. > > [1] https://github.com/torvalds/linux/pull/17 > [2] https://docs.kernel.org/process/submitting-patches.html#the-canonical= -patch-format Thanks for letting me know some details why I missed :) Many thanks. -------- Sincerely, Levi.