Re: [PATCH v2] damon: Use pmdp_get instead of drectly dereferencing pmd.

[Yun Levi <ppbuk5246@gmail.com>]

On Thu, Jul 27, 2023 at 10:53 PM SeongJae Park <sj@kernel.org> wrote:
>
> Hi Levi,
>
>
> Thank you for quick respin.
>
> I still hope the subject to drop the ending period, and start the subject with
> lowercase, like other mm/damon/ commits.
>

Sorry to bother you, I should find why the ending period inserted..

> > As ptep_get, Use the pmdp_get wrapper when we accessing pmdval
> > instead of directly dereferencing pmd.
>
> Based on the usual git commit message line length recommendation (72
> characters), there is nothing really wrong, but putting 'instead' at the first
> line may look more consistent with other messages.

> Since this is the good place to put additional comments not suitable for the
> changelog[2], it would be helpful if you could put changes of this patch that
> made after the v1 here, from next time.
>
> Above comments are only my trivial and personal preferences, so I wouldn't ask
> you to respin, unless you really want to.
>
> [1] https://github.com/torvalds/linux/pull/17
> [2] https://docs.kernel.org/process/submitting-patches.html#the-canonical-patch-format

Thanks for letting me know some details why I missed :)

Many thanks.

--------
Sincerely,
Levi.