From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F4D7C07E9D for ; Tue, 27 Sep 2022 01:52:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BFC2E8E009F; Mon, 26 Sep 2022 21:52:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BAB348E0090; Mon, 26 Sep 2022 21:52:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A72E48E009F; Mon, 26 Sep 2022 21:52:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 97E2F8E0090 for ; Mon, 26 Sep 2022 21:52:55 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 763521A0E05 for ; Tue, 27 Sep 2022 01:52:55 +0000 (UTC) X-FDA: 79956191910.26.3282CA8 Received: from mail-yw1-f169.google.com (mail-yw1-f169.google.com [209.85.128.169]) by imf10.hostedemail.com (Postfix) with ESMTP id 2BB81C0008 for ; Tue, 27 Sep 2022 01:52:55 +0000 (UTC) Received: by mail-yw1-f169.google.com with SMTP id 00721157ae682-351cee25568so5115267b3.1 for ; Mon, 26 Sep 2022 18:52:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=Z6mwGmWFe8kc9REvRMpgAR4kMVMlolmnZnXb+8WIi+s=; b=KrczsANKZsMTyMklSFvkrdvxJgxIFI9kJDdLp/RYNJ9YvtGYD9R9MKHZ0WZ0lg57xX qzCY3744UirNxRKftxwvbkH/QscgxysOQHIllQ4wmOvumns+waBQ3rfoqG3YWj8t8Q/V jClKe0yY8Iz7O7VfocOX5ypMwSLaOmywHHlYCR+IMzWLatpVNqGJinBmar9ctO+njQgx 2aKdMhZrj4Me8wmnJXW485T7m8DL1twJWkK4VYCLr/Pv0ECL0024G9CdkKlRWIEeg7gL YbtPq18WroXJfgls+3eyVXT3V1rPg3xZgrgCYxdS3RyNpYIS+6IXLCMpfYaGFifITt4F 27Bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=Z6mwGmWFe8kc9REvRMpgAR4kMVMlolmnZnXb+8WIi+s=; b=SLyi6wYdiNvtaumHhrCtm9s7YVbl4ooKacvTlUr92VYyXyYrkKMMg49EYwRKDovtsW j8WoYGT0LOacDdDtTQRBbRy3s69keq0RnZxC6WUR2F5tnirMUQMDr7/CBB5rlev8UUw/ Na1bohTgAfgfNNL041L6Cx0IPGU1g3JI3pYW9fZCV2RDQ6OAq0i2qQLKWRa0HA+C45fH oWj/h8vvrnEY+6UWuqLHW7jXkF1600001510Zkxp4FTJhjHOJuKN+vhKEzu7RA413teu r8C+ZrJMYO5iq1w4F5SHRvtQ/RXKxve3ffWMRG0V9MzTo9+XVPS8kLzqt3c8/M/9Y1zw ZThg== X-Gm-Message-State: ACrzQf2ci2MModxKJgUBK74x/h6qKi36wCzGKI3hgoZktPlfjhcQGM2G Cym3170Wr5rE0rMh8S5YlytrCf/P0PMFnRu5AEQ= X-Google-Smtp-Source: AMsMyM6gAGGPR+PUOGrG4fFfhdSS86IMK5BBfOlEWtVx3KSbpPeZbjLW4xppB3pBN6UZOgIWqHfGVp6f+kPtGEHGUaI= X-Received: by 2002:a81:6a05:0:b0:349:fad4:37cf with SMTP id f5-20020a816a05000000b00349fad437cfmr23936253ywc.137.1664243574189; Mon, 26 Sep 2022 18:52:54 -0700 (PDT) MIME-Version: 1.0 References: <20220926160611.48536-1-sj@kernel.org> <20220926162326.49013-1-sj@kernel.org> In-Reply-To: <20220926162326.49013-1-sj@kernel.org> From: Yun Levi Date: Tue, 27 Sep 2022 10:52:42 +0900 Message-ID: Subject: Re: [PATCH v4] damon/sysfs: Fix possible memleak on damon_sysfs_add_target. To: SeongJae Park Cc: akpm@linux-foundation.org, damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1664243575; a=rsa-sha256; cv=none; b=2hPEHNzACM9GK+yy1vwF70hp13W7iyw3Eocca+DJIIx2Y8yYzgAofrY9aVs6Cb5kw1cbgM pypXNRHLP1KM3lsfa4m0sGcDaGDFuGfxlGBLjtHC/nb5kZFYyckJwEo0PonAlhXrNuWKxc Fgt2MxpdIqMY81izsap5xWQG5ZPnM2Y= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=KrczsANK; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf10.hostedemail.com: domain of ppbuk5246@gmail.com designates 209.85.128.169 as permitted sender) smtp.mailfrom=ppbuk5246@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1664243575; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Z6mwGmWFe8kc9REvRMpgAR4kMVMlolmnZnXb+8WIi+s=; b=AgndZvaawjT28Q9AZxn940lcJGj23dXhUtQo/zRKM5rKK5x5yGN72dxqC6WJp/7ZcgKgJb HBX+FS2p7k1wy9knRPxYhyjCyUHh4SI/XUGLbsUq65q1zKbcWTL0vRL4zKtmgLun34z4nN zSC68nlsPVqf3uwgfBDV8ZkUbx0evhM= X-Stat-Signature: bjw79iepyeurmd44t74y7ub7bogigw87 X-Rspam-User: X-Rspamd-Server: rspam04 Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=KrczsANK; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf10.hostedemail.com: domain of ppbuk5246@gmail.com designates 209.85.128.169 as permitted sender) smtp.mailfrom=ppbuk5246@gmail.com X-Rspamd-Queue-Id: 2BB81C0008 X-HE-Tag: 1664243575-895214 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Thanks :) And Sorry to my mistake. On Tue, Sep 27, 2022 at 1:23 AM SeongJae Park wrote: > > I forgot removing the closing dot of the subject and making the subject > lower-case. > > On Mon, 26 Sep 2022 16:06:11 +0000 SeongJae Park wrote: > > > From: Levi Yun > > > > When damon_sysfs_add_target couldn't find proper task, > > New allocated damon_target structure isn't registered yet, > > So, it's impossible to free new allocated one by > > damon_sysfs_destroy_targets. > > > > By calling daemon_add_target as soon as allocating new target, Fix this > > Also we should s/daemon/damon/ > > I will revise and send v5. > > > possible memory leak. > > > > Fixes: a61ea561c871 ("mm/damon/sysfs: link DAMON for virtual address spaces monitoring") > > Cc: # 5.17.x > > Signed-off-by: Levi Yun > > Reviewed-by: SeongJae Park > > Signed-off-by: SeongJae Park > > --- > > > > Changes from v3 > > (https://lore.kernel.org/damon/20220925234327.26345-1-ppbuk5246@gmail.com/) > > - Fix Fixes: tag > > - Add patch changelog > > > > Changes from v2 > > (https://lore.kernel.org/damon/20220925234053.26090-1-ppbuk5246@gmail.com/) > > - Add Fixes: and Cc: stable > > > > Changes from v1 > > (https://lore.kernel.org/damon/20220925140257.23431-1-ppbuk5246@gmail.com/) > > - Do damon_add_target() earlier instead of explicitly freeing the object > > > > mm/damon/sysfs.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/mm/damon/sysfs.c b/mm/damon/sysfs.c > > index 455215a5c059..9f1219a67e3f 100644 > > --- a/mm/damon/sysfs.c > > +++ b/mm/damon/sysfs.c > > @@ -2172,12 +2172,12 @@ static int damon_sysfs_add_target(struct damon_sysfs_target *sys_target, > > > > if (!t) > > return -ENOMEM; > > + damon_add_target(ctx, t); > > if (damon_target_has_pid(ctx)) { > > t->pid = find_get_pid(sys_target->pid); > > if (!t->pid) > > goto destroy_targets_out; > > } > > - damon_add_target(ctx, t); > > err = damon_sysfs_set_regions(t, sys_target->regions); > > if (err) > > goto destroy_targets_out; > > -- > > 2.25.1