From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 193C5C433F5 for ; Wed, 2 Mar 2022 08:24:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 856448D0002; Wed, 2 Mar 2022 03:24:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7DF0B8D0001; Wed, 2 Mar 2022 03:24:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 680178D0002; Wed, 2 Mar 2022 03:24:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0045.hostedemail.com [216.40.44.45]) by kanga.kvack.org (Postfix) with ESMTP id 593478D0001 for ; Wed, 2 Mar 2022 03:24:26 -0500 (EST) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 0AC38180AC33E for ; Wed, 2 Mar 2022 08:24:26 +0000 (UTC) X-FDA: 79198759332.21.50CA8A8 Received: from mail-yb1-f175.google.com (mail-yb1-f175.google.com [209.85.219.175]) by imf05.hostedemail.com (Postfix) with ESMTP id 97144100003 for ; Wed, 2 Mar 2022 08:24:25 +0000 (UTC) Received: by mail-yb1-f175.google.com with SMTP id g1so1827668ybe.4 for ; Wed, 02 Mar 2022 00:24:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=L9rbSbvYK5rDSEFwlXV2PxcvZcFXMLcwIqFE8DUbfrQ=; b=uYr26UofS5yZvm/rbeNA7IQFxHmJzaQ1Q8XuMTqz4/dulbVtrNasTxtmu78Gdi07UN 7ZZuHVsdszoU+CIcQnLDIRQ9J193gAKpz/aSuPQH1nQ1L0wBO/4PTUaGVCMCvhVmLhbu Ce5ZCLe4iNpl6Twod2/w511EzZDpgKbhK1qXQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=L9rbSbvYK5rDSEFwlXV2PxcvZcFXMLcwIqFE8DUbfrQ=; b=tBcE519OS/t5fcnNfAGpatMvFaWUFxFboKYoB+qYg0gLKUSLmz/XhzDkODk7l8oUZq EAFWnzDTRDX8KGRLlfnjMD6AZm+MbJo8jzKuW9rLh+fu6C+1f4luZMLMG5SDaNg2H1NM J7jwmb9iZdqKS2VkOeiuoUtnI4dNIUPa8o/XWh0KdU8jam1I4smW/yr5IpxN1PDnBUDA MOMgzMshabNQhdg5IELh1xpaXu0FFk1vpU7PW78Vif9drF6Jdci+Pkt12FlLZUuBDlVJ 6v9AQ8KL/ZHdBYGoO4mf1WAZ5e5qGPZuNjHEeEYTwnj2z2qb9yM5I5UP1IKMTp6qNzPn NsRQ== X-Gm-Message-State: AOAM53128fcEgTJgmFj2qMdReytkyVeheKap1g/0uzh2uyhTR2/5CYB1 Zr5LT8vKxrP/ssWHYtHCMsPyNiMzoIX5/n1hrHKXGA== X-Google-Smtp-Source: ABdhPJyLGE8qYKTmY2jxpWZpqqYwAbb4XkXo5Ep1leshsZdl96xtFe0Ism0EWSHpEW8nArNw4bt6gRMBuN5hX1LuJGI= X-Received: by 2002:a25:6b4c:0:b0:628:757c:a379 with SMTP id o12-20020a256b4c000000b00628757ca379mr7809071ybm.645.1646209464943; Wed, 02 Mar 2022 00:24:24 -0800 (PST) MIME-Version: 1.0 References: <20220219092533.12596-1-linmiaohe@huawei.com> <20220219092533.12596-6-linmiaohe@huawei.com> In-Reply-To: <20220219092533.12596-6-linmiaohe@huawei.com> From: Vitaly Wool Date: Wed, 2 Mar 2022 09:24:14 +0100 Message-ID: Subject: Re: [PATCH 5/9] mm/z3fold: remove confusing local variable l reassignment To: Miaohe Lin Cc: Andrew Morton , Linux-MM , LKML Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam10 X-Rspam-User: X-Stat-Signature: eyktcmccp4pyomdaomowner5nzjt1387 Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=konsulko.com header.s=google header.b=uYr26Uof; spf=pass (imf05.hostedemail.com: domain of vitaly.wool@konsulko.com designates 209.85.219.175 as permitted sender) smtp.mailfrom=vitaly.wool@konsulko.com; dmarc=pass (policy=none) header.from=konsulko.com X-Rspamd-Queue-Id: 97144100003 X-HE-Tag: 1646209465-683356 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000045, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Feb 19, 2022 at 10:26 AM Miaohe Lin wrote: > > The local variable l holds the address of unbuddied[i] which won't change > after we take the pool lock. Remove it to avoid confusion. > > Signed-off-by: Miaohe Lin Reviewed-by: Vitaly Wool > --- > mm/z3fold.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/mm/z3fold.c b/mm/z3fold.c > index 2f848ea45b4d..adc0b3fa4906 100644 > --- a/mm/z3fold.c > +++ b/mm/z3fold.c > @@ -876,7 +876,6 @@ static inline struct z3fold_header *__z3fold_alloc(struct z3fold_pool *pool, > > /* Re-check under lock. */ > spin_lock(&pool->lock); > - l = &unbuddied[i]; > if (unlikely(zhdr != list_first_entry(READ_ONCE(l), > struct z3fold_header, buddy)) || > !z3fold_page_trylock(zhdr)) { > -- > 2.23.0 >