From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 079D9C433EF for ; Wed, 2 Mar 2022 08:21:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 859448D0002; Wed, 2 Mar 2022 03:21:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 809198D0001; Wed, 2 Mar 2022 03:21:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6F9268D0002; Wed, 2 Mar 2022 03:21:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.28]) by kanga.kvack.org (Postfix) with ESMTP id 6306F8D0001 for ; Wed, 2 Mar 2022 03:21:39 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 2A56D20CEF for ; Wed, 2 Mar 2022 08:21:39 +0000 (UTC) X-FDA: 79198752318.11.827DE97 Received: from mail-yb1-f174.google.com (mail-yb1-f174.google.com [209.85.219.174]) by imf13.hostedemail.com (Postfix) with ESMTP id 7E89E20002 for ; Wed, 2 Mar 2022 08:21:38 +0000 (UTC) Received: by mail-yb1-f174.google.com with SMTP id u61so1737667ybi.11 for ; Wed, 02 Mar 2022 00:21:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=c0JEyvT4sRgBeuNX2LNvd5n4DsQZeLFTyxYihUMzHKM=; b=gG8Evc6NzK22q0g35QqXRb3TUYTC/6aIy14Wcb9wYeA/FK6C/owoQ6qE/reZ2FxKjG jNE/whE3+7OncF09l5PPD/LTeQIYb8Cf40M5FTNA6/AK5ljfnZ7oK4rZYCsJL6ePvAeg zOaYcON7uBXijDR23d9gE4vG2uYmkA327GuF8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=c0JEyvT4sRgBeuNX2LNvd5n4DsQZeLFTyxYihUMzHKM=; b=1P6E84FtQ5d60kstsvfdJI0P/RKrHlHzEn/tqWPLAsvU0Vv0AGrFbY1HiglxBtSwy5 FCjcX3DuWenTc39PgVWPUi36f20RYKQdyFh5v4sZe/AFeN6Y+AA7X2fJhCNwyUChYgu1 mJNNuELg8uHNkPx+fH+hkX1cKpO4MXrNXcEKbP+jrT4aB0c6W9ZcF3lSiT6ymXwBQdhD ZHD9kcjXPhLKhcidZfkXSciI/MHCHsFdQvyRNeONLlrwarLjMh8ngoK0U5rZ3MNLw1Vp dT4uX/jqrkmNyAaSICMJFTfqKk2pmmw8aK9aOnSHHAVJCYulfdQy00Mi9qJUOn8O3Wer UrgQ== X-Gm-Message-State: AOAM531+XUZQ8aS3LlHutMnxDxHf/Mftnsq0Lr5+Hhhh/SWw+ZeISbPu ptm+nWUaFHYYT33kPSCMtsyRhTvPeEEWelm/cxXbdA== X-Google-Smtp-Source: ABdhPJxngj7bqTtU+kHzTH8YKDlxhC4TIDYb8jPFRKCeGt3hWnobuDPa98/M1pFHj1eOducxWK7gNHsUughJdOa4DI4= X-Received: by 2002:a25:f904:0:b0:628:a84d:a105 with SMTP id q4-20020a25f904000000b00628a84da105mr551866ybe.53.1646209297827; Wed, 02 Mar 2022 00:21:37 -0800 (PST) MIME-Version: 1.0 References: <20220219092533.12596-1-linmiaohe@huawei.com> <20220219092533.12596-4-linmiaohe@huawei.com> In-Reply-To: <20220219092533.12596-4-linmiaohe@huawei.com> From: Vitaly Wool Date: Wed, 2 Mar 2022 09:21:26 +0100 Message-ID: Subject: Re: [PATCH 3/9] mm/z3fold: minor clean up for z3fold_free To: Miaohe Lin Cc: Andrew Morton , Linux-MM , LKML Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 7E89E20002 X-Stat-Signature: mgbm69u7qo3ocoz8n7jmfwjw3teib51k X-Rspam-User: Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=konsulko.com header.s=google header.b=gG8Evc6N; dmarc=pass (policy=none) header.from=konsulko.com; spf=pass (imf13.hostedemail.com: domain of vitaly.wool@konsulko.com designates 209.85.219.174 as permitted sender) smtp.mailfrom=vitaly.wool@konsulko.com X-Rspamd-Server: rspam03 X-HE-Tag: 1646209298-348185 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Feb 19, 2022 at 10:26 AM Miaohe Lin wrote: > > Use put_z3fold_header() to pair with get_z3fold_header. Also fix the wrong > comments. Minor readability improvement. > > Signed-off-by: Miaohe Lin Reviewed-by: Vitaly Wool > --- > mm/z3fold.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/mm/z3fold.c b/mm/z3fold.c > index 87689f50f709..eb89271aea83 100644 > --- a/mm/z3fold.c > +++ b/mm/z3fold.c > @@ -1187,9 +1187,9 @@ static int z3fold_alloc(struct z3fold_pool *pool, size_t size, gfp_t gfp, > * @handle: handle associated with the allocation returned by z3fold_alloc() > * > * In the case that the z3fold page in which the allocation resides is under > - * reclaim, as indicated by the PG_reclaim flag being set, this function > - * only sets the first|last_chunks to 0. The page is actually freed > - * once both buddies are evicted (see z3fold_reclaim_page() below). > + * reclaim, as indicated by the PAGE_CLAIMED flag being set, this function > + * only sets the first|middle|last_chunks to 0. The page is actually freed > + * once all buddies are evicted (see z3fold_reclaim_page() below). > */ > static void z3fold_free(struct z3fold_pool *pool, unsigned long handle) > { > @@ -1247,7 +1247,7 @@ static void z3fold_free(struct z3fold_pool *pool, unsigned long handle) > } > if (page_claimed) { > /* the page has not been claimed by us */ > - z3fold_page_unlock(zhdr); > + put_z3fold_header(zhdr); > return; > } > if (test_and_set_bit(NEEDS_COMPACTING, &page->private)) { > -- > 2.23.0 >