From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43851C76195 for ; Mon, 27 Mar 2023 06:20:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9FE106B0071; Mon, 27 Mar 2023 02:20:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9AD916B0072; Mon, 27 Mar 2023 02:20:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 875066B0074; Mon, 27 Mar 2023 02:20:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 753AE6B0071 for ; Mon, 27 Mar 2023 02:20:10 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 4C848AB36B for ; Mon, 27 Mar 2023 06:20:10 +0000 (UTC) X-FDA: 80613678180.30.61890AF Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) by imf22.hostedemail.com (Postfix) with ESMTP id 810D0C0015 for ; Mon, 27 Mar 2023 06:20:08 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=konsulko.com header.s=google header.b=m6BNLiHF; spf=pass (imf22.hostedemail.com: domain of vitaly.wool@konsulko.com designates 209.85.210.177 as permitted sender) smtp.mailfrom=vitaly.wool@konsulko.com; dmarc=pass (policy=none) header.from=konsulko.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679898008; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+pVT8M+/flEwAqhJLSL+f9Jg5Iv3C+7AfVQ0msHJJA4=; b=hkInxtMwNeSVVMMIvhZppqlWIpQZbVplLdhKwsdluuPqxb+8LCEhbQkxho6W39b8YifHRB GlVNk8rHornZkONtPgUuNZyXXBbeGJcyS9NzjSAqPEE16gxtzYmYqVSXEkMJ7J5DVudcPs VfGpsokWYtq3r2aTChYcUEHZ/wWAVfc= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=konsulko.com header.s=google header.b=m6BNLiHF; spf=pass (imf22.hostedemail.com: domain of vitaly.wool@konsulko.com designates 209.85.210.177 as permitted sender) smtp.mailfrom=vitaly.wool@konsulko.com; dmarc=pass (policy=none) header.from=konsulko.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679898008; a=rsa-sha256; cv=none; b=yQNr39f0JRcE58JqoCtgDeVGPbSdFdsMVz0Akx3IBlaeYXd/0OqkZhtmHTrbJEVIMFyFGn +WyGqF6l0CrvMwHQaUufaxcet5UQgE3w/KY7zeRjy7EceTI2RSGdXyHVTrmG7+RvGRvigg 84zWZCp6x1PsWfsWuwF3P1XF4V6amYo= Received: by mail-pf1-f177.google.com with SMTP id y2so4788358pfw.9 for ; Sun, 26 Mar 2023 23:20:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; t=1679898007; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=+pVT8M+/flEwAqhJLSL+f9Jg5Iv3C+7AfVQ0msHJJA4=; b=m6BNLiHFWxAsN12NtQw/TVLjkOMZFT8qdyvsveq1/XZvvQsEmkx/fi0R/5H/iW2v9l 76iUL12CVEhjmIV4t4Qceab3dv6CNdX6vNIgMw0Y1x0WRh4uEMvHGxmsWzwboFESGQOR K8P+zG/hOUkUPwhdxo2sZsLfOled5RZ/ctLmU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679898007; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+pVT8M+/flEwAqhJLSL+f9Jg5Iv3C+7AfVQ0msHJJA4=; b=XFILO+S91VywDdXlSia6MeVUH8m9rsHVlGhMftNTyW45hUmfTNpnh8PmUC6wfzr3wD v0wOsXuqHkpz6oNM5Ihh64rBWDNXLKnRcNdBgqz/WcHgBG0kvgImNX3A2yDvCxErFxNr 6h/bTIHubW/CPwUwcGOqkxNBWSf7ubbeCRDR0/XEGMepkZL18rHg6otsmsCitm1C+N+s p3ROe4J385dOMxH+6IXnheDfiQhm2Wu7eypACco1M1dK1IRv+qw8jUtnSEUF/okFSwzc L5wc2EQBThKYvFxBxvp5aod7cJ8+tG/+2pDky/HPF0T/vhAPODmR+jyn4Z0CP3QL3ZHd lRZg== X-Gm-Message-State: AAQBX9f9gydpXVKUiLhQmd4DL7K/F9nLbxZoT0XstdKLcIkEOj7ogtqT Tt0yMlUDO0BxljU2XPNXrSHJU45hmySb7OCEMJHlUouYPX0BDwQU X-Google-Smtp-Source: AKy350YyFoSiUh+lCyVC5ztyl+nuxTPkRvalkOyA/Bve+vJHQVCDMZXkc6kT7BhejAi+91Lyc9YjSOmgAhCfdnL5qQY= X-Received: by 2002:a63:da02:0:b0:513:290b:7516 with SMTP id c2-20020a63da02000000b00513290b7516mr2471387pgh.3.1679898007229; Sun, 26 Mar 2023 23:20:07 -0700 (PDT) MIME-Version: 1.0 References: <20230322102006.780624-1-liushixin2@huawei.com> <20230322102006.780624-3-liushixin2@huawei.com> <20230323075927.GB20444@lst.de> In-Reply-To: <20230323075927.GB20444@lst.de> From: Vitaly Wool Date: Mon, 27 Mar 2023 08:19:56 +0200 Message-ID: Subject: Re: [PATCH -next v6 2/2] mm/zswap: delay the initializaton of zswap To: Christoph Hellwig Cc: Liu Shixin , Seth Jennings , Dan Streetman , Andrew Morton , Nathan Chancellor , linux-kernel@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 810D0C0015 X-Stat-Signature: q9xjt9x4h5t8osa553iqodnbxkoxmhtc X-Rspam-User: X-HE-Tag: 1679898008-916505 X-HE-Meta: U2FsdGVkX19k929pnpzs4ebBcCDGhvTCVAHhrUxZDg5NUTkqtuQJHJg4+GZrNoEO0bAFTing/UfntjiAjlT6G6Hg63kOUFVQ2aTDg/eLjE08XHaHcYSe1G2x9pO1nfLDNh1yhYOvdiwsxPt0ugOC5whWIHpNBKE8vNbDl9CDLRSryThdi4fY2UCepoozuEClE8P3W9T7xKfLmU4uNRgDIJdaT1xvQqy3M8RW1joGEinN5TO+Wqy9zI2XCz4h+tMUrZwkGQSvmjJX3pZRN8CeG5TvH97rBMRewpO6B/f0n9rj1ZkV8FvBsSM1MuKaBfsKUih2g5Rqzw7TXmqJek1oofXyHt4fw+Vtj6w7lWTOv0TdzOreSG6cveCaoS8VzaasvAD2phc6p2hVBWEF4b0K9R6SQV5Fza1CEqCsh04OSDwVN8HcqMqPdXO37m8Kjo+gpokagpud81OoJAlN0b8fPT1hwv0A0PxBH/7ai0LH3FsJk4EnEDrNaeo4dlB+uTCn4gcYyFZp23ejhXcJ7KyV/PyKLcfZImOCaj8t9tQWgI1u3sb9QSpKUzkTOmGRyb5h2/AxvkGI2uvBVN0c1LzQD5x0I2yU4MQADB9+/OqAAVfcNZW5XhZJl/vHWpCe82OgmEQID97ghd/7dtpBuoCyzxOLX/OS1rYNxgdKaulGS817UVmMlBm9DGernldc47gmNIG9+b+cFZ5eesKAAI7vTl9LIucxtmJlKR4Zf4IC3IJF1aklJrXPsg2ou2CtrgqsLqNaAnjmUyyZ+K27Wplc/TLAEKF2mN4zldvBEZWphHPlqgR3B/RoQW5FS9zZY7LNezIDcVobQQkAVtMfO3nn/iLDJTgLuSulBGI8dE5Nk3fqzhz2DBBe9JDO3snhwkQb1SFsEFlzzRJlq+D2SrvGIOqhwEhUc876OusGRhdVfrbw25/rqbAjRId+AgI32xxtIkGvODh3jEx2lGaYWuI mdetfm1K zFTygf6CNoUaYgLe0BHm6SIm74n9vCPkZog2PbL6cy6jdEEE0zXbbZdwCfo0xegCBN6+yjtk9qCcU3tdtgnfaqEcbQ0Xcc75m/J5R+HbQCGZLJGVvAgQLCH2D1jZTYGFJgY4i0i7iGV2Q6aCJ6dgy97T1GaGlDl6BQAeCfUAdANcvbV0zy8lBGBq9XIoD2WWB5D1GGUJZMt0tig6NzcqHLviC1G+FLIa9hKrf52hZYW0cs/8CIkrDF2AkFh2qxUE/fOBUWm0SZX1Aqaw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Mar 23, 2023 at 8:59=E2=80=AFAM Christoph Hellwig wrot= e: > > On Wed, Mar 22, 2023 at 06:17:12PM +0100, Vitaly Wool wrote: > > On Wed, Mar 22, 2023 at 10:30=E2=80=AFAM Liu Shixin wrote: > > > > > > Since some users may not use zswap, the zswap_pool is wasted. Save me= mory > > > by delaying the initialization of zswap until enabled. > > > > To be honest, I'm not a huge fan of this. Would enabling zswap module > > build instead solve your problem? > > making zswap build modular would be a mess. It is core MM infrastructure > and now we'd need to start dealing with adding and removing it at > runtime as well as module refcounting. Since when is it a core MM infrastructure? It is basically just a frontswap frontend. ~Vitaly