From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE9B2C3DA79 for ; Mon, 15 Jan 2024 12:27:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1647D6B0075; Mon, 15 Jan 2024 07:27:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0ED206B0078; Mon, 15 Jan 2024 07:27:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ECEF36B007B; Mon, 15 Jan 2024 07:27:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id D74926B0075 for ; Mon, 15 Jan 2024 07:27:09 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id A9F75A08A1 for ; Mon, 15 Jan 2024 12:27:09 +0000 (UTC) X-FDA: 81681470178.17.6D3FF16 Received: from mail-pg1-f174.google.com (mail-pg1-f174.google.com [209.85.215.174]) by imf14.hostedemail.com (Postfix) with ESMTP id D7A6B100006 for ; Mon, 15 Jan 2024 12:27:06 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=konsulko.com header.s=google header.b=jf206hXF; spf=pass (imf14.hostedemail.com: domain of vitaly.wool@konsulko.com designates 209.85.215.174 as permitted sender) smtp.mailfrom=vitaly.wool@konsulko.com; dmarc=pass (policy=none) header.from=konsulko.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705321627; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5AVaqD1kmny+a3DzzxHWWVHP6DeI42FQlUciU6OC6AY=; b=5CVHhsX+ufTe87BjU6MDjK4ESku3IW3pdXKZvj4onKzSVthEIJne7lH1KFA1AhQeVBMnrw FCsD8RICLJCCTMVOS03M8s97EQn7H9zmxfsONGCHvbwpfMaFlOue9DtG2nxrlgGvrcF+vj rdxd4kEYGP1EDwZlU4g1TPac3QKE3Fw= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=konsulko.com header.s=google header.b=jf206hXF; spf=pass (imf14.hostedemail.com: domain of vitaly.wool@konsulko.com designates 209.85.215.174 as permitted sender) smtp.mailfrom=vitaly.wool@konsulko.com; dmarc=pass (policy=none) header.from=konsulko.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705321627; a=rsa-sha256; cv=none; b=YvWqLhCmsmpEhl6wsKby2tfvyfHO4bf/Y/K0BWPdvFjbsmKZFQMz1dUujmbnXjqQI5FQri GEgsACZ3xiNXw+8OggA1e0bAUZLQ/FmOSeT6UusEJODxs6nr05gNdzsHKJ8xuXGlbikQlg 5zhi6y5Bt6dkg7cUB0V3cwfNnuomDAM= Received: by mail-pg1-f174.google.com with SMTP id 41be03b00d2f7-5cdfbd4e8caso6615613a12.0 for ; Mon, 15 Jan 2024 04:27:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; t=1705321625; x=1705926425; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=5AVaqD1kmny+a3DzzxHWWVHP6DeI42FQlUciU6OC6AY=; b=jf206hXFyNSwOsNapjfNNTQovD/85mF9ePy21gx+E7hKjboPuWaCRNzGEvVa9ZdJHK tcSMRqLQEZvi5yicehtcE43mPmj4KI7tWhKFLYex/yIdsnW9dc9qXDccYAygr3hGVD15 BYr2MGM2ze1yQKN1FBS6rlxMaO6ezrKLVEfEY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705321625; x=1705926425; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5AVaqD1kmny+a3DzzxHWWVHP6DeI42FQlUciU6OC6AY=; b=uf3c7eCRFTgEWgBz0Zf2/V8/XgL7kosWrnbXaRPr5NwkfJDfEFo8Dxe2nuCvAvUhkh hDqwYwptMvgt6kmQ4uwrW0lqQ0prVNPGVu7JFDsV44alaywos3evhIjlSUT1Dst7yRvM g9k8USAibOVxDwQHjMsL0+4S2ERFRLZXOAA3siI9P1HbhDC160qrWmg0+oV/6adU1P89 2gXVgZUEufgOLy3y1iZQDLW77vN8HPGQTsccG6NUVhPDfwfdxMsd8rvcX6tfsk6YNTmN QRSjKYcp3yLIKGyBCbdfYxZ90CBXZ3HKmcEZktJ7f3E2lMtwvIl0rzf856qyBj/XnVSm yaqw== X-Gm-Message-State: AOJu0YyBfb2O4+Wo54zQDYpk+ma4zLQ5HN6+jWY8TYYiwAMjOJ/7ivFK vh4kfxyFgVw341BEZazjWA6PpVsTS25c5re4CYW22QSDNvcU/A== X-Google-Smtp-Source: AGHT+IFPnDgL7DMkEwUE4dB1cOrEAgUyagMefPltAmMUPrI7hNPG4cAw+4d4SULhubx12ACgLhys+J9MpMdMa9fB8tI= X-Received: by 2002:a05:6a21:3949:b0:19b:1d4a:c4bc with SMTP id ac9-20020a056a21394900b0019b1d4ac4bcmr347314pzc.96.1705321625515; Mon, 15 Jan 2024 04:27:05 -0800 (PST) MIME-Version: 1.0 References: <20240112193103.3798287-1-yosryahmed@google.com> In-Reply-To: <20240112193103.3798287-1-yosryahmed@google.com> From: Vitaly Wool Date: Mon, 15 Jan 2024 13:26:54 +0100 Message-ID: Subject: Re: [RFC PATCH] mm: z3fold: rename CONFIG_Z3FOLD to CONFIG_Z3FOLD_DEPRECATED To: Yosry Ahmed Cc: Andrew Morton , Miaohe Lin , Johannes Weiner , Nhat Pham , Huacai Chen , WANG Xuerui , Michael Ellerman , Nicholas Piggin , Christophe Leroy , "Aneesh Kumar K.V" , "Naveen N. Rao" , linux-mm@kvack.org, loongarch@lists.linux.dev, linuxppc-dev@lists.ozlabs.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: D7A6B100006 X-Rspam-User: X-Stat-Signature: xeze4xthbjh1c3in5su1c3p65367zww3 X-Rspamd-Server: rspam01 X-HE-Tag: 1705321626-235743 X-HE-Meta: U2FsdGVkX1/bxfiW4ASDvrYqkYCTsXoBjwZlO0b3B+XO4XiP5OpreGCIqDO0nwBUPwhYjFKt4LR1OyksT9KiB/dzOvuxh5gdLAgxn5j2HRGK0I252tmKn8UdGh1yV6Vm2NNLj029JkSoeCVcQXdT4dOzqq+XVCYcVrPrJ8Y97bJEbE+cpfoSACLCJ+1d/VxOuw6RRX0Pbg9YRNeLcornvr2V32KB2yF1SxsRL7JbQXpmH3onxRJBbKwmdQyfGNk8AK08IffvsHCTu7rUs6uXr2RvHellq5uHZG7WGek5Obt7ew47+Q4RoitccW+llxWnCUXLc8T/6L8Jac6lG945vTV7kjEPQMwWDkqIgL3bSPsQy0uLREtdG9EXhGhNfHMjkzi7askyugHNm3fONNCqEfYcQUSy6AxqFA4c1Hv599g2GGjyKCJkhXcb3TrQzQSVjFEjileg6DaMJ9uaScTUD+O+0a0zrI/qQl8ZD19ABwg8tLWiDJu4AnPVdc9/kmvcSxs8QsXdwLpoYApMAoH+olXsXfxH6LoZFaiNxHff6hSQgfDBqz6uZCcPhXIiUWF3VPo7opBX+FTBVvTDURMSAjPWA/duKKOKPxMTuI1fiLOYBSZkphQrdOISX56n28iWmFaMSlnO8pfjtrJRuJUIOtwrM9pXjb5oyTlp+F5v8KzHdKvJnkl7ADGA5yTssGm4MCUocLEmLvUEank+5a6KFr4JMS38opuLF4yOJOurbCUpsIszkVhP7syXkqIWprSEmZNTlDi9LSJNSa06Bhdois6m4OvW8bFxotSC5491lx9nst8e1ZNGPEOqEIPd5Jpb42IrR48358yFP1gZe5R+xJ+KSomM8HVs8bzNtTWS9hyoL546szDBnq0qhicXuXNKsscrnLpTuvG1KapACaOu/Xihiy1+URV6tsj2QVg551sZRlBMIiNFfFF91PJqdZ/dMrjnVovmS1u26E/VBXG SnJRs3wm o9G6XwVh/TTP2rjb4ePx0YCCeG82LHsOe9irVbdqLUmN5XtTVanuhJP834y7T3/Ibc0WESCupqi7df1k0TsurlNIbRjclJa1JC1Xc3jVfKOvBb7SJzrt7Jr1YESBPH0yLxbcUfekszOxxcHab7+Gi25RUL8pXsv9k6o38EmnbphL6fM7GX7cf3xwH2GIXmQBeglcehsQXTcy06ucN85Tc3t8INupcXXCtGTKO0JIZcUWjIcmnK2phqv6AP33iciyimilgolnZim9hEtjtZe4kHPUwRt6O67XpUrJMfmA7Ed1hRCXZvQSyuxYcaMNc4bYkkPAFOWsenbIyGm4fhvZFskf+V1CF8oBU7xj8crCio1RPiv4+w8Wzv6p+DA7NNDWAONcs X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jan 12, 2024 at 8:31=E2=80=AFPM Yosry Ahmed = wrote: > > The z3fold compressed pages allocator is not widely used, most users use > zsmalloc. The only disadvantage of zsmalloc in comparison is the > dependency on MMU, and zbud is a more common option for !MMU as it was > the default zswap allocator for a long time. > > In hopes of having a single compressed pages allocator at some point, > and following in the footsteps of SLAB, deprecate z3fold. Rename the > user-visible option so that users with CONFIG_Z3FOLD=3Dy get a new prompt > with explanation during make oldconfig. Remove CONFIG_Z3FOLD=3Dy from > defconfigs. I believe that having a single compressed pages allocator is a false goal. > Existing users, if any, should voice their objections. Otherwise, we can > remove z3fold in a few releases. At this point I NACK this patch. We're about to submit an allocator which is clearly better that z3fold and is faster that zsmalloc in most cases and that submission will mark z3fold as deprecated. But for now this move is premature. Best, Vitaly > Signed-off-by: Yosry Ahmed > --- > I have limited understanding of Kconfigs. I modelled this after commit > eb07c4f39c3e ("mm/slab: rename CONFIG_SLAB to CONFIG_SLAB_DEPRECATED"), > but one difference is that CONFIG_Z3FOLD is a tristate. I made > CONFIG_Z3FOLD_DEPRECATED a boolean config, and CONFIG_Z3FOLD default y > so that it is on by default if CONFIG_Z3FOLD_DEPRECATED is selected. I > am not sure if that's the correct way to do this. > > --- > arch/loongarch/configs/loongson3_defconfig | 1 - > arch/powerpc/configs/ppc64_defconfig | 1 - > mm/Kconfig | 13 +++++++++++-- > 3 files changed, 11 insertions(+), 4 deletions(-) > > diff --git a/arch/loongarch/configs/loongson3_defconfig b/arch/loongarch/= configs/loongson3_defconfig > index 33795e4a5bd63..89b66b6c6a1d5 100644 > --- a/arch/loongarch/configs/loongson3_defconfig > +++ b/arch/loongarch/configs/loongson3_defconfig > @@ -85,7 +85,6 @@ CONFIG_ZPOOL=3Dy > CONFIG_ZSWAP=3Dy > CONFIG_ZSWAP_COMPRESSOR_DEFAULT_ZSTD=3Dy > CONFIG_ZBUD=3Dy > -CONFIG_Z3FOLD=3Dy > CONFIG_ZSMALLOC=3Dm > # CONFIG_COMPAT_BRK is not set > CONFIG_MEMORY_HOTPLUG=3Dy > diff --git a/arch/powerpc/configs/ppc64_defconfig b/arch/powerpc/configs/= ppc64_defconfig > index 544a65fda77bc..d39284489aa26 100644 > --- a/arch/powerpc/configs/ppc64_defconfig > +++ b/arch/powerpc/configs/ppc64_defconfig > @@ -81,7 +81,6 @@ CONFIG_MODULE_SIG_SHA512=3Dy > CONFIG_PARTITION_ADVANCED=3Dy > CONFIG_BINFMT_MISC=3Dm > CONFIG_ZSWAP=3Dy > -CONFIG_Z3FOLD=3Dy > CONFIG_ZSMALLOC=3Dy > # CONFIG_SLAB_MERGE_DEFAULT is not set > CONFIG_SLAB_FREELIST_RANDOM=3Dy > diff --git a/mm/Kconfig b/mm/Kconfig > index 1902cfe4cc4f5..bc6cc97c08349 100644 > --- a/mm/Kconfig > +++ b/mm/Kconfig > @@ -193,15 +193,24 @@ config ZBUD > deterministic reclaim properties that make it preferable to a h= igher > density approach when reclaim will be used. > > -config Z3FOLD > - tristate "3:1 compression allocator (z3fold)" > +config Z3FOLD_DEPRECATED > + bool "3:1 compression allocator (z3fold) (DEPRECATED)" > depends on ZSWAP > help > + Deprecated and scheduled for removal in a few cycles. If you ha= ve > + a good reason for using Z3FOLD rather than ZSMALLOC or ZBUD, pl= ease > + contact linux-mm@kvack.org and the zswap maintainers. > + > A special purpose allocator for storing compressed pages. > It is designed to store up to three compressed pages per physic= al > page. It is a ZBUD derivative so the simplicity and determinism= are > still there. > > +config Z3FOLD > + tristate > + default y > + depends on Z3FOLD_DEPRECATED > + > config ZSMALLOC > tristate > prompt "N:1 compression allocator (zsmalloc)" if ZSWAP > -- > 2.43.0.275.g3460e3d667-goog >