From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41B08C47077 for ; Tue, 16 Jan 2024 13:47:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C79AC6B0081; Tue, 16 Jan 2024 08:47:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C02D46B0082; Tue, 16 Jan 2024 08:47:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A55496B0083; Tue, 16 Jan 2024 08:47:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 8F57E6B0081 for ; Tue, 16 Jan 2024 08:47:03 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 52454A0412 for ; Tue, 16 Jan 2024 13:47:03 +0000 (UTC) X-FDA: 81685300326.29.046A5B2 Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) by imf08.hostedemail.com (Postfix) with ESMTP id 78CCA160016 for ; Tue, 16 Jan 2024 13:47:01 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=konsulko.com header.s=google header.b="KVpkadO/"; dmarc=pass (policy=none) header.from=konsulko.com; spf=pass (imf08.hostedemail.com: domain of vitaly.wool@konsulko.com designates 209.85.216.51 as permitted sender) smtp.mailfrom=vitaly.wool@konsulko.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705412821; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=35LSgqM/5mdItlSfn0MSm3uUaL2fT0kSwieOtVI7s/Y=; b=BtL2ncqpn1u4hU82l0yIR2WBX/qvqlq5PY7Xtd2Q5spzFPPYkRWMjPAtB6snlABIFOBsLk EN64IxRUNUwSe76QkgFBhv35lnYUjEYr09YoR6NVerYQZOqHBMpKyhqCRRrx3bYTgW5xAN dpFXffGhtvTbA7SicE/+9AAvsCZN7/w= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=konsulko.com header.s=google header.b="KVpkadO/"; dmarc=pass (policy=none) header.from=konsulko.com; spf=pass (imf08.hostedemail.com: domain of vitaly.wool@konsulko.com designates 209.85.216.51 as permitted sender) smtp.mailfrom=vitaly.wool@konsulko.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705412821; a=rsa-sha256; cv=none; b=pQNNhRiSzvEm3TTctlLT2ykTf7FHLx/j9YhXuoorpKm+k+hkDgwYY3IAmVZgIDYLbHuTXP Xo6LHH9AUWyXY3D++bVmTFRhQbO11jUjbXRhlSbOgZs010Zn3mxc8ctrbwwcFrYdhzVyRe cqcbbi95S1zNqoZM2oQhgR3WP8tZIKI= Received: by mail-pj1-f51.google.com with SMTP id 98e67ed59e1d1-28e33266e86so1052502a91.0 for ; Tue, 16 Jan 2024 05:47:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; t=1705412820; x=1706017620; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=35LSgqM/5mdItlSfn0MSm3uUaL2fT0kSwieOtVI7s/Y=; b=KVpkadO/2Xgs5wQlUmHKoR0SVd13ucVAUIM0H5LxjfvScOOXOf8Qfch4osSxH8a1Wx 8K1AdOD0fQYv0FHOrMVAQRRlUIhp23wEkWhGMP1sp7aOE336ymFsU8Vb/pLMguNEwjnt ROZKICiqGa/9bpMAObu7U9OmR729qpz1wKkZM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705412820; x=1706017620; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=35LSgqM/5mdItlSfn0MSm3uUaL2fT0kSwieOtVI7s/Y=; b=NCJ1uTgNpSRTfwYD0NWGiW1MHgaht3oxQsysrcalKFlN5EUwqiaU8WHnXpQxECgDPU Q53l6R3n0ME7yClVSbE/B8yRrLAH95/C1djckrZloaU1tu7Xxk0owSAl3kqNT4xOa3Kc RoaV0I+NL8cF3p4Fd+cJPTqjVDfU5xPUuAn+otASjjik6mtI9G23VSnGVPYF7hWbmxg0 cWmNRShmDZSsc2/v/P0qebWB+7itd6cLnb7kEZ/CDl2FNSNExaq8ErvFOr8iSZORkMqu gEC0q1y3zYFXyl95OOJgjsqouJt/hhTB18iTxomjL5ExK6c58BxctNwhjNkS812KTEr0 Nc9g== X-Gm-Message-State: AOJu0YxBHjpseWTmNCpCM8eTPGu3+V4E04CM3rtRnxyrTbd4VbBCkZfa H9TS9rFcr6Qcwv46DONYuG/Y10sCAIdcCVagew0mSm0n1SscPg== X-Google-Smtp-Source: AGHT+IFDpANk1YLj55RgqBhBeqJhcppCQ8nk475R6iBUM0BQVtqdtEFTP6zMTSoPM2j5awwiIilzFypaEDQBO+LJjlY= X-Received: by 2002:a17:90a:bc4b:b0:28e:766e:2f11 with SMTP id t11-20020a17090abc4b00b0028e766e2f11mr629133pjv.75.1705412820260; Tue, 16 Jan 2024 05:47:00 -0800 (PST) MIME-Version: 1.0 References: <20240109174302.680353-1-yosryahmed@google.com> <20240109190200.GA35140@cmpxchg.org> In-Reply-To: From: Vitaly Wool Date: Tue, 16 Jan 2024 14:46:48 +0100 Message-ID: Subject: Re: [PATCH] MAINTAINERS: add Yosry Ahmed as a zswap reviewer To: Yosry Ahmed Cc: Johannes Weiner , Andrew Morton , Dan Streetman , Seth Jennings , Linux-MM , Nhat Pham Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: 8uw1jhz5oftu4fz7cjaxq536xfjao1s9 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 78CCA160016 X-HE-Tag: 1705412821-504397 X-HE-Meta: U2FsdGVkX1+GyBcSqKqpMXkyVnM0iqiJxs/0n9aCoygnY5oWvbJVkSN6G6MZ9Zoy/jricsodPsHSuLFIjkixmHouu/kf8bEhKSkWlR03AhriE1xTjqhPUTFYuaAJD2s+x4A2TKPo8Bevnk/OVV5PXF10iFF6SeC/JG6XP+2u1bWBwu/SqWuvZK8UI/zCG7nOmCvs2qQDl79KKXEjvJmFsjIeULgw+Xz4z6s5hRrp0X/sS621jjKNjc/Fg8FmuEX4YV/b+s0Apapow161lkKf+D00qc2hkCfTFUnrVIW1NPxsFF1clbQuNT/36v0J0Ap2XWC6AF1pIEPZFuEjpjahHNUrPl3UpQ3T5BCIHdv/8u/fs+32nzfqBL2DHADXhlyQlxCjg1xBz+Toqx/w+NjHb0zQRkyZrC/5Nqjs7HeDOWf9H3mUUSi/ddxHwg4dPD2lg51xIM+r2A2d0Q8J2PCMlBkJViL2BaDx0p11W3AeuMpQsHCnmgcHcWV0vE7NRDiKnHAf6pmi8HIuRg5eAPvnicKE4cSHwPoCW2XhvpHBZo71PagDJEajHzv30M7J08QN5lj0XRFr+EmcVKa9PpOdRxBXdbRLpYaOxoBcG8v461qXszun8vJvXyu55i8Jdah8tpzZAPOGx4SPC1gVHn9D2w1DaBDyu4LrzuAeCnJIXddEsdSt35XbqfZWpYhgjcDvfYgIYgRcASkWXmtLG2psBVulZMSmTKjAgX1akO78xkPt7my3inE207AfMBykQFXMQ50iBgVfK9kMBQT0v0LvMkLSOUMSIZGhu+Cpsx4w/apK8J5baAUOvXgtbx8LLh2XjGnvrostCobjV7LPBe9WU2dP8UJHZjMuB3qFQs24jdLUUaCuDmicfa072Pn6YzbBAsJdPySr49lBKzftZhUs1Rj/ufRl1BQNxVrh0ELxcI9x0xm2G9Ytx9fM4VF8nXfXznBmuHNywCshy0D6GP5 Bc9bY4x2 LhyTRwfYHFhZd+3UuZE6x0hMjtmHsePvHncbrdM6uu6LtjCGs3BVU22+zMibShCwjbImWkJ3d6/5cStLDIViUOOflHE1XBIam6xxy65jBCLnDOynLGIxTu90zuaDgeH5h1Df8IslYeyPVM0RAJh2InA7g28mPPb0qumtb3tsHpFueTUKBPhv5MubT3nQk+HkKRPdGJp+b4pdeTlveN6G+d3bIhqgERxZntbk4zI2t/aSrGLx110fSCD8nvf87bdQWU839tFk+MLmasXQiizgHHfUQNkNKNCs1SZjDW9bRE0lwegMoZnfmP42xWKwDNTSOuyYjdSZBji4jqipFgYXqKcWXZ1g01AGjFIt/wtHNw/jMyXVw1hJZauEtfDs0UdtKFonuhs4IaGXnfnEc2Pt+mMUfOk4eOw9Miy2aJC8t6kOQH0kzKqKm3q3513qakcDh2exQOpxK8tdYI/IQu3pCM0Ay9FMNV5obKxYikVU4LM8S7Vr94ZUX0dhbkQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Den s=C3=B6n 14 jan. 2024 19:54Yosry Ahmed skrev: > > On Tue, Jan 9, 2024 at 11:02=E2=80=AFAM Johannes Weiner wrote: > > > > On Tue, Jan 09, 2024 at 05:43:01PM +0000, Yosry Ahmed wrote: > > > I have been actively contributing to zswap and reviewing zswap patche= s > > > for a while, and I am already getting CC'd on most of them. Add mysel= f > > > as a reviewer. While we are at it, add missing zswap files to the ent= ry > > > in MAINTAINERS. > > > > > > Signed-off-by: Yosry Ahmed > > > > Acked-by: Johannes Weiner > > > > because I agree with what you're saying. However, I think that > > maintainers entry could use some more help. You, me and Nhat have been > > doing most of the recent development and reviewing of changes in that > > space. Those patches have been largely met with radio silence by the > > existing maintainers, which makes me think the folks currently listed > > have moved on to other projects and/or aren't able to spend as many > > cycles on zswap anymore. Maybe it's time to update the list? > > > > get_maintainers.pl says this: > > > > [hannes@column linux]$ ./scripts/get_maintainer.pl --git -f mm/zswap.= c > > Johannes Weiner (maintainer:ZSWAP COMPRESSED SWA= P CACHING,commit_signer:14/29=3D48%,authored:5/29=3D17%,added_lines:121/551= =3D22%,removed_lines:192/440=3D44%) > > Yosry Ahmed (maintainer:ZSWAP COMPRESSED SWAP= CACHING,commit_signer:11/29=3D38%,authored:3/29=3D10%,added_lines:86/551= =3D16%,removed_lines:44/440=3D10%) > > Nhat Pham (maintainer:ZSWAP COMPRESSED SWAP CACHI= NG,commit_signer:9/29=3D31%) > > > > How about the below? Dan, Seth, Vitaly, what do you think? > > > > Thanks > > > > --- > > > > From 9170b8a17029550bac6b315edbd0db21504ec5d3 Mon Sep 17 00:00:00 2001 > > From: Johannes Weiner > > Date: Tue, 9 Jan 2024 13:50:53 -0500 > > Subject: [PATCH] mm: zswap: switch maintainers to recently active devel= opers > > and reviewers > > > > Signed-off-by: Johannes Weiner > > --- > > MAINTAINERS | 8 +++++--- > > 1 file changed, 5 insertions(+), 3 deletions(-) > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > index f71c525405e0..b65538e85e9c 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -24122,11 +24122,13 @@ N: zstd > > K: zstd > > > > ZSWAP COMPRESSED SWAP CACHING > > -M: Seth Jennings > > -M: Dan Streetman > > -M: Vitaly Wool > > +M: Johannes Weiner > > +M: Yosry Ahmed > > +M: Nhat Pham > > L: linux-mm@kvack.org > > S: Maintained > > +F: Documentation/admin-guide/mm/zswap.rst > > +F: include/linux/zswap.h > > F: mm/zswap.c > > Probably a bit too late, but should we also merge the zpool entry with > the zswap entry? I can send a follow up if we are in agreement. I am afraid we are not. That would be one more step in the wrong direction. ~Vitaly