From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E66B6C433F5 for ; Thu, 19 May 2022 07:00:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4293E6B0072; Thu, 19 May 2022 03:00:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3D8EB6B0073; Thu, 19 May 2022 03:00:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2C84A6B0074; Thu, 19 May 2022 03:00:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 1DE436B0072 for ; Thu, 19 May 2022 03:00:48 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id E53ED608B2 for ; Thu, 19 May 2022 07:00:47 +0000 (UTC) X-FDA: 79481594934.20.E175284 Received: from mail-yb1-f182.google.com (mail-yb1-f182.google.com [209.85.219.182]) by imf02.hostedemail.com (Postfix) with ESMTP id 3415C800E1 for ; Thu, 19 May 2022 07:00:46 +0000 (UTC) Received: by mail-yb1-f182.google.com with SMTP id x2so7132882ybi.8 for ; Thu, 19 May 2022 00:00:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NUpiriXioR9HKJDqESG1pLTNmVTqJQ+hACDCjyaXJbk=; b=KHhq/M/Lqpe7c6sxtrWJ6eCnVsP9BUpMJ3q6qR+JCwkJinKyUwQ7Iin6Gn01xD/anx cBDs7IKCIIip1ZRfnRV/iaDeoEBK70Kn5MC2xFDn7Xv3KUU7sUOlTFxpZy6YdYobr+Jq KqEl6yC9hnAyNFOzIC05q1GyZa5ZTCBJ+1Dfo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NUpiriXioR9HKJDqESG1pLTNmVTqJQ+hACDCjyaXJbk=; b=6VDWnBK9cbnWquVP7FnpstjZLNLXptTLNMSV3fru54O5os5sm9Gp2we6SoujOStBH/ 4oiv8HzGSvzbq4UKZ6EoU4dSaWw+lJm/8GPVq1ZCgw+REZMrPyVJJsnlnuFNSFG0wZBj VxXkTl72dyf8Yq3I3nFRNjM9bRqu8Y6JkAXNrRr+LnUOx9eUuHjEqPPD53tSxmWeUrIX ZDwkV/53ysYOQ0YgJt6SsshMZ7ZmjQU23h5LMBRA64XV1bylUl9OCoS1UKOmelJSBNJY N2k5ZCKkvk1FMLuGEKE4qcCiakkj6oOV/QscTXly5Z1QovfmRvELqxuVaObBcofsTlWj +k8Q== X-Gm-Message-State: AOAM531OthbQc9Sj8udkS9mXPOvYYQG1FwNZHIkUbwEBWFRH3gCeDHW4 z9gN9HUBAnJb/J5TaT+25LY7qKe+8Zd3kCphou3CiQ== X-Google-Smtp-Source: ABdhPJxPCG2ZJHqlB3IB82UVO0pEBaziFwIZZcvzkrIW+EwBzbI7In98uO5XmVYKJyu4fDh0MjLJqiJOprto/2X/GgI= X-Received: by 2002:a25:b197:0:b0:64e:ae59:e2d0 with SMTP id h23-20020a25b197000000b0064eae59e2d0mr2977308ybj.523.1652943646360; Thu, 19 May 2022 00:00:46 -0700 (PDT) MIME-Version: 1.0 References: <20220429064051.61552-1-linmiaohe@huawei.com> <20220429064051.61552-2-linmiaohe@huawei.com> In-Reply-To: <20220429064051.61552-2-linmiaohe@huawei.com> From: Vitaly Wool Date: Thu, 19 May 2022 09:00:34 +0200 Message-ID: Subject: Re: [PATCH 1/9] mm/z3fold: fix sheduling while atomic To: Miaohe Lin Cc: Andrew Morton , Linux-MM , LKML Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 3415C800E1 X-Stat-Signature: 978gcbqac84pgh48wichwsc8o6y99usw Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=konsulko.com header.s=google header.b="KHhq/M/L"; dmarc=pass (policy=none) header.from=konsulko.com; spf=pass (imf02.hostedemail.com: domain of vitaly.wool@konsulko.com designates 209.85.219.182 as permitted sender) smtp.mailfrom=vitaly.wool@konsulko.com X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1652943646-955439 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Apr 29, 2022 at 8:40 AM Miaohe Lin wrote: > > z3fold's page_lock is always held when calling alloc_slots. So gfp should > be GFP_ATOMIC to avoid "scheduling while atomic" bug. > > Fixes: fc5488651c7d ("z3fold: simplify freeing slots") > Signed-off-by: Miaohe Lin > --- > mm/z3fold.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/mm/z3fold.c b/mm/z3fold.c > index 83b5a3514427..c2260f5a5885 100644 > --- a/mm/z3fold.c > +++ b/mm/z3fold.c > @@ -941,8 +941,7 @@ static inline struct z3fold_header *__z3fold_alloc(struct z3fold_pool *pool, > } > > if (zhdr && !zhdr->slots) > - zhdr->slots = alloc_slots(pool, > - can_sleep ? GFP_NOIO : GFP_ATOMIC); > + zhdr->slots = alloc_slots(pool, GFP_ATOMIC); > return zhdr; > } Reviewed-by: Vitaly Wool > -- > 2.23.0 >